Add `TestTextField` and migrate tests by Renzo-Olivares · Pull Request #180494 · flutter/flutter

Renzo-Olivares · 2026-01-05T05:53:17Z

This PR introduces the convenience widget TestTextField in the framework widget tests. This new widget should be used in place of convenient TextField or CupertinoTextField usages in the widgets library tests.

part of: #177415

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

Renzo-Olivares · 2026-01-09T01:01:04Z

-    );
+    // Make sure the GestureDetector is big enough to be easily interactive if
+    // the handleRect is not empty.
+    final Rect interactiveRect = handleRect.isEmpty


This change was needed because

flutter/packages/flutter/test/widgets/text_selection_test.dart

Line 1232 in 96403e0

"selection handle's GestureDetector should not cover the entire screen",

was failing due to the hit rect on the selection handle always expanding even when the rect of the handle is empty.

Renzo-Olivares · 2026-01-09T18:48:17Z

+///
+/// This wrapper does not provide selection handles or context menus
+/// out of the box.
+class TestTextField extends StatefulWidget {


Should this live here/a separate file/or in flutter_test? I mention flutter_test because I don't think we generate dart docs for any classes in our widget tests and those may be helpful.

Are doc macros usable here?

I think your current location is a very good starting point. It lets us prove the API, solves our immediate need, and gives us maximum flexibility.

My suspicion is TestTextField in its current shape is most helpful for the widget library's tests, which are weird in that they cannot depend on a design system library. Other design system libraries can use their own text fields in tests directly, and might not need TestTextField at all.

Nonetheless, moving this to flutter_test seems very reasonable, but once we do so the API is locked, and our ability to do breaking changes is limited. With your current approach, we're free to move this to flutter_test whenever we'd like.

What do you think of this: design this as if it's in flutter_test, but for now keep this here?

(I don't a strong preference on whether to split this into its own file, though the current location seems very reasonable to me 👍)

Good point, I also think TestTextField will be most useful in our own widget tests. Designing as if it's in flutter_test sgtm, these helper widgets should definitely be clearly documented so users are clear what to expect when writing their own tests.

Renzo-Olivares · 2026-01-09T20:20:56Z

  testWidgets(
    'Cursor animates on iOS',
    (WidgetTester tester) async {
-      await tester.pumpWidget(const MaterialApp(home: Material(child: TextField())));


I wonder if tests like these (lots in this specific file) are good candidates to be duplicated in design libraries since they test the defaults set internally by TextField and not EditableText. or is it enough that we are setting the same defaults in TestTextField. What do others think?

My immediate though is to lean towards duplicating the tests.

My gut feeling is that we should assume TestTextField might not have high fidelity with TextField/CupertinoTextField, even if it does today. Perhaps it's best to treat TestTextField as if it's a text field from a completely different design system?

I'll defer to @justinmc here though for when they're back :)

Long term vision: Stuff like this is system UI, and it should be in Widgets where possible. Then it could be tested in Widgets only.

If the long term vision isn't possible right now, then I would move this test to Material, because the logic that it's testing is in Material (for now at least). Any duplication of that logic in TestTextField is coincidental and doesn't need to be tested anyway.

Yeah I would rope these tests into the bucket of "Tests that rely on defaults set in TextField or CupertinoTextField". For example "cursor animates on iOS", this is not an existing default behavior of EditableText only TextField and CupertinoTextField.

I ended up creating a text_field_cursor_test.dart in material and cupertino with tests that verify their internal defaults respectively. I also refactored some of the cursor tests in editable_text_cursor_test.dart that were simply testing defaults in TextField, in the widgets layer we now only test that the cursor can animate, and that even when cursorOpacityAnimates is set to true, EditableText.debugDeterministicCursor still takes precedence.

commit: 454838f (#180494)

Renzo-Olivares · 2026-01-09T20:30:44Z

This is ready for an initial review. The way I went about this is I went through all the usages of TextField in the widgets library and lazily added parameters to TestTextField as needed. I also added robust text selection gestures through TextSelectionGestureDetector, matching the same way TextField and CupertinoTextField implement their gestures (note, there weren't many tests actually using these gestures).

The main indicator to whether I should duplicate a test was whether it was a regression test. There was only a handful I duplicated and added to text_field_test.dart. All of the bugs the regression tests were targeting where reported on TextField specifically so I did not duplicate the the tests for CupertinoTextField but can do so if we think that is necessary. There are still certain tests I have noted that might deserve a closer look with regards to duplicating across design libraries, would like to hear others thoughts on these.

Another question is whether we'd this TestTextField and other similar helper test widgets to be discoverable through our online docs. If so, maybe we want to consider placing them a different location, maybe flutter_test?

There are still ~5 tests that have not been migrated to use TestTextField in this PR, that will require a closer look.

loic-sharma · 2026-01-09T21:20:56Z

    skip: kIsWeb,
  );
+
+  testWidgets('entering text does not scroll a surrounding PageView', (WidgetTester tester) async {


It's possible this test will drift over time with the corresponding one in the widgets layer. Should we add comments to keep these tests in sync? I don't feel strongly, just a thought.

Mulling on this some more. Considering these tests will eventually move to packages in another repository, keeping these in sync will be painful. Perhaps it's not even worth attempting (and thus not worth adding these comments), but I'll leave this open in case others have more thoughts.

I think in general we shouldn't need duplicate tests like this at all. If someone reports a bug in TextField, and it reproduces in EditableText, I think it's ok to fix it and test it only in EditableText. If the fix requires a change in TextField too, or if there's some other specific concern with TextField, only then we should test that in TextField too, IMO.

In this case I'm fine either way... It kind of makes sense to duplicate this test here because without it, we are losing test coverage that may have had some effect over the years. Keeping it in sync with its Widgets counterpart is probably not necessary, though.

loic-sharma · 2026-01-09T21:42:36Z

+        1920.0,
+        48.0,
+      ); //TODO(Renzo-Olivares): Should a test like this be in material,cupertino, and widgets? The shortWindowSize varies depending
+      // on the input field because of additional padding by decorators.


Don't forget to remove this TODO depending on the result of this conversation: #180494 (comment)

Expanding from that conversation, I think here it's probably fine just in Widgets. The slight differences in shortWindowSize are probably irrelevant to the overall test. If there were specific concerns about, say, TextField's behavior in a short window due to its padding, then we could test that specific case in Material too.

Agreed, this specific test is probably okay only being in the widgets library. The tests in this file are more about the behavior of the autocomplete menu and not the input field it is attached to.

loic-sharma · 2026-01-09T21:59:23Z

-    expect(scrollController.offset, 75.0);
+    expect(find.byType(EditableText), findsOneWidget);
+    // TODO(Renzo-Olivares): Decide if the below calculation is worthwhile to verify
+    // or does simply verifying that EditableText is on screen suffice.


I'm good with the keeping the calculations below if that's what you choose to do 👍

I appreciate all the thorough math here! 👍

loic-sharma · 2026-01-09T22:22:15Z

+  }
+}
+
+final TextSelectionControls testTextSelectionHandleControls = TestTextSelectionHandleControls();


Just curious, did you consider a static field named instance on TestTextSelectionHandleControls? That might be a little cleaner than a top-level global, but I don't feel strongly.

I did not consider it, I mainly followed the pattern we use in the framework (top-level global) for other text selection controls like materialTextSelectionHandleControls. It eliminates some verbosity, see below.

TestTextSelectionHandleControls.testTextSelectionHandleControls vs testTextSelectionHandleControls.

loic-sharma

This looks great, excellent work!

justinmc

LGTM 👍. Thank you @Renzo-Olivares for doing this, it's really a big help for these tests!

After writing this PR, do you have any more thoughts on whether or not some kind of widget like TestTextField might be useful for developers using only the Widgets library? Talking about outside of tests.

Also just double checking, does this PR remove all uses of TextField from Widgets?

justinmc · 2026-01-12T23:15:46Z

    skip: kIsWeb,
  );
+
+  testWidgets('entering text does not scroll a surrounding PageView', (WidgetTester tester) async {


I think in general we shouldn't need duplicate tests like this at all. If someone reports a bug in TextField, and it reproduces in EditableText, I think it's ok to fix it and test it only in EditableText. If the fix requires a change in TextField too, or if there's some other specific concern with TextField, only then we should test that in TextField too, IMO.

In this case I'm fine either way... It kind of makes sense to duplicate this test here because without it, we are losing test coverage that may have had some effect over the years. Keeping it in sync with its Widgets counterpart is probably not necessary, though.

justinmc · 2026-01-12T23:34:29Z

  testWidgets(
    'Cursor animates on iOS',
    (WidgetTester tester) async {
-      await tester.pumpWidget(const MaterialApp(home: Material(child: TextField())));


Long term vision: Stuff like this is system UI, and it should be in Widgets where possible. Then it could be tested in Widgets only.

If the long term vision isn't possible right now, then I would move this test to Material, because the logic that it's testing is in Material (for now at least). Any duplication of that logic in TestTextField is coincidental and doesn't need to be tested anyway.

justinmc · 2026-01-12T23:40:57Z

+        1920.0,
+        48.0,
+      ); //TODO(Renzo-Olivares): Should a test like this be in material,cupertino, and widgets? The shortWindowSize varies depending
+      // on the input field because of additional padding by decorators.


Expanding from that conversation, I think here it's probably fine just in Widgets. The slight differences in shortWindowSize are probably irrelevant to the overall test. If there were specific concerns about, say, TextField's behavior in a short window due to its padding, then we could test that specific case in Material too.

justinmc · 2026-01-12T23:44:21Z

-    expect(scrollController.offset, 75.0);
+    expect(find.byType(EditableText), findsOneWidget);
+    // TODO(Renzo-Olivares): Decide if the below calculation is worthwhile to verify
+    // or does simply verifying that EditableText is on screen suffice.


I appreciate all the thorough math here! 👍

Renzo-Olivares · 2026-01-16T22:56:34Z

After writing this PR, do you have any more thoughts on whether or not some kind of widget like TestTextField might be useful for developers using only the Widgets library? Talking about outside of tests.

I found that in the Widgets library convenient usages of TextField did not often make use of gestures provided by TextSelectionGestureDetector. And in the same realm I also found that most of the tests verifying gestures are in the design library tests text_field_test.dart. While EditableText does not make use of TextSelectionGestureDetector by default, it still might be useful to have some integration tests to verify both components work well together. TestTextField can likely be used for these tests. I don't think the lack of gesture usages indicates that these gestures would not be useful addition to EditableText, rather the given tests simply did not require them.

A few tests fell into the category of testing defaults set by TextField but not EditableText. I think for these category of tests we should move them to the design library and if possible write a test better catered to EditableText. For example there were various tests that verified cursor defaults set by text field, "Cursor animates on iOS", this is not a default set by EditableText, so I moved this to test to text_field_cursor_test.dart and created a new test for editable text called "Cursor animates when cursorOpacityAnimates is true".

In general I didn't find any additional evidence from the convenient usages of TextField I went through in our tests to support a TestTextField outside of tests.

Also just double checking, does this PR remove all uses of TextField from Widgets?

There are still around ~5 tests that need a deeper look when migrating.

Renzo-Olivares · 2026-01-16T23:00:42Z

Main changes from last review are in 454838f (#180494)

loic-sharma

Re-LGTM!

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/flutter@da72d59...1d9d6a9 2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157) 2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664) 2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725) 2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692) 2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690) 2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678) 2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623) 2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367) 2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671) 2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625) 2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666) 2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456) 2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494) 2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668) 2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588) 2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242) 2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795) 2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651) 2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653) 2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286) 2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641) 2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

This PR introduces the convenience widget `TestTextField` in the framework widget tests. This new widget should be used in place of convenient `TextField` or `CupertinoTextField` usages in the widgets library tests. part of: flutter#177415 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <roliv@google.com>

…r#10931) Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/flutter@da72d59...1d9d6a9 2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157) 2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664) 2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725) 2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712) 2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693) 2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692) 2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690) 2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678) 2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635) 2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623) 2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367) 2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671) 2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625) 2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666) 2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456) 2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494) 2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668) 2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588) 2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242) 2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795) 2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663) 2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651) 2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542) 2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653) 2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286) 2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641) 2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. labels Jan 5, 2026

Renzo-Olivares changed the title ~~Add BasicTestTextField and migrate tests~~ Add BasicTestTextField and migrate tests Jan 5, 2026

Renzo-Olivares force-pushed the textfield-widget-tests-rm branch from 5066aa8 to 13b0bb2 Compare January 5, 2026 09:02

Renzo-Olivares mentioned this pull request Jan 7, 2026

fix: text selection two handles directionality. #179928

Open

9 tasks

Renzo-Olivares changed the title ~~Add BasicTestTextField and migrate tests~~ Add TestTextField and migrate tests Jan 7, 2026

github-actions Bot added the f: material design flutter/packages/flutter/material repository. label Jan 7, 2026

Renzo-Olivares commented Jan 9, 2026

View reviewed changes

Renzo-Olivares force-pushed the textfield-widget-tests-rm branch from 936c30d to 469162d Compare January 9, 2026 20:22

Renzo-Olivares marked this pull request as ready for review January 9, 2026 20:24

Renzo-Olivares requested review from justinmc and loic-sharma January 9, 2026 20:32

loic-sharma reviewed Jan 9, 2026

View reviewed changes

loic-sharma approved these changes Jan 9, 2026

View reviewed changes

justinmc approved these changes Jan 12, 2026

View reviewed changes

This was referenced Jan 12, 2026

(Test cross-imports) Don't import Material in tests for convenience #177415

Open

draggable_scrollable_sheet_test/focus_traversal_test/linked_scroll_view_test/list_view_test Material imports clean up + remove Divider from scroll_view_test #180657

Closed

github-actions Bot added the f: cupertino flutter/packages/flutter/cupertino repository label Jan 16, 2026

Renzo-Olivares requested review from justinmc and loic-sharma January 16, 2026 22:59

Renzo Olivares added 3 commits January 27, 2026 15:06

fix analyzer

e959899

remove some unnecessary defaults

647f428

updates

8f4ce35

justinmc force-pushed the textfield-widget-tests-rm branch from 2e5bbfb to 8f4ce35 Compare January 27, 2026 23:06

justinmc requested a review from victorsanni January 27, 2026 23:07

navaronbracke mentioned this pull request Jan 28, 2026

Clean up cross imports in single_child_scroll_view_test.dart, decorated_sliver_test.dart, draggable_scrollable_sheet_test.dart #181613

Merged

9 tasks

loic-sharma approved these changes Jan 29, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026

auto-submit Bot added this pull request to the merge queue Jan 29, 2026

Merged via the queue into flutter:master with commit 4783676 Jan 29, 2026
71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 32aef9f3e2e1 (29 revisions) flutter/packages#10927

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

478367652 Add TestTextField and migrate tests (flutter/flutter#180494)

049b7f5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

478367652 Add TestTextField and migrate tests (flutter/flutter#180494)

0eb13ca

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to d06ccc562780 (30 revisions) flutter/packages#10928

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

478367652 Add TestTextField and migrate tests (flutter/flutter#180494)

ba0d5b6

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to d13d227639b7 (31 revisions) flutter/packages#10929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

478367652 Add TestTextField and migrate tests (flutter/flutter#180494)

ed83446

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 7323c0ee05a3 (32 revisions) flutter/packages#10930

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026

478367652 Add TestTextField and migrate tests (flutter/flutter#180494)

b74ed93

engine-flutter-autoroll mentioned this pull request Jan 30, 2026

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) flutter/packages#10931

Merged

Piinks added this to Test cross-imports Review Queue Feb 10, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Feb 10, 2026

github-project-automation Bot moved this from Todo to Done in Test cross-imports Review Queue Feb 10, 2026

Uh oh!

Conversation

Renzo-Olivares commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Renzo-Olivares Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Renzo-Olivares commented Jan 16, 2026

Uh oh!

Renzo-Olivares commented Jan 16, 2026

Renzo-Olivares commented Jan 5, 2026 •

edited

Loading

Renzo-Olivares Jan 9, 2026 •

edited

Loading

loic-sharma Jan 9, 2026 •

edited

Loading

Renzo-Olivares Jan 9, 2026 •

edited

Loading

Renzo-Olivares Jan 16, 2026 •

edited

Loading

Renzo-Olivares commented Jan 9, 2026 •

edited

Loading

loic-sharma Jan 9, 2026 •

edited

Loading

loic-sharma Jan 9, 2026 •

edited

Loading