Skip to content

[hooks] Don't run build hooks for code assets in flutter run#181542

Merged
auto-submit[bot] merged 1 commit into
masterfrom
build-hooks-flutter-run
Jan 29, 2026
Merged

[hooks] Don't run build hooks for code assets in flutter run#181542
auto-submit[bot] merged 1 commit into
masterfrom
build-hooks-flutter-run

Conversation

@dcharkes

@dcharkes dcharkes commented Jan 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Since #174685, the code assets are wrongly invoked on in the flutter run process (in addition to rightly in the flutter assemble process). This should not be the case: We don't know the target architectures we want to build for, neither do we know which native compiler is set by the native build system that is invoking us (#181004 (review)).

This PR changes the way the hooks are invoked:

The architecture becomes as follows:

  • FlutterNativeAssetsBuildRunner this is basically the wrapper around the NativeAssetsBuildRunner and there should be only one in a flutter_tools instance, unchanged.
  • FlutterHookRunner seems to be an interface to be able to supply fakes, unchanged.
  • runFlutterSpecificHooks get bool arguments whether they should build code assets and data assets.
    • The callers of these APIs know what asset types are needed in that context. The invocations added in Add data assets #174685 should be data assets only.
  • Simplification: FlutterHookRunnerNative.runHooks does no longer use globals.buildSystem.build. Instead, it directly calls runFlutterSpecificHooks.
  • The ProtocolExtensions (which determine which asset types are built) are taken from AssetBuildTargets, and take into account what asset types to build, unchanged.

Tests:

  • Code assets covered by existing integration tests such as packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
  • Data assets covered by existing integration tests such as packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
  • This PR completely deletes packages/flutter_tools/test/general.shard/build_system/targets/hook_runner_native_test.dart. It was a unit test that testsed the specific workaround, not the effect of the workaround.

the underlying issue did involve conflict between state written by the original run of the build system versus state written by the secondary run executed for the data assets. If the secondary run can be avoided, then that seems cleaner.

Yep, removed.

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Jan 27, 2026
@dcharkes dcharkes mentioned this pull request Jan 27, 2026
Merged
9 tasks
@dcharkes dcharkes force-pushed the build-hooks-flutter-run branch from d9cb477 to a4cf7f5 Compare January 27, 2026 19:25
@dcharkes dcharkes marked this pull request as ready for review January 27, 2026 20:04
@dcharkes dcharkes requested review from a team as code owners January 27, 2026 20:04
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the native asset build process to correctly differentiate between code and data asset building, especially for flutter run versus flutter assemble. The FlutterHookRunnerNative.runHooks method is simplified to directly call runFlutterSpecificHooks for data assets only, avoiding previous issues with conflicting build states. The logic for creating the FlutterNativeAssetsBuildRunner is extracted into a new helper function, improving modularity. Corresponding updates have been made across various test files to align with the new function signatures and asset build parameters. The removal of hook_runner_native_test.dart is justified as the test was for a workaround that is no longer needed.

jason-simmons
jason-simmons reviewed Jan 27, 2026
View reviewed changes

@jason-simmons jason-simmons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reidbaker reidbaker requested a review from gmackall January 27, 2026 21:17
@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Jan 29, 2026
Merged via the queue into master with commit 386826c Jan 29, 2026
145 of 146 checks passed
@auto-submit auto-submit Bot deleted the build-hooks-flutter-run branch January 29, 2026 19:38
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
386826cc6 [hooks] Don't run build hooks for code assets in `flutter r…
db35756 
…un` (flutter/flutter#181542)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
386826cc6 [hooks] Don't run build hooks for code assets in `flutter r…
d2d76c6 
…un` (flutter/flutter#181542)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
386826cc6 [hooks] Don't run build hooks for code assets in `flutter r…
83f2ba8 
…un` (flutter/flutter#181542)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
386826cc6 [hooks] Don't run build hooks for code assets in `flutter r…
50ca89b 
…un` (flutter/flutter#181542)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
386826cc6 [hooks] Don't run build hooks for code assets in `flutter r…
7972d54 
…un` (flutter/flutter#181542)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2026
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 30, 2026
@engine-flutter-autoroll
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) (#10931)
837dbbd 
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions)

flutter/flutter@da72d59...1d9d6a9

2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157)
2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664)
2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725)
2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712)
2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692)
2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690)
2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678)
2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367)
2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671)
2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625)
2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666)
2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456)
2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494)
2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668)
2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588)
2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242)
2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795)
2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651)
2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653)
2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286)
2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641)
2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
@dcharkes @LongCatIsLooong
[hooks] Don't run build hooks for code assets in flutter run (flutt…
9a95d15 
…er#181542)

Since flutter#174685, the code assets
are wrongly invoked on in the `flutter run` process (in addition to
rightly in the `flutter assemble` process). This should not be the case:
We don't know the target architectures we want to build for, neither do
we know which native compiler is set by the native build system that is
invoking us
(flutter#181004 (review)).

This PR changes the way the hooks are invoked:

* From `flutter run` only run for data assets. (Unblocks
flutter#181004)
* All other remaining calls, run for both. There might be locations
where data assets could be disabled, but they are needed from the
`DartBuild` target at least in some cases.

The architecture becomes as follows:

* `FlutterNativeAssetsBuildRunner` this is basically the wrapper around
the `NativeAssetsBuildRunner` and there should be only one in a
`flutter_tools` instance, unchanged.
* `FlutterHookRunner` seems to be an interface to be able to supply
fakes, unchanged.
* `runFlutterSpecificHooks` get bool arguments whether they should build
code assets and data assets.
* The callers of these APIs know what asset types are needed in that
context. The invocations added in
flutter#174685 should be data assets
only.
* Simplification: `FlutterHookRunnerNative.runHooks` does no longer use
`globals.buildSystem.build`. Instead, it directly calls
`runFlutterSpecificHooks`.
* This completely avoids writing to the flutter build directory, which
was the cause of flutter#178529.
* The `ProtocolExtension`s (which determine which asset types are built)
are taken from `AssetBuildTarget`s, and take into account what asset
types to build, unchanged.

Tests:

* Code assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
* Data assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
* This PR completely deletes
packages/flutter_tools/test/general.shard/build_system/targets/hook_runner_native_test.dart.
It was a unit test that testsed the specific workaround, not the effect
of the workaround.
* I've manually tested the steps in
flutter#178529 (comment),
the issue does not come back.
  
> the underlying issue did involve conflict between state written by the
original run of the build system versus state written by the secondary
run executed for the data assets. If the secondary run can be avoided,
then that seems cleaner.

Yep, removed.
@dcharkes dcharkes mentioned this pull request Feb 6, 2026
Closed
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
@dcharkes @flutter-zl
[hooks] Don't run build hooks for code assets in flutter run (flutt…
a90c799 
…er#181542)

Since flutter#174685, the code assets
are wrongly invoked on in the `flutter run` process (in addition to
rightly in the `flutter assemble` process). This should not be the case:
We don't know the target architectures we want to build for, neither do
we know which native compiler is set by the native build system that is
invoking us
(flutter#181004 (review)).

This PR changes the way the hooks are invoked:

* From `flutter run` only run for data assets. (Unblocks
flutter#181004)
* All other remaining calls, run for both. There might be locations
where data assets could be disabled, but they are needed from the
`DartBuild` target at least in some cases.

The architecture becomes as follows:

* `FlutterNativeAssetsBuildRunner` this is basically the wrapper around
the `NativeAssetsBuildRunner` and there should be only one in a
`flutter_tools` instance, unchanged.
* `FlutterHookRunner` seems to be an interface to be able to supply
fakes, unchanged.
* `runFlutterSpecificHooks` get bool arguments whether they should build
code assets and data assets.
* The callers of these APIs know what asset types are needed in that
context. The invocations added in
flutter#174685 should be data assets
only.
* Simplification: `FlutterHookRunnerNative.runHooks` does no longer use
`globals.buildSystem.build`. Instead, it directly calls
`runFlutterSpecificHooks`.
* This completely avoids writing to the flutter build directory, which
was the cause of flutter#178529.
* The `ProtocolExtension`s (which determine which asset types are built)
are taken from `AssetBuildTarget`s, and take into account what asset
types to build, unchanged.

Tests:

* Code assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
* Data assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
* This PR completely deletes
packages/flutter_tools/test/general.shard/build_system/targets/hook_runner_native_test.dart.
It was a unit test that testsed the specific workaround, not the effect
of the workaround.
* I've manually tested the steps in
flutter#178529 (comment),
the issue does not come back.
  
> the underlying issue did involve conflict between state written by the
original run of the build system versus state written by the secondary
run executed for the data assets. If the secondary run can be avoided,
then that seems cleaner.

Yep, removed.
rickhohler pushed a commit to rickhohler/flutter that referenced this pull request Feb 19, 2026
@dcharkes @rickhohler
[hooks] Don't run build hooks for code assets in flutter run (flutt…
f4fda57 
…er#181542)

Since flutter#174685, the code assets
are wrongly invoked on in the `flutter run` process (in addition to
rightly in the `flutter assemble` process). This should not be the case:
We don't know the target architectures we want to build for, neither do
we know which native compiler is set by the native build system that is
invoking us
(flutter#181004 (review)).

This PR changes the way the hooks are invoked:

* From `flutter run` only run for data assets. (Unblocks
flutter#181004)
* All other remaining calls, run for both. There might be locations
where data assets could be disabled, but they are needed from the
`DartBuild` target at least in some cases.

The architecture becomes as follows:

* `FlutterNativeAssetsBuildRunner` this is basically the wrapper around
the `NativeAssetsBuildRunner` and there should be only one in a
`flutter_tools` instance, unchanged.
* `FlutterHookRunner` seems to be an interface to be able to supply
fakes, unchanged.
* `runFlutterSpecificHooks` get bool arguments whether they should build
code assets and data assets.
* The callers of these APIs know what asset types are needed in that
context. The invocations added in
flutter#174685 should be data assets
only.
* Simplification: `FlutterHookRunnerNative.runHooks` does no longer use
`globals.buildSystem.build`. Instead, it directly calls
`runFlutterSpecificHooks`.
* This completely avoids writing to the flutter build directory, which
was the cause of flutter#178529.
* The `ProtocolExtension`s (which determine which asset types are built)
are taken from `AssetBuildTarget`s, and take into account what asset
types to build, unchanged.

Tests:

* Code assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
* Data assets covered by existing integration tests such as
packages/flutter_tools/test/integration.shard/isolated/dart_data_asset_test.dart
* This PR completely deletes
packages/flutter_tools/test/general.shard/build_system/targets/hook_runner_native_test.dart.
It was a unit test that testsed the specific workaround, not the effect
of the workaround.
* I've manually tested the steps in
flutter#178529 (comment),
the issue does not come back.
  
> the underlying issue did involve conflict between state written by the
original run of the build system versus state written by the secondary
run executed for the data assets. If the secondary run can be avoided,
then that seems cleaner.

Yep, removed.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) (flutte…
48bd1c4 
…r#10931)

Roll Flutter from da72d5936d69 to 1d9d6a9a5ef6 (33 revisions)

flutter/flutter@da72d59...1d9d6a9

2026-01-30 planetmarshall@users.noreply.github.com enable enhanced debugging for GLES playground (flutter/flutter#181157)
2026-01-30 matt.kosarek@canonical.com Make the Windows windowing_test in .ci.yaml have bringup as false (flutter/flutter#181664)
2026-01-30 engine-flutter-autoroll@skia.org Roll Packages from cd4fd61 to 510dd40 (4 revisions) (flutter/flutter#181726)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) (flutter/flutter#181725)
2026-01-30 kazbek.sultanov.doc@gmail.com Enhance error handling of WidgetsBindingObserver callbacks (flutter/flutter#181174)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) (flutter/flutter#181715)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) (flutter/flutter#181712)
2026-01-30 engine-flutter-autoroll@skia.org Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) (flutter/flutter#181693)
2026-01-30 engine-flutter-autoroll@skia.org Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) (flutter/flutter#181692)
2026-01-30 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181690)
2026-01-30 jason-simmons@users.noreply.github.com Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour (flutter/flutter#181678)
2026-01-29 34871572+gmackall@users.noreply.github.com Add `android_sdk` dependency to `android_engine_opengles_tests` (flutter/flutter#181681)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from a0685c8e946b to 920b7e24583e (3 revisions) (flutter/flutter#181680)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 128b5213711e to b9f40c193e7a (14 revisions) (flutter/flutter#181675)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that HostBuffers/DeviceBuffers allocated by RendererTest tests are valid for the lifetime of the RenderPass (flutter/flutter#181635)
2026-01-29 jason-simmons@users.noreply.github.com [Impeller] Fix off-by-one indices in the SimilarPointPair/SimilarPointTrio functions used by ShadowPathGeometryTest (flutter/flutter#181623)
2026-01-29 anishtiwari5077@gmail.com 180162 fix radio list tile and switch list tile accept widget states controller (flutter/flutter#180367)
2026-01-29 116356835+AbdeMohlbi@users.noreply.github.com Remove unused test file (flutter/flutter#181671)
2026-01-29 jason-simmons@users.noreply.github.com Roll libpng to version 1.6.54 (flutter/flutter#181625)
2026-01-29 34871572+gmackall@users.noreply.github.com Remove nonstandard ndkpath for `hybrid_android_views` integration test (flutter/flutter#181666)
2026-01-29 34465683+rkishan516@users.noreply.github.com Add TestWidgetsApp utility and refactor widget tests to use WidgetsApp (flutter/flutter#180456)
2026-01-29 rmolivares@renzo-olivares.dev Add `TestTextField` and migrate tests (flutter/flutter#180494)
2026-01-29 jacksongardner@google.com Merge changelog for 3.38.9 (flutter/flutter#181668)
2026-01-29 dacoharkes@google.com [flutter_tools] Deprecate `plugin_ffi` template (flutter/flutter#181588)
2026-01-29 brackenavaron@gmail.com Deprecate onReorder callback (flutter/flutter#178242)
2026-01-29 zhongliu88889@gmail.com [web] Use defensive null check in text editing placeElement (flutter/flutter#180795)
2026-01-29 engine-flutter-autoroll@skia.org Roll Packages from 1cb2148 to cd4fd61 (4 revisions) (flutter/flutter#181663)
2026-01-29 engine-flutter-autoroll@skia.org Roll Skia from 89df65f8324c to 128b5213711e (2 revisions) (flutter/flutter#181651)
2026-01-29 dacoharkes@google.com [hooks] Don't run build hooks for code assets in `flutter run` (flutter/flutter#181542)
2026-01-29 engine-flutter-autoroll@skia.org Roll Dart SDK from f10dcbfca98f to a0685c8e946b (5 revisions) (flutter/flutter#181653)
2026-01-29 evanwall@buffalo.edu Fixes getUniformX for Vulkan (flutter/flutter#181286)
2026-01-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from adhoq9ouVRh0xzkm3... to isy1ARvK-3bsvtfc-... (flutter/flutter#181641)
2026-01-29 dmytro@turskyi.com Add isDark, isLight, and isSystem getters to ThemeMode (flutter/flutter#181475)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons left review comments
@bkonyi bkonyi bkonyi approved these changes
@mosuem mosuem Awaiting requested review from mosuem
@gmackall gmackall Awaiting requested review from gmackall
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcharkes @jason-simmons @bkonyi