Enabled some disabled impeller fragment shader dart tests #180759

gaaclarke · 2026-01-09T17:59:43Z

Instead of having a short circuit in a long function we instead sort skia only tests into their own function. I've also enabled all the tests that pass.

issue: #122823
test exempt: is test

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request enables several previously disabled Impeller fragment shader tests by refactoring fragment_shader_test.dart. The changes also include simplifying the shader build files and updating some shaders to be compatible with Impeller. While the refactoring is mostly correct, I've found a critical issue where some Impeller-only tests have been moved to a Skia-only section, effectively disabling them. This needs to be addressed to ensure the tests run as intended.

engine/src/flutter/testing/dart/fragment_shader_test.dart

gaaclarke · 2026-01-09T18:27:58Z

One sec, going to clean this up more. Bot made a good point.

gaaclarke · 2026-01-09T18:38:05Z

Okay, that's much better. I've introduce _runSkiaTest and _runImpellerTest

walley892

I kind of dislike having all of our test fixtures in one build rule and all of the shader tests (largely) in one file. As we add more features to fragment shaders, we should consider breaking things up for maintainability. Not something that needs to be fixed now, though.

auto-submit · 2026-01-09T19:38:05Z

autosubmit label was removed for flutter/flutter/180759, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

gaaclarke · 2026-01-09T20:10:54Z

Hmm, not sure why linux_unopt failed with now warning. It ran fine locally for me on linux. I'll try rerunning them.

Command run successfully in 5.12 seconds: /usr/local/google/home/aaclarke/dev/flutter/engine/src/out/host_debug_unopt/exe.unstripped/flutter_tester --force-multithreading --disable-vm-service --enable-impeller --enable-flutter-gpu --use-test-fonts --icu-data-file-path=/usr/local/google/home/aaclarke/dev/flutter/engine/src/out/host_debug_unopt/icudtl.dat --flutter-assets-dir=/usr/local/google/home/aaclarke/dev/flutter/engine/src/out/host_debug_unopt/gen/flutter/lib/ui/assets --disable-asset-fonts /usr/local/google/home/aaclarke/dev/flutter/engine/src/out/host_debug_unopt/gen/fragment_shader_test.dart.dill (in /usr/local/google/home/aaclarke/dev/flutter/engine/src)

auto-submit · 2026-01-10T00:14:03Z

A reason for requesting a revert of flutter/flutter/180759 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

jason-simmons · 2026-01-10T00:15:35Z

Reason for revert:
Flakes in fragment_shader_test.dart are happening on LUCI after this PR.

I can reproduce these flakes in my local Linux cloud VM environment.

gaaclarke · 2026-01-10T00:18:00Z

@jason-simmons can you just disable the ones that are flaking? Otherwise can you list them so I can disable them in the reland?

…80759)" This reverts commit f36b0fb.

jason-simmons · 2026-01-10T00:19:57Z

Before the weekend I'd prefer to revert and get the tree green. We can do further investigation next week.

gaaclarke · 2026-01-10T00:22:13Z

@jason-simmons okay, can you link to the flakes so I know where to start looking?

jason-simmons · 2026-01-10T00:26:14Z

A log from a LUCI prod builder: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1401502/overview

Some exception logs from my local runs:

00:00 +41 -1: Shader Compiler appropriately pads vec3 uniform arrays 
  Expected: '#ff00ff00'
    Actual: '#ff000000'
     Which: is different.
            Expected: #ff00ff00
              Actual: #ff000000
                           ^
             Differ at offset 5


  package:matcher/src/expect/expect.dart 187:31         fail
  package:matcher/src/expect/expect.dart 182:3          _expect
  package:matcher/src/expect/expect.dart 65:3           expect
  flutter/testing/dart/fragment_shader_test.dart 661:5  _expectShaderRendersColor

00:00 -1: Shader Compiler appropriately pads vec3 uniform arrays 

  This test failed after it had already completed.
  Make sure to use a matching library which informs the test runner
  of pending async work.

  package:matcher/src/expect/expect.dart 187:31         fail
  package:matcher/src/expect/expect.dart 182:3          _expect
  package:matcher/src/expect/expect.dart 65:3           expect
  flutter/testing/dart/fragment_shader_test.dart 661:5  _expectShaderRendersColor

gaaclarke · 2026-01-10T00:27:29Z

Found them, the look similar to the one I saw above where no output is printed at all:

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1401502/overview

gaaclarke · 2026-01-10T00:34:01Z

I ran them about 20 times on my cloudtop and I couldn't reproduce it. @jason-simmons were you using ./testing/run_tests.py --type=dart --dart-filter=fragment_shader_test.dart --variant host_debug_unopt to repro or did you have to run all the tests to make it happen?

I think the no output in the failures is a mixmatch between async and non async closures. I can probably fix that.

gaaclarke · 2026-01-10T00:34:44Z

Nevermind, i got one!

…180759)" (#180785)  Reverts: #180759   Initiated by: jason-simmons   Reason for reverting: Flakes in `fragment_shader_test.dart` are happening on LUCI after this PR. I can reproduce these flakes in my local Linux cloud VM environment.   Original PR Author: gaaclarke   Reviewed By: {walley892}   This change reverts the following previous change: Instead of having a short circuit in a long function we instead sort skia only tests into their own function. I've also enabled all the tests that pass. issue: #122823 test exempt: is test ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

…utter#180759)" This reverts commit f36b0fb.

…0759) Instead of having a short circuit in a long function we instead sort skia only tests into their own function. I've also enabled all the tests that pass. issue: flutter#122823 test exempt: is test ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…utter/flutter#180759)

…lutter/flutter#180759)

…utter/flutter#180759)

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 engine-flutter-autoroll@skia.org Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 ahmedsameha1@gmail.com Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 ahmedsameha1@gmail.com Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 ahmedsameha1@gmail.com Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 dkwingsmt@users.noreply.github.com Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 codefu@google.com fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 engine-flutter-autoroll@skia.org Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 chinmaygarde@google.com Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 30870216+gaaclarke@users.noreply.github.com Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 jhy03261997@gmail.com [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 chinmaygarde@google.com Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 vhaudiquet343@hotmail.fr [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 engine-flutter-autoroll@skia.org Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 engine-flutter-autoroll@skia.org Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 koichi20021217@gmail.com Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 engine-flutter-autoroll@skia.org Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 goderbauer@google.com Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 evanwall@buffalo.edu Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 ahmedsameha1@gmail.com Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 matt.kosarek@canonical.com Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 mdebbar@google.com [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 sokolovskyi.konstantin@gmail.com Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 104009581+Saqib198@users.noreply.github.com Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 bkonyi@google.com [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 30870216+gaaclarke@users.noreply.github.com De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 zhongliu88889@gmail.com [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 iinozemtsev@google.com Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 116356835+AbdeMohlbi@users.noreply.github.com Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 1961493+harryterkelsen@users.noreply.github.com Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 bkonyi@google.com [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 engine-flutter-autoroll@skia.org Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 104147021+MohammedTarigg@users.noreply.github.com flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

…180788) relands #180759 changes since revert: 1) waits for async tests now 1) keeps 2 tests that don't pass on impeller disabled ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…lutter#180788) relands flutter#180759 changes since revert: 1) waits for async tests now 1) keeps 2 tests that don't pass on impeller disabled ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Enabled some disabled impeller fragment shader dart tests

b3aa7c0

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 9, 2026

gaaclarke requested a review from walley892 January 9, 2026 18:01

gemini-code-assist bot reviewed Jan 9, 2026

View reviewed changes

engine/src/flutter/testing/dart/fragment_shader_test.dart Outdated Show resolved Hide resolved

cleaned up everything by having helper functions for skia tests

9992a3c

gaaclarke added 2 commits January 9, 2026 10:41

denoted another atrophied test

1826b3d

another one

98791f4

walley892 approved these changes Jan 9, 2026

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

Merge branch 'master' into enable-impeller-fragment-shader-tests

8080fee

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

auto-submit bot added this pull request to the merge queue Jan 9, 2026

Merged via the queue into flutter:master with commit f36b0fb Jan 9, 2026
181 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 10, 2026

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 10, 2026

jason-simmons added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 10, 2026

auto-submit bot pushed a commit that referenced this pull request Jan 10, 2026

Revert "Enabled some disabled impeller fragment shader dart tests (#1…

87d6f60

…80759)" This reverts commit f36b0fb.

auto-submit bot mentioned this pull request Jan 10, 2026

Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" #180785

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 10, 2026

gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Jan 10, 2026

Revert "Enabled some disabled impeller fragment shader dart tests (fl…

2874a19

…utter#180759)" This reverts commit f36b0fb.

gaaclarke mentioned this pull request Jan 10, 2026

Reland Enabled some disabled impeller fragment shader dart tests #180788

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

f36b0fb Enabled some disabled impeller fragment shader dart tests (fl…

5f2ba2a

…utter/flutter#180759)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

f36b0fb Enabled some disabled impeller fragment shader dart tests (fl…

d0b2550

…lutter/flutter#180759)

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

f36b0fb Enabled some disabled impeller fragment shader dart tests (fl…

510bd00

…utter/flutter#180759)

Enabled some disabled impeller fragment shader dart tests #180759

Enabled some disabled impeller fragment shader dart tests #180759

Conversation

gaaclarke commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gaaclarke commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaaclarke commented Jan 9, 2026

Uh oh!

walley892 left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 9, 2026

Uh oh!

gaaclarke commented Jan 9, 2026

Uh oh!

Uh oh!

auto-submit bot commented Jan 10, 2026

Uh oh!

jason-simmons commented Jan 10, 2026

Uh oh!

gaaclarke commented Jan 10, 2026

Uh oh!

jason-simmons commented Jan 10, 2026

Uh oh!

gaaclarke commented Jan 10, 2026

Uh oh!

jason-simmons commented Jan 10, 2026

Uh oh!

gaaclarke commented Jan 10, 2026

Uh oh!

gaaclarke commented Jan 10, 2026

Uh oh!

gaaclarke commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gaaclarke commented Jan 9, 2026 •

edited

Loading

gaaclarke commented Jan 9, 2026 •

edited

Loading