Unpin google_mobile_ads #180573

goderbauer · 2026-01-06T12:00:39Z

Fly-by clean-up: With the recent bump to Xcode I believe pinning google_mobile_ads is no longer necessary.

I verified locally with flutter build ios --verbose that the dev/benchmarks/platform_views_layout build successfully.

Build Log

$ flutter build ios 
Resolving dependencies in `/Users/goderbauer/dev/flutter`... 
Downloading packages... 
  _fe_analyzer_shared 89.0.0 (92.0.0 available)
  adaptive_breakpoints 0.1.7 (discontinued)
  analyzer 8.2.0 (9.0.0 available)
  archive 3.6.1 (4.0.7 available)
  device_info 2.0.3 (discontinued replaced by device_info_plus)
  ffigen 18.1.0 (20.1.1 available)
  gcloud 0.8.19 (0.9.0 available)
  googleapis 12.0.0 (15.0.0 available)
  googleapis_auth 1.6.0 (2.0.0 available)
  isolate 2.1.1 (discontinued)
  js 0.7.2 (discontinued)
  metrics_center 1.0.13 (1.0.14 available)
  pedantic 1.11.1 (discontinued replaced by lints)
  petitparser 6.1.0 (7.0.1 available)
  shelf_web_socket 2.0.1 (3.0.0 available)
  xml 6.5.0 (6.6.1 available)
Got dependencies in `/Users/goderbauer/dev/flutter`!
5 packages are discontinued.
11 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Building com.yourcompany.platformViewsLayout for device (ios-release)...
To ensure your app continues to launch on upcoming iOS versions, UIScene lifecycle support will soon be required. Please see https://flutter.dev/to/uiscene-migration for the migration guide.


Warning: Missing build name (CFBundleShortVersionString).
Warning: Missing build number (CFBundleVersion).
Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store.
Found saved certificate choice "Apple Development: Michael Goderbauer (WY4DWBNV57)". To clear, use "flutter config --clear-ios-signing-settings".
Developer identity "Apple Development: Michael Goderbauer (WY4DWBNV57)" selected for iOS code signing
Running pod install...                                           1,233ms
Running Xcode build...                                                  
Xcode build done.                                           32.5s
✓ Built build/ios/iphoneos/Runner.app (20.9MB)

flutter-dashboard · 2026-01-06T12:00:42Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request unpins the google_mobile_ads dependency, which results in a major version upgrade from 5.1.0 to 7.0.0. This also brings in minor version updates for webview_flutter and webview_flutter_android. The main concern is the major version bump for google_mobile_ads, which could introduce breaking changes. The pull request description is currently a template and the pre-launch checklist is not filled out, making it difficult to assess if the necessary testing has been performed to account for this upgrade. I've added a comment to highlight the need for providing this information.

gemini-code-assist · 2026-01-06T12:01:42Z

pubspec.yaml

  google_fonts: 6.3.3
  google_identity_services_web: 0.3.3+1
-  google_mobile_ads: 5.1.0
+  google_mobile_ads: 7.0.0


Upgrading google_mobile_ads from 5.1.0 to 7.0.0 is a major version change that could introduce breaking changes. To ensure this upgrade does not cause regressions, please update the PR description to detail the verification steps taken (e.g., testing the gallery banner ad demo) and fill out the pre-launch checklist, as required by the repository's contribution guidelines.

References

The repository style guide specifies that PR descriptions must include a completed Pre-launch Checklist from the PR template. This is crucial for reviewers to understand the context and verification of the changes. ^(link)

loic-sharma · 2026-01-07T19:46:34Z

I verified locally with flutter build ios --verbose that the dev/benchmarks/platform_views_layout build successfully.

@goderbauer Just to double-check, before doing this test did you upgrade the google_mobile_ads version?

I ask because of the comment I left in #156912:

Add use_frameworks! to dev/benchmarks/platform_views_layout/ios/Podfile so that the Objective-C app can use a Swift plugin

It's possible my comment was incorrect :)

goderbauer · 2026-01-08T10:33:45Z

@loic-sharma I just double checked with a flutter clean && flutter build ios --verbose on a local checkout of this PR which includes the version bump for google_mobile_ads. It's not giving me any error and finishes successfully with ✓ Built build/ios/iphoneos/Runner.app (20.9MB) and no errors in the log.

vashworth

From triage: Let's give it a try, we can revert if it breaks

loic-sharma · 2026-01-09T16:37:09Z

@goderbauer Gotcha, thanks for double-checking!

jtmcdole · 2026-01-09T18:23:54Z

Reason for revert: broke in post submit. Requires running the lockfile generation script

This reverts commit c1e1dc2.

jtmcdole · 2026-01-09T18:39:45Z

After running the script to regenerate the lockfiles, can you use led to run Linux_pixel_7pro platform_views_hcpp_scroll_perf__timeline_summary and see that it goes green? This test has a lot of devices and runs in 6 minutes.

We should have a presubmit check to see if the lockfiles need regenerating.

Reverts: #180573   Initiated by: jtmcdole   Reason for reverting: broke in post submit. Requires running the lockfile generation script   Original PR Author: goderbauer   Reviewed By: {vashworth}   This change reverts the following previous change: Fixes #156912. Fly-by clean-up: With the recent bump to Xcode I believe pinning `google_mobile_ads` is no longer necessary. I verified locally with `flutter build ios --verbose` that the `dev/benchmarks/platform_views_layout` build successfully. <details> <summary>Build Log</summary> ``` $ flutter build ios Resolving dependencies in `/Users/goderbauer/dev/flutter`... Downloading packages... _fe_analyzer_shared 89.0.0 (92.0.0 available) adaptive_breakpoints 0.1.7 (discontinued) analyzer 8.2.0 (9.0.0 available) archive 3.6.1 (4.0.7 available) device_info 2.0.3 (discontinued replaced by device_info_plus) ffigen 18.1.0 (20.1.1 available) gcloud 0.8.19 (0.9.0 available) googleapis 12.0.0 (15.0.0 available) googleapis_auth 1.6.0 (2.0.0 available) isolate 2.1.1 (discontinued) js 0.7.2 (discontinued) metrics_center 1.0.13 (1.0.14 available) pedantic 1.11.1 (discontinued replaced by lints) petitparser 6.1.0 (7.0.1 available) shelf_web_socket 2.0.1 (3.0.0 available) xml 6.5.0 (6.6.1 available) Got dependencies in `/Users/goderbauer/dev/flutter`! 5 packages are discontinued. 11 packages have newer versions incompatible with dependency constraints. Try `flutter pub outdated` for more information. Building com.yourcompany.platformViewsLayout for device (ios-release)... To ensure your app continues to launch on upcoming iOS versions, UIScene lifecycle support will soon be required. Please see https://flutter.dev/to/uiscene-migration for the migration guide. Warning: Missing build name (CFBundleShortVersionString). Warning: Missing build number (CFBundleVersion). Action Required: You must set a build name and number in the pubspec.yaml file version field before submitting to the App Store. Found saved certificate choice "Apple Development: Michael Goderbauer (WY4DWBNV57)". To clear, use "flutter config --clear-ios-signing-settings". Developer identity "Apple Development: Michael Goderbauer (WY4DWBNV57)" selected for iOS code signing Running pod install... 1,233ms Running Xcode build... Xcode build done. 32.5s ✓ Built build/ios/iphoneos/Runner.app (20.9MB) ``` </details>  Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>

Roll Flutter from 01d37bc to 73769a2 (65 revisions) flutter/flutter@01d37bc...73769a2 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 5e855c2bb3ef to 87fbfd5381b6 (1 revision) (flutter/flutter#180800) 2026-01-10 engine-flutter-autoroll@skia.org Roll Skia from b2b109f0e980 to f39cc645b1dd (2 revisions) (flutter/flutter#180796) 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from b7963905e6a2 to 5e855c2bb3ef (2 revisions) (flutter/flutter#180794) 2026-01-10 ahmedsameha1@gmail.com Make sure that a CupertinoTabScaffold doesn't crash in 0x0 environment (flutter/flutter#179824) 2026-01-10 engine-flutter-autoroll@skia.org Roll Dart SDK from d25ad331b7ea to b7963905e6a2 (2 revisions) (flutter/flutter#180783) 2026-01-10 ahmedsameha1@gmail.com Make sure that a Container doesn't crash in 0x0 environment (flutter/flutter#180350) 2026-01-10 ahmedsameha1@gmail.com Make sure that an Expansible doesn't crash in 0x0 environment (flutter/flutter#180478) 2026-01-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enabled some disabled impeller fragment shader dart tests (#180759)" (flutter/flutter#180785) 2026-01-09 dkwingsmt@users.noreply.github.com Merge `widget_tester_leaks_free_test.dart` into `widget_tester_test.dart` (flutter/flutter#180600) 2026-01-09 codefu@google.com fix: there are no riscv fuchsia artifacts (flutter/flutter#180779) 2026-01-09 engine-flutter-autoroll@skia.org Roll Skia from 7386219151e6 to b2b109f0e980 (1 revision) (flutter/flutter#180771) 2026-01-09 chinmaygarde@google.com Re-prioritize pipeline compile jobs and perform them eagerly instead of waiting. (flutter/flutter#180022) 2026-01-09 30870216+gaaclarke@users.noreply.github.com Enabled some disabled impeller fragment shader dart tests (flutter/flutter#180759) 2026-01-09 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rxeg-6UB678HKJ4UQ... to 83Favz_zzMzdVuOHg... (flutter/flutter#180765) 2026-01-09 jhy03261997@gmail.com [A11y ] Add `clearSemantics`in table (flutter/flutter#180665) 2026-01-09 chinmaygarde@google.com Update CODEOWNERS to remove chinmaygarde. (flutter/flutter#180703) 2026-01-09 vhaudiquet343@hotmail.fr [ Tool ] Add support for linux riscv64 architecture (flutter/flutter#178711) 2026-01-09 engine-flutter-autoroll@skia.org Roll Skia from e9b3264ade0c to 7386219151e6 (12 revisions) (flutter/flutter#180754) 2026-01-09 engine-flutter-autoroll@skia.org Roll Dart SDK from fe2ba2c5dd50 to d25ad331b7ea (10 revisions) (flutter/flutter#180741) 2026-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unpin google_mobile_ads (#180573)" (flutter/flutter#180761) 2026-01-09 koichi20021217@gmail.com Fix typo in dropdown_menu.dart (flutter/flutter#180172) 2026-01-09 engine-flutter-autoroll@skia.org Roll Packages from 039a026 to 51fe1d9 (1 revision) (flutter/flutter#180742) 2026-01-09 goderbauer@google.com Unpin google_mobile_ads (flutter/flutter#180573) 2026-01-09 evanwall@buffalo.edu Update flutter changelog for 3.38.6 (flutter/flutter#180708) 2026-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix iOS xattr removal to clear all extended attributes (#180355)" (flutter/flutter#180709) 2026-01-08 ahmedsameha1@gmail.com Make sure that an EditableText doesn't crash in 0x0 environment (flutter/flutter#180457) 2026-01-08 matt.kosarek@canonical.com Implementation of tooltip windows for win32 (flutter/flutter#179147) 2026-01-08 mdebbar@google.com [web] Don't serve files outside of project (flutter/flutter#180699) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 837be28dd218 to e9b3264ade0c (1 revision) (flutter/flutter#180702) 2026-01-08 sokolovskyi.konstantin@gmail.com Add new motion accessibility features to iOS. (flutter/flutter#178102) 2026-01-08 104009581+Saqib198@users.noreply.github.com Fix iOS xattr removal to clear all extended attributes (flutter/flutter#180355) 2026-01-08 bkonyi@google.com [ Widget Preview ] Move widget_preview_scaffold tests to `dev/integration_tests/widget_preview_scaffold` (flutter/flutter#180658) 2026-01-08 30870216+gaaclarke@users.noreply.github.com De-interleaves engine dart test output (flutter/flutter#180651) 2026-01-08 zhongliu88889@gmail.com [web] Fix SemanticsService.announce not working inside dialogs (flutter/flutter#179958) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 42233226ac56 to 837be28dd218 (2 revisions) (flutter/flutter#180693) 2026-01-08 iinozemtsev@google.com Roll Dart SDK to 3.11.0-296.2.beta (flutter/flutter#180685) 2026-01-08 116356835+AbdeMohlbi@users.noreply.github.com Improve code quality in `AndroidTouchProcessorTest.java` (flutter/flutter#180583) 2026-01-08 1961493+harryterkelsen@users.noreply.github.com Revert "Reverts "[reland] Unify canvas creation and Surface code in S…kwasm and CanvasKit (#179473)" (#180152)" (flutter/flutter#180610) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from a0c407bce408 to 42233226ac56 (4 revisions) (flutter/flutter#180688) 2026-01-08 bkonyi@google.com [ Tool ] Fix flake in overall_experience_test.dart (flutter/flutter#180655) 2026-01-08 engine-flutter-autoroll@skia.org Roll Packages from 9705815 to 039a026 (6 revisions) (flutter/flutter#180684) 2026-01-08 104147021+MohammedTarigg@users.noreply.github.com flutter_tools: Auto-generate ExportOptions.plist for manual iOS code signing (flutter/flutter#177888) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 58837e160874 to a0c407bce408 (2 revisions) (flutter/flutter#180679) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 1e3266fdba86 to 58837e160874 (1 revision) (flutter/flutter#180677) 2026-01-08 engine-flutter-autoroll@skia.org Roll Skia from 3c47ea10638f to 1e3266fdba86 (4 revisions) (flutter/flutter#180675) 2026-01-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTvN_JVSCfGFRasvH... to rxeg-6UB678HKJ4UQ... (flutter/flutter#180673) ...

goderbauer · 2026-01-12T09:39:32Z

After running the script to regenerate the lockfiles

@jtmcdole What lockfiles need to be regenerated? What's the script to do this?

jtmcdole · 2026-01-12T16:08:18Z

@gmackall can likely point you to the script, or ask in the android chat room?

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 6, 2026

gemini-code-assist bot reviewed Jan 6, 2026

View reviewed changes

goderbauer requested a review from loic-sharma January 6, 2026 13:05

goderbauer added 2 commits January 7, 2026 09:38

Unpin google_mobile_ads

8efbaf4

update hash

83c4690

goderbauer force-pushed the unpunads branch from f84fbb6 to 83c4690 Compare January 7, 2026 08:39

loic-sharma added the team-ios Owned by iOS platform team label Jan 7, 2026

vashworth approved these changes Jan 8, 2026

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

auto-submit bot added this pull request to the merge queue Jan 9, 2026

Merged via the queue into flutter:master with commit c1e1dc2 Jan 9, 2026
143 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2026

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

62dd062

This was referenced Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to c1e1dc260fb7 (43 revisions) flutter/packages#10757

Closed

Roll Flutter from 01d37bc80fd5 to fd1fad23f595 (44 revisions) flutter/packages#10759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

7630e3d

engine-flutter-autoroll mentioned this pull request Jan 9, 2026

Roll Flutter from 01d37bc80fd5 to 61b241292e19 (45 revisions) flutter/packages#10760

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 9, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

dc6686f

jtmcdole added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 9, 2026

auto-submit bot pushed a commit that referenced this pull request Jan 9, 2026

Revert "Unpin google_mobile_ads (#180573)"

831ee78

This reverts commit c1e1dc2.

auto-submit bot mentioned this pull request Jan 9, 2026

Reverts "Unpin google_mobile_ads (#180573)" #180761

Merged

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 9, 2026

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 0b7596b3f269 (64 revisions) flutter/packages#10768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

f51ae12

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

00875c2

engine-flutter-autoroll mentioned this pull request Jan 10, 2026

Roll Flutter from 01d37bc80fd5 to 73769a220639 (65 revisions) flutter/packages#10770

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2026

c1e1dc2 Unpin google_mobile_ads (flutter/flutter#180573)

e30bc08

goderbauer mentioned this pull request Jan 12, 2026

Reland "Unpin google_mobile_ads" #180838

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unpin google_mobile_ads #180573

Unpin google_mobile_ads #180573

goderbauer commented Jan 6, 2026 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jan 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 6, 2026

Uh oh!

loic-sharma commented Jan 7, 2026 •

edited

Loading

Uh oh!

goderbauer commented Jan 8, 2026 •

edited

Loading

Uh oh!

vashworth left a comment

Uh oh!

loic-sharma commented Jan 9, 2026

Uh oh!

Uh oh!

jtmcdole commented Jan 9, 2026

Uh oh!

jtmcdole commented Jan 9, 2026

Uh oh!

goderbauer commented Jan 12, 2026

Uh oh!

jtmcdole commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Unpin google_mobile_ads #180573

Unpin google_mobile_ads #180573

Conversation

goderbauer commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Jan 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Jan 9, 2026

Uh oh!

Uh oh!

jtmcdole commented Jan 9, 2026

Uh oh!

jtmcdole commented Jan 9, 2026

Uh oh!

goderbauer commented Jan 12, 2026

Uh oh!

jtmcdole commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

goderbauer commented Jan 6, 2026 •

edited

Loading

loic-sharma commented Jan 7, 2026 •

edited

Loading

goderbauer commented Jan 8, 2026 •

edited

Loading