Don't embed unreferenced assets #179251

simolus3 · 2025-11-30T19:25:42Z

When a Flutter app depends on a package using hooks to add code assets, those get built to build/native_assets/$platform, where $platform is something like ios or macos. Crucially, there's no difference between simulator or release builds here, all native assets for a platform end up in that directory.

To embed those frameworks with the app, the "sign and embed" stage of an XCode build invokes xcode_backend.dart, which then copies all frameworks from build/native_assets/$targetPlatform into $build/Runner.app/Frameworks. This is a problem when a developer runs a simulator build followed by a release build without clearing the build folder in between, since both assets would be in build/native_assets/ios at that point.

This fixes the issue by:

Reading the native_assets.json file emitted by the main build.
Only copying frameworks referenced in that file.

This still needs an integration test.

Closes #178602.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2025-11-30T19:25:45Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request changes the logic for embedding native assets in Xcode builds. Instead of copying all assets, it now reads the native_assets.json file to determine which assets are actually referenced by the build, and only copies those. This prevents bundling of unreferenced assets, for example from a previous simulator build when creating a release build. The changes look good and address the issue described. I've added a couple of suggestions to improve the robustness of the JSON and path parsing logic.

gemini-code-assist · 2025-11-30T19:29:35Z

packages/flutter_tools/bin/xcode_backend.dart

+    final nativeAssetsSpec = json.decode(nativeAssetsJson.readAsStringSync()) as Map;
+    for (final Object? perPlatform
+        in (nativeAssetsSpec['native-assets'] as Map<String, Object?>).values) {
+      for (final Object? asset in (perPlatform! as Map<String, Object?>).values) {


The JSON parsing here could be made more robust. The current implementation uses several unsafe casts (as Map, as Map<String, Object?>) and a null assertion (!) which could lead to runtime errors if native_assets.json has an unexpected structure or is empty/malformed. Consider using type checks and safer access patterns to make this code more resilient against such issues.

It would be better to have a reusable format, I've filed dart-lang/native#2860. For now you could consider simply copy-pasting the validate method from pkg/vm/lib/native_assets/validator.dart from the Dart SDK.

For the error messages we should probably follow: // "error:" prefix makes this show up as an Xcode compilation error..

FWIW I don't think we can import any packages into xcode_backend.dart, so even if there was a Dart package it wouldn't help for this.

But to be honest, I don't really see the value of doing a complete validation on that file. It's generated via hooks_runner in the main build, and we can reasonably expect it to be well-formed. There are plenty of places in xcode_backend.dart relying on the main build emitting files at specific paths that would crash on a mismatch. I don't see why this specifically should be checked more defensively.

I can copy and adapt the validator if you think that improves the logic here. But to me, xcode_backend.dart reads like it's specifically written to do as little as possible and doesn't import any libraries outside of the Dart SDK. Copying the entire validator (which would be around 30% of that file when added) just to be able to generate better error messages when we're unable to extract absolute framework paths just doesn't sound that helpful to me.

I mostly agree, however, I think the whole thing should be wrapped in a try catch so that if something does go wrong unexpectedly, we have a clearer indication of why.

try { // Parse json file } on Exception catch (e, stackTrace) { echo(e.toString()); echo(stackTrace.toString()); echoXcodeError('Failed to embed native assets: $e'); exit(-1); }

packages/flutter_tools/bin/xcode_backend.dart

jmagman

I think you're operating at the wrong layer here. last_build_id is created and used in service of the build system fingerprinting system, but you're hijacking that fingerprinting one layer too high.
Read about it in the long docs around here:

flutter/packages/flutter_tools/lib/src/build_system/build_system.dart

Lines 60 to 78 in d18ab0e

    
           /// To determine if the action for a target needs to be executed, the 
        
           /// [BuildSystem] computes a key of the file contents for both inputs and 
        
           /// outputs. This is tracked separately in the [FileStore]. The key may 
        
           /// be either an md5 hash of the file contents or a timestamp. 
        
           /// 
        
           /// A Target has both implicit and explicit inputs and outputs. Only the 
        
           /// latter are safe to evaluate before invoking the [build] action. For example, 
        
           /// a wildcard output pattern requires the outputs to exist before it can 
        
           /// glob files correctly. 
        
           /// 
        
           /// - All listed inputs are considered explicit inputs. 
        
           /// - Outputs which are provided as [Source.pattern]. 
        
           ///   without wildcards are considered explicit. 
        
           /// - The remaining outputs are considered implicit. 
        
           /// 
        
           /// For each target, executing its action creates a corresponding stamp file 
        
           /// which records both the input and output files. This file is read by 
        
           /// subsequent builds to determine which file hashes need to be checked. If the 
        
           /// stamp file is missing, the target's action is always rerun.

I suspect some native asset files (native_assets.json ?) need to be added to the inputs and/or outputs of the build system.

Example:

flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart

Lines 157 to 161 in d18ab0e

    
           List<Source> get inputs => const <Source>[ 
        
             Source.pattern('{FLUTTER_ROOT}/packages/flutter_tools/lib/src/build_system/targets/ios.dart'), 
        
             Source.pattern('{BUILD_DIR}/app.dill'), 
        
             Source.artifact(Artifact.engineDartBinary), 
        
             Source.artifact(Artifact.skyEnginePath),

cc @dcharkes

dcharkes · 2025-12-02T15:39:06Z

When a Flutter app depends on a package using hooks to add code assets, those get built to build/native_assets/$platform, where $platform is something like ios or macos. Crucially, there's no difference between simulator or release builds here, all native assets for a platform end up in that directory.

To embed those frameworks with the app, the "sign and embed" stage of an XCode build invokes xcode_backend.dart, which then copies all frameworks from build/native_assets/$targetPlatform into $build/Runner.app/Frameworks. This is a problem when a developer runs a simulator build followed by a release build without clearing the build folder in between, since both assets would be in build/native_assets/ios at that point.

This fixes the issue by:

Reading the native_assets.json file emitted by the main build.

Only copying frameworks referenced in that file.

Nice catch @simolus3!

(FYI. I'm currently OOO, so I will only have time to review this in 2 weeks when I'm back.)

dcharkes

Thanks @simolus3!

This still needs an integration test.

This could be done in packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart, with running a flutter run on the simulator with a native asset in a dev dependency. And subsequently running flutter build in release mode. However, that test already runs quite long.

Can we check whether the files not referenced get copied in packages/flutter_tools/test/general.shard/xcode_backend_test.dart or packages/flutter_tools/test/integration.shard/xcode_backend_test.dart instead?

LGTM once covered with test.

packages/flutter_tools/bin/xcode_backend.dart

dcharkes · 2025-12-15T09:13:00Z

packages/flutter_tools/bin/xcode_backend.dart

+    final nativeAssetsSpec = json.decode(nativeAssetsJson.readAsStringSync()) as Map;
+    for (final Object? perPlatform
+        in (nativeAssetsSpec['native-assets'] as Map<String, Object?>).values) {
+      for (final Object? asset in (perPlatform! as Map<String, Object?>).values) {


It would be better to have a reusable format, I've filed dart-lang/native#2860. For now you could consider simply copy-pasting the validate method from pkg/vm/lib/native_assets/validator.dart from the Dart SDK.

For the error messages we should probably follow: // "error:" prefix makes this show up as an Xcode compilation error..

simolus3 · 2025-12-16T22:05:51Z

Can we check whether the files not referenced get copied in packages/flutter_tools/test/general.shard/xcode_backend_test.dart or packages/flutter_tools/test/integration.shard/xcode_backend_test.dart instead?

I've adapted existing tests in packages/flutter_tools/test/general.shard/xcode_backend_test.dart to ensure we're not copying additional frameworks for macOS or iOS builds.

Since the existing integration tests pass (edit: whops, actually they don't), that kind of serves as a validation that we are able to parse real NativeAssetsManifest.json files correctly (since frameworks would not get copied otherwise).

dcharkes

I've adapted existing tests in packages/flutter_tools/test/general.shard/xcode_backend_test.dart to ensure we're not copying additional frameworks for macOS or iOS builds.

Since the existing integration tests pas (edit: whops, actually they don't), that kind of serves as a validation that we are able to parse real NativeAssetsManifest.json files correctly (since frameworks would not get copied otherwise).

SGTM 👍

dcharkes · 2025-12-17T09:53:51Z

packages/flutter_tools/bin/xcode_backend.dart

+    final nativeAssetsSpec = json.decode(nativeAssetsJson.readAsStringSync()) as Map;
+    for (final Object? perPlatform
+        in (nativeAssetsSpec['native-assets'] as Map<String, Object?>).values) {
+      for (final Object? asset in (perPlatform! as Map<String, Object?>).values) {


dcharkes · 2025-12-17T14:24:10Z

Friendly ping @jmagman

I'll dismiss my review, over to Victoria to review.

jmagman · 2025-12-18T22:39:47Z

I dismissed by block, but I'd like @vashworth to review this when she gets back.

packages/flutter_tools/bin/xcode_backend.dart

vashworth · 2025-12-19T16:47:20Z

packages/flutter_tools/bin/xcode_backend.dart

+    final nativeAssetsSpec = json.decode(nativeAssetsJson.readAsStringSync()) as Map;
+    for (final Object? perPlatform
+        in (nativeAssetsSpec['native-assets'] as Map<String, Object?>).values) {
+      for (final Object? asset in (perPlatform! as Map<String, Object?>).values) {


I mostly agree, however, I think the whole thing should be wrapped in a try catch so that if something does go wrong unexpectedly, we have a clearer indication of why.

try { // Parse json file } on Exception catch (e, stackTrace) { echo(e.toString()); echo(stackTrace.toString()); echoXcodeError('Failed to embed native assets: $e'); exit(-1); }

vashworth · 2025-12-19T19:07:48Z

packages/flutter_tools/bin/xcode_backend.dart

+      echo(e.toString());
+      echo(stackTrace.toString());
+      echoXcodeError('Failed to embed native assets: $e');
+      exitApp(1);


Why not exit(-1);?

Sorry, I misread your original suggestion.

I've used exitApp because it calls exit in the real script but throws an exception that can be caught in TestContext. I'm using that for a test verifying that we exit with that message in case of a corrupt native asset manifest.

I'm still using exitApp, but I've replaced the exit code of 1 with -1 as per your original suggestion. Let me know if there's something I'm missing about exitApp being inappropriate here.

auto-submit · 2026-01-05T19:18:25Z

autosubmit label was removed for flutter/flutter/179251, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from 13b2b91 to 01d37bc (74 revisions) flutter/flutter@13b2b91...01d37bc 2026-01-07 stuartmorgan@google.com Replace Hybrid Composition wiki page with dev-facing content (flutter/flutter#180642) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Improve code quality in `FlutterActivityTest.java` (flutter/flutter#180585) 2026-01-07 iinozemtsev@google.com Roll Dart SDK to 3.11.0-296.1.beta (flutter/flutter#180633) 2026-01-07 vegorov@google.com Bump target Windows version to 10 (flutter/flutter#180624) 2026-01-07 goderbauer@google.com Run hook_user_defines and link_hook integration tests on CI (flutter/flutter#180622) 2026-01-07 iliyazelenkog@gmail.com Fix division by zero in RenderTable intrinsic size methods (flutter/flutter#178217) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Remove more `requires 24` anotations (flutter/flutter#180116) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 3971dbb85d45 to c5359a4d720e (1 revision) (flutter/flutter#180631) 2026-01-07 huy@nevercode.io Fix TabBar.image does not render at initialIndex for the first time (flutter/flutter#179616) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 1e7ad625f6f7 to 3971dbb85d45 (3 revisions) (flutter/flutter#180627) 2026-01-07 goderbauer@google.com Unpin DDS (flutter/flutter#180571) 2026-01-07 bruno.leroux@gmail.com Fix DropdownMenuEntry.style not resolved when entry is highlighted (flutter/flutter#178873) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `@RequiresApi24` annotations from FlutterFragment methods (flutter/flutter#180117) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 7fc63228056b to 1e7ad625f6f7 (1 revision) (flutter/flutter#180616) 2026-01-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QfR2ZFZ5kGTD3raO3... to dTvN_JVSCfGFRasvH... (flutter/flutter#180612) 2026-01-07 bkonyi@google.com [ Widget Preview ] Add support for `dart:ffi` imports (flutter/flutter#180586) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from eec90000a899 to 7fc63228056b (2 revisions) (flutter/flutter#180608) 2026-01-07 ulisses.hen@hotmail.com Add --web-define flag for template variable injection in Flutter web builds (flutter/flutter#175805) 2026-01-07 codefu@google.com docs(engine): update rbe notes (flutter/flutter#180599) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from b6249496c230 to eec90000a899 (3 revisions) (flutter/flutter#180602) 2026-01-06 146823759+brahim-guaali@users.noreply.github.com Forward proxy 404 responses to client (flutter/flutter#179858) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 40a8c6188f7f to d2e3ce177270 (1 revision) (flutter/flutter#180598) 2026-01-06 104009581+Saqib198@users.noreply.github.com Restore CLI precedence for web headers and HTTPS over web_dev_config.yaml (flutter/flutter#179639) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from f5d9da13d56d to b6249496c230 (1 revision) (flutter/flutter#180596) 2026-01-06 dkwingsmt@users.noreply.github.com Enable misc leak tracking (flutter/flutter#176992) 2026-01-06 dacoharkes@google.com [hooks] Don't require NDK for Android targets (flutter/flutter#180594) 2026-01-06 kjlubick@users.noreply.github.com [skia] Disable legacy non-const SkData APIs (flutter/flutter#179684) 2026-01-06 48625061+muradhossin@users.noreply.github.com Fix/ios share context menu (flutter/flutter#176199) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from b970aeffa66f to f5d9da13d56d (5 revisions) (flutter/flutter#180588) 2026-01-06 goderbauer@google.com Manually bump dependencies (flutter/flutter#180509) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 8150be8a0e48 to 40a8c6188f7f (2 revisions) (flutter/flutter#180582) 2026-01-06 engine-flutter-autoroll@skia.org Roll Packages from 12eb764 to d3f860d (2 revisions) (flutter/flutter#180581) 2026-01-06 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MHF-UAfO6sVKqSEYk... to nR2ESa1Gd8yPcWo06... (flutter/flutter#180578) 2026-01-06 sokolovskyi.konstantin@gmail.com Add tooltip support to PlatformMenuItem and PlatformMenu. (flutter/flutter#180069) 2026-01-06 bruno.leroux@gmail.com Add DropdownMenuFormField.errorBuilder (flutter/flutter#179345) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 1845397e11ba to b970aeffa66f (2 revisions) (flutter/flutter#180566) 2026-01-06 oss@simonbinder.eu Don't embed unreferenced assets (flutter/flutter#179251) 2026-01-06 116356835+AbdeMohlbi@users.noreply.github.com Improve documentation about ValueNotifier's behavior (flutter/flutter#179870) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 904ba00331ca to 1845397e11ba (5 revisions) (flutter/flutter#180558) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 2fb9ad834c4d to 8150be8a0e48 (1 revision) (flutter/flutter#180557) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 98c042dde68c to 904ba00331ca (3 revisions) (flutter/flutter#180550) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from ba9f7f790966 to 2fb9ad834c4d (2 revisions) (flutter/flutter#180548) 2026-01-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ubBGcRaAKWKihQ4ac... to QfR2ZFZ5kGTD3raO3... (flutter/flutter#180547) 2026-01-06 ahmedsameha1@gmail.com Make sure that a DraggableScrollableSheet doesn't crash in 0x0 enviro… (flutter/flutter#180433) 2026-01-06 ahmedsameha1@gmail.com Make sure that a ColorFiltered doesn't crash 0x0 environment (flutter/flutter#180307) 2026-01-06 ahmedsameha1@gmail.com Make sure that a FadeInImage doesn't crash in 0x0 environment (flutter/flutter#180495) ...

simolus3 requested a review from a team as a code owner November 30, 2025 19:25

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Nov 30, 2025

gemini-code-assist bot reviewed Nov 30, 2025

View reviewed changes

jmagman previously requested changes Dec 1, 2025

View reviewed changes

dcharkes mentioned this pull request Dec 4, 2025

Flutter 3.38.1: Failed to Verify when Submitting to App Store Connect #178602

Closed

dcharkes mentioned this pull request Dec 15, 2025

Create a syntax package for the native_assets.yaml format dart-lang/native#2860

Open

dcharkes approved these changes Dec 15, 2025

View reviewed changes

simolus3 force-pushed the only-copy-referenced-native-assets branch from d78ee30 to c3dca22 Compare December 16, 2025 21:44

github-actions bot added the engine flutter/engine related. See also e: labels. label Dec 16, 2025

dcharkes reviewed Dec 17, 2025

View reviewed changes

simolus3 force-pushed the only-copy-referenced-native-assets branch from c3dca22 to 42ce061 Compare December 17, 2025 11:42

simolus3 requested a review from dcharkes December 17, 2025 13:42

dcharkes approved these changes Dec 17, 2025

View reviewed changes

simolus3 mentioned this pull request Dec 17, 2025

[hooks] ☂️ Dart 3.10 Flutter 3.38 CP list dart-lang/native#2828

Closed

3 tasks

hellohuanlin requested a review from jmagman December 18, 2025 22:38

jmagman removed their request for review December 18, 2025 22:38

jmagman requested a review from vashworth December 18, 2025 22:39

vashworth reviewed Dec 19, 2025

View reviewed changes

simolus3 force-pushed the only-copy-referenced-native-assets branch from 42ce061 to cb66fc7 Compare December 19, 2025 18:10

vashworth reviewed Dec 19, 2025

View reviewed changes

simolus3 added 3 commits December 20, 2025 20:14

Don't embed unreferenced assets

a499327

Avoid reading build hash

533c694

Add tests

de29737

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2026

dcharkes added this pull request to the merge queue Jan 6, 2026

Merged via the queue into flutter:master with commit 4c3f603 Jan 6, 2026
181 checks passed

simolus3 deleted the only-copy-referenced-native-assets branch January 6, 2026 11:28

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to d5ee675b2fcb (39 revisions) flutter/packages#10725

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

b8a75db

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to be03f0d3b148 (41 revisions) flutter/packages#10727

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

347e749

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to c58d63366199 (43 revisions) flutter/packages#10728

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

8315843

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to 0b67d3dc1430 (44 revisions) flutter/packages#10729

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

507525b

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to fb2fc34ca195 (45 revisions) flutter/packages#10730

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

fc3436e

engine-flutter-autoroll mentioned this pull request Jan 6, 2026

Roll Flutter from 13b2b912c909 to 59868c551d01 (46 revisions) flutter/packages#10731

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

aa69832

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 20fc4107d61f (67 revisions) flutter/packages#10740

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

4c3f603a4 Don't embed unreferenced assets (flutter/flutter#179251)

2993fe6

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to a73c1002a6fa (68 revisions) flutter/packages#10741

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

5283d69

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to b2d157623eeb (69 revisions) flutter/packages#10742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

233b018

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 6acc84ee2ce9 (71 revisions) flutter/packages#10743

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

c74f5c5

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 01d37bc80fd5 (74 revisions) flutter/packages#10745

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

4c3f603 Don't embed unreferenced assets (flutter/flutter#179251)

3f8db3c

	/// To determine if the action for a target needs to be executed, the
	/// [BuildSystem] computes a key of the file contents for both inputs and
	/// outputs. This is tracked separately in the [FileStore]. The key may
	/// be either an md5 hash of the file contents or a timestamp.
	///
	/// A Target has both implicit and explicit inputs and outputs. Only the
	/// latter are safe to evaluate before invoking the [build] action. For example,
	/// a wildcard output pattern requires the outputs to exist before it can
	/// glob files correctly.
	///
	/// - All listed inputs are considered explicit inputs.
	/// - Outputs which are provided as [Source.pattern].
	/// without wildcards are considered explicit.
	/// - The remaining outputs are considered implicit.
	///
	/// For each target, executing its action creates a corresponding stamp file
	/// which records both the input and output files. This file is read by
	/// subsequent builds to determine which file hashes need to be checked. If the
	/// stamp file is missing, the target's action is always rerun.

	List<Source> get inputs => const <Source>[
	Source.pattern('{FLUTTER_ROOT}/packages/flutter_tools/lib/src/build_system/targets/ios.dart'),
	Source.pattern('{BUILD_DIR}/app.dill'),
	Source.artifact(Artifact.engineDartBinary),
	Source.artifact(Artifact.skyEnginePath),

Don't embed unreferenced assets #179251

Don't embed unreferenced assets #179251

Conversation

simolus3 commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Nov 30, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Nov 30, 2025

Choose a reason for hiding this comment

Uh oh!

dcharkes Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

simolus3 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

dcharkes Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

dcharkes commented Dec 2, 2025

Uh oh!

dcharkes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dcharkes Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

simolus3 commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dcharkes left a comment

Choose a reason for hiding this comment

Uh oh!

dcharkes Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

dcharkes commented Dec 17, 2025

Uh oh!

jmagman commented Dec 18, 2025

Uh oh!

Uh oh!

vashworth Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

simolus3 Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

simolus3 commented Nov 30, 2025 •

edited

Loading

vashworth Dec 19, 2025 •

edited

Loading

simolus3 commented Dec 16, 2025 •

edited

Loading

vashworth Dec 19, 2025 •

edited

Loading