Fix division by zero in RenderTable intrinsic size methods #178217

777genius · 2025-11-09T17:07:45Z

Description

This PR fixes a division by zero crash in RenderTable when intrinsic size methods are called on empty tables (0 rows × 0 columns) with non-zero constraints.

The Problem

When RenderTable has 0 columns and intrinsic size methods (computeMinIntrinsicHeight, computeMaxIntrinsicHeight, computeMinIntrinsicWidth, computeMaxIntrinsicWidth) are called with non-zero width constraints, the code calls _computeColumnWidths() without checking if the table is empty. This leads to division by zero at line 1140:

final double delta = (minWidthConstraint - tableWidth) / columns;
// When columns = 0, this crashes with division by zero

The Solution

Added early return checks if (rows * columns == 0) return 0.0; to all four intrinsic size methods, matching the pattern already used by other methods that call _computeColumnWidths():

computeDryBaseline (line 1242) - already has the check
computeDryLayout (line 1274) - already has the check
performLayout (line 1318) - already has the check
paint (line 1461) - already has the check

Now all four intrinsic methods are consistent with the rest of the codebase.

Testing

Added comprehensive test coverage (Empty table intrinsic dimensions should not crash) that:

Creates an empty table (0×0)
Calls all four intrinsic size methods with various constraints
Verifies they return 0.0 without crashing

Changes Made

packages/flutter/lib/src/rendering/table.dart:

Added empty table check to computeMinIntrinsicWidth (line 963-965)
Added empty table check to computeMaxIntrinsicWidth (line 978-980)
Added empty table check to computeMinIntrinsicHeight (line 995-997)
Added empty table check to computeMaxIntrinsicHeight (line 1016-1019)

packages/flutter/test/rendering/table_test.dart:

Added test case Empty table intrinsic dimensions should not crash
Tests all four intrinsic methods with both finite and infinite constraints

Related Issues

This fix addresses a potential crash when using RenderTable with intrinsic sizing widgets (like IntrinsicHeight, IntrinsicWidth) on empty tables.

Checklist

Before you create this PR, confirm all the requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth review process.

I have read the Contributor Guide and followed the process outlined there for submitting PRs.
I have read the Tree Hygiene wiki page, which explains my responsibilities.
I have read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I have signed the CLA.
I have listed at least one issue that this PR fixes (defensive programming for edge case).
I have updated/added relevant documentation (doc comments with ///).
I have added new tests that verify the fix works.
All existing and new tests are passing (flutter analyze shows no issues).
I have followed the breaking change policy and added Data Driven Fixes where applicable (no breaking changes in this PR).

gemini-code-assist

Code Review

This pull request effectively resolves a division-by-zero crash in RenderTable's intrinsic sizing methods for empty tables. The addition of early return checks is a solid approach and aligns with existing patterns in the codebase. The accompanying tests are comprehensive and validate the fix. I have one suggestion to remove a minor code redundancy to improve maintainability.

packages/flutter/lib/src/rendering/table.dart

flutter-dashboard · 2025-12-01T23:11:36Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

hannah-hyj

LGTM, thanks for the fix and the detailed description!!

justinmc

LGTM 👍 . Thanks for fixing this!

justinmc · 2025-12-03T22:57:03Z

Could you fix the analyzer failure so we can merge this @777genius ?

packages/flutter/test/rendering/table_test.dart

When RenderTable has 0 columns and intrinsic size methods are called with non-zero width constraints, the _computeColumnWidths() method attempts to divide by zero at line 1140: final double delta = (minWidthConstraint - tableWidth) / columns; This adds early return checks for empty tables (rows * columns == 0) to four intrinsic size methods: - computeMinIntrinsicWidth - computeMaxIntrinsicWidth - computeMinIntrinsicHeight - computeMaxIntrinsicHeight This matches the pattern already used by other methods that call _computeColumnWidths(), such as computeDryLayout (line 1274), performLayout (line 1318), and paint (line 1461). All four methods now return 0.0 for empty tables, which is consistent with the behavior of other dimension methods. Added comprehensive test coverage to verify that empty tables handle intrinsic size queries without crashing.

The check in computeMaxIntrinsicHeight was redundant since the method delegates to getMinIntrinsicHeight(), which eventually calls computeMinIntrinsicHeight() where the same check already exists. This simplifies the code while maintaining the same functionality. The checks in computeMinIntrinsicWidth, computeMaxIntrinsicWidth, and computeMinIntrinsicHeight remain as they either prevent division by zero or serve as performance optimizations for direct computations.

packages/flutter/lib/src/rendering/table.dart

Piinks · 2026-01-07T00:22:26Z

Analysis and merge conflicts should be set now.

auto-submit · 2026-01-07T00:59:14Z

autosubmit label was removed for flutter/flutter/178217, because - The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-01-07T02:45:26Z

autosubmit label was removed for flutter/flutter/178217, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Piinks · 2026-01-07T15:05:37Z

Confirmed Google testing failure is unrelated to this change.

…lutter/flutter#178217)

Roll Flutter from 13b2b91 to 01d37bc (74 revisions) flutter/flutter@13b2b91...01d37bc 2026-01-07 stuartmorgan@google.com Replace Hybrid Composition wiki page with dev-facing content (flutter/flutter#180642) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Improve code quality in `FlutterActivityTest.java` (flutter/flutter#180585) 2026-01-07 iinozemtsev@google.com Roll Dart SDK to 3.11.0-296.1.beta (flutter/flutter#180633) 2026-01-07 vegorov@google.com Bump target Windows version to 10 (flutter/flutter#180624) 2026-01-07 goderbauer@google.com Run hook_user_defines and link_hook integration tests on CI (flutter/flutter#180622) 2026-01-07 iliyazelenkog@gmail.com Fix division by zero in RenderTable intrinsic size methods (flutter/flutter#178217) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Remove more `requires 24` anotations (flutter/flutter#180116) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 3971dbb85d45 to c5359a4d720e (1 revision) (flutter/flutter#180631) 2026-01-07 huy@nevercode.io Fix TabBar.image does not render at initialIndex for the first time (flutter/flutter#179616) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 1e7ad625f6f7 to 3971dbb85d45 (3 revisions) (flutter/flutter#180627) 2026-01-07 goderbauer@google.com Unpin DDS (flutter/flutter#180571) 2026-01-07 bruno.leroux@gmail.com Fix DropdownMenuEntry.style not resolved when entry is highlighted (flutter/flutter#178873) 2026-01-07 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `@RequiresApi24` annotations from FlutterFragment methods (flutter/flutter#180117) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from 7fc63228056b to 1e7ad625f6f7 (1 revision) (flutter/flutter#180616) 2026-01-07 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QfR2ZFZ5kGTD3raO3... to dTvN_JVSCfGFRasvH... (flutter/flutter#180612) 2026-01-07 bkonyi@google.com [ Widget Preview ] Add support for `dart:ffi` imports (flutter/flutter#180586) 2026-01-07 engine-flutter-autoroll@skia.org Roll Skia from eec90000a899 to 7fc63228056b (2 revisions) (flutter/flutter#180608) 2026-01-07 ulisses.hen@hotmail.com Add --web-define flag for template variable injection in Flutter web builds (flutter/flutter#175805) 2026-01-07 codefu@google.com docs(engine): update rbe notes (flutter/flutter#180599) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from b6249496c230 to eec90000a899 (3 revisions) (flutter/flutter#180602) 2026-01-06 146823759+brahim-guaali@users.noreply.github.com Forward proxy 404 responses to client (flutter/flutter#179858) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 40a8c6188f7f to d2e3ce177270 (1 revision) (flutter/flutter#180598) 2026-01-06 104009581+Saqib198@users.noreply.github.com Restore CLI precedence for web headers and HTTPS over web_dev_config.yaml (flutter/flutter#179639) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from f5d9da13d56d to b6249496c230 (1 revision) (flutter/flutter#180596) 2026-01-06 dkwingsmt@users.noreply.github.com Enable misc leak tracking (flutter/flutter#176992) 2026-01-06 dacoharkes@google.com [hooks] Don't require NDK for Android targets (flutter/flutter#180594) 2026-01-06 kjlubick@users.noreply.github.com [skia] Disable legacy non-const SkData APIs (flutter/flutter#179684) 2026-01-06 48625061+muradhossin@users.noreply.github.com Fix/ios share context menu (flutter/flutter#176199) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from b970aeffa66f to f5d9da13d56d (5 revisions) (flutter/flutter#180588) 2026-01-06 goderbauer@google.com Manually bump dependencies (flutter/flutter#180509) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 8150be8a0e48 to 40a8c6188f7f (2 revisions) (flutter/flutter#180582) 2026-01-06 engine-flutter-autoroll@skia.org Roll Packages from 12eb764 to d3f860d (2 revisions) (flutter/flutter#180581) 2026-01-06 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from MHF-UAfO6sVKqSEYk... to nR2ESa1Gd8yPcWo06... (flutter/flutter#180578) 2026-01-06 sokolovskyi.konstantin@gmail.com Add tooltip support to PlatformMenuItem and PlatformMenu. (flutter/flutter#180069) 2026-01-06 bruno.leroux@gmail.com Add DropdownMenuFormField.errorBuilder (flutter/flutter#179345) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 1845397e11ba to b970aeffa66f (2 revisions) (flutter/flutter#180566) 2026-01-06 oss@simonbinder.eu Don't embed unreferenced assets (flutter/flutter#179251) 2026-01-06 116356835+AbdeMohlbi@users.noreply.github.com Improve documentation about ValueNotifier's behavior (flutter/flutter#179870) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 904ba00331ca to 1845397e11ba (5 revisions) (flutter/flutter#180558) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 2fb9ad834c4d to 8150be8a0e48 (1 revision) (flutter/flutter#180557) 2026-01-06 engine-flutter-autoroll@skia.org Roll Skia from 98c042dde68c to 904ba00331ca (3 revisions) (flutter/flutter#180550) 2026-01-06 engine-flutter-autoroll@skia.org Roll Dart SDK from ba9f7f790966 to 2fb9ad834c4d (2 revisions) (flutter/flutter#180548) 2026-01-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ubBGcRaAKWKihQ4ac... to QfR2ZFZ5kGTD3raO3... (flutter/flutter#180547) 2026-01-06 ahmedsameha1@gmail.com Make sure that a DraggableScrollableSheet doesn't crash in 0x0 enviro… (flutter/flutter#180433) 2026-01-06 ahmedsameha1@gmail.com Make sure that a ColorFiltered doesn't crash 0x0 environment (flutter/flutter#180307) 2026-01-06 ahmedsameha1@gmail.com Make sure that a FadeInImage doesn't crash in 0x0 environment (flutter/flutter#180495) ...

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 9, 2025

gemini-code-assist bot reviewed Nov 9, 2025

View reviewed changes

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

Piinks requested a review from hannah-hyj November 11, 2025 23:09

hannah-hyj approved these changes Dec 1, 2025

View reviewed changes

justinmc approved these changes Dec 3, 2025

View reviewed changes

Piinks reviewed Jan 6, 2026

View reviewed changes

packages/flutter/test/rendering/table_test.dart Outdated Show resolved Hide resolved

777genius and others added 3 commits January 6, 2026 18:16

Apply suggestion from @Piinks

d2103e9

Piinks force-pushed the fix/table-division-by-zero branch from 891bc27 to d2103e9 Compare January 7, 2026 00:20

Piinks reviewed Jan 7, 2026

View reviewed changes

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

Piinks reviewed Jan 7, 2026

View reviewed changes

packages/flutter/lib/src/rendering/table.dart Outdated Show resolved Hide resolved

Apply suggestions from code review

70c91fe

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

auto-submit bot added this pull request to the merge queue Jan 7, 2026

Merged via the queue into flutter:master with commit b2d1576 Jan 7, 2026
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2026

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to b2d157623eeb (69 revisions) flutter/packages#10742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

b2d1576 Fix division by zero in RenderTable intrinsic size methods (f…

9b2aaed

…lutter/flutter#178217)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 6acc84ee2ce9 (71 revisions) flutter/packages#10743

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

b2d1576 Fix division by zero in RenderTable intrinsic size methods (f…

c1f8cb6

…lutter/flutter#178217)

engine-flutter-autoroll mentioned this pull request Jan 7, 2026

Roll Flutter from 13b2b912c909 to 01d37bc80fd5 (74 revisions) flutter/packages#10745

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2026

b2d1576 Fix division by zero in RenderTable intrinsic size methods (f…

bb3dae1

…lutter/flutter#178217)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix division by zero in RenderTable intrinsic size methods #178217

Fix division by zero in RenderTable intrinsic size methods #178217

777genius commented Nov 9, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

flutter-dashboard bot commented Dec 1, 2025

Uh oh!

hannah-hyj left a comment

Uh oh!

justinmc left a comment

Uh oh!

justinmc commented Dec 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented Jan 7, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

Piinks commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix division by zero in RenderTable intrinsic size methods #178217

Fix division by zero in RenderTable intrinsic size methods #178217

Conversation

777genius commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

The Problem

The Solution

Testing

Changes Made

Related Issues

Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

flutter-dashboard bot commented Dec 1, 2025

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented Jan 7, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

auto-submit bot commented Jan 7, 2026

Uh oh!

Piinks commented Jan 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

777genius commented Nov 9, 2025 •

edited

Loading

justinmc commented Dec 3, 2025 •

edited

Loading