Skip to content

Conversation

@jason-simmons
Copy link
Member

This reverts commit fe598e7.

This benchmark can be moved back to the Linux devicelab machines now that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes #161620

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 17, 2025

auto label is removed for flutter/flutter/161822, due to - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ter#161405)"

This reverts commit fe598e7.

This benchmark can be moved back to the Linux devicelab machines now that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes flutter#161620
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 23, 2025
Merged via the queue into flutter:master with commit 1083356 Jan 23, 2025
171 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
Manual roll requested by tarrinneal@google.com

flutter/flutter@b2f515f...c1561a4

2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
…tter#161822)

This reverts commit fe598e7.

This benchmark can be moved back to the Linux devicelab machines now
that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes flutter#161620
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b2f515f...c1561a4

2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@b2f515f...c1561a4

2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Once Dart SDK (commits: 403924) lands in Flutter, revert #161405

2 participants