[Impeller] Implement inherited opacity for ColorFilterContents #161834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Jan 17, 2025
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, thanks @jason-simmons!
Inherited opacity should be combined with the alpha of the ColorFilterContents when drawing objects with filters inside an opacity layer.
fba2173 to
21c3e86
Compare
Contributor
|
auto label is removed for flutter/flutter/161834, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 23, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 23, 2025
Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Wasmund1
pushed a commit
to Wasmund1/flutter
that referenced
this pull request
Jan 24, 2025
…er#161834) Inherited opacity should be combined with the alpha of the ColorFilterContents when drawing objects with filters inside an opacity layer.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
) Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
) Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherited opacity should be combined with the alpha of the ColorFilterContents when drawing objects with filters inside an opacity layer.