Shift `mac_clang_tidy` to a Linux orchestrator. #162042

matanlurey · 2025-01-22T23:05:31Z

This adds a bringup: true node that duplicates what Mac mac_clang_tidy is doing, to be turned down/up in a follow-up.

jtmcdole · 2025-01-22T23:47:48Z

engine/src/flutter/.ci.yaml

+      - engine/src/flutter/tools/clang_tidy/**
+      - engine/src/flutter/ci/builders/**
+      - engine/src/flutter/ci/clang_tidy.sh
+      - "engine/src/flutter/**.h"


These are just regex right? Can it not be:

- "engine/src/flutter/**.(h|c|cc|fbs|frag|vert|m|mm)"

I don't think it's regex, I think it's glob-format

In cocoon, its regex. They change "**" to a pattern.

jmagman · 2025-01-23T00:00:36Z

engine/src/flutter/.ci.yaml

      # at https://github.com/flutter/flutter/issues/152186.
      cores: "8"

+  - name: Linux mac_clang_tidy


I think you may need to update https://github.com/flutter/flutter/blob/master/engine/src/flutter/ci/builders/mac_clang_tidy.json to include the Xcode version it won't inherit from the orchestrator anymore

flutter/.ci.yaml

Lines 134 to 137 in b2f515f

$flutter/osx_sdk : >-

{

"sdk_version": "15a240d"

}

Like this:

https://github.com/flutter/engine/pull/41226/files#diff-0ffa4e3b6061439de548723c6f45891936522dd624f1ea1c5567a070b39839aeR33-R37

Thanks! Done, I ... think.

And you might need to push the 8 core thing down but I'm not sure. Easiest is to land it and check the sub builds are getting that config.

Sounds good, will check the node once it's merged.

auto-submit · 2025-01-23T04:07:12Z

auto label is removed for flutter/flutter/162042, due to - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-23T05:04:05Z

auto label is removed for flutter/flutter/162042, due to - The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ter#162042)

Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Towards flutter#160701. This adds a `bringup: true` node that duplicates what `Mac mac_clang_tidy` is doing, to be turned down/up in a follow-up.

…ter#162042)

) Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Shift mac_clang_tidy to a Linux orchestrator.

46514a0

matanlurey requested review from jmagman and jtmcdole January 22, 2025 23:05

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 22, 2025

jtmcdole reviewed Jan 22, 2025

View reviewed changes

jtmcdole approved these changes Jan 22, 2025

View reviewed changes

jmagman reviewed Jan 23, 2025

View reviewed changes

Update clang_tidy.json.

02c38e1

matanlurey requested a review from jmagman January 23, 2025 00:24

jmagman approved these changes Jan 23, 2025

View reviewed changes

matanlurey added 2 commits January 22, 2025 19:15

Merge remote-tracking branch 'upstream/main' into Linux-mac_clang_tidy

67c6061

++

99792fd

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

matanlurey added this pull request to the merge queue Jan 23, 2025

Merged via the queue into flutter:master with commit 211b46f Jan 23, 2025
177 of 178 checks passed

matanlurey deleted the Linux-mac_clang_tidy branch January 23, 2025 17:17

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 211b46fcb102 (17 revisions) flutter/packages#8490

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

e0cdae7

…ter#162042)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Manual roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8491

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

b68f2fc

…ter#162042)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

0ce162a

…ter#162042)

jmagman mentioned this pull request Jan 24, 2025

Mac mac_clang_tidy uses a macOS orchestrator unnecessarily #160701

Closed

matanlurey mentioned this pull request Apr 16, 2025

Cocoon regression: targets missing from ToT are not filtered out #167288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

4ce95d6

…ter#162042)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

f7f11ad

…ter#162042)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

211b46f Shift mac_clang_tidy to a Linux orchestrator. (flutter/flut…

dfca5e6

…ter#162042)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Shift `mac_clang_tidy` to a Linux orchestrator. #162042

Shift `mac_clang_tidy` to a Linux orchestrator. #162042

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

jtmcdole Jan 22, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

jtmcdole Jan 23, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

jmagman Jan 23, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

jmagman Jan 23, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

auto-submit bot commented Jan 23, 2025

Uh oh!

auto-submit bot commented Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shift mac_clang_tidy to a Linux orchestrator. #162042

Shift mac_clang_tidy to a Linux orchestrator. #162042

Uh oh!

Conversation

matanlurey commented Jan 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 23, 2025

Uh oh!

auto-submit bot commented Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shift `mac_clang_tidy` to a Linux orchestrator. #162042

Shift `mac_clang_tidy` to a Linux orchestrator. #162042