Add a better error message when `flutter drive --target` is used incorrectly. #162023

matanlurey · 2025-01-22T19:10:52Z

jonahwilliams

LGTM

andrewkolos · 2025-01-22T22:56:17Z

packages/flutter_tools/lib/src/commands/drive.dart

+          'The file path passed to --target should be an app entrypoint that '
+          'contains a "main()". Did you mean "flutter drive --driver $targetFile"?',


Looking at the docs (https://docs.flutter.dev/testing/integration-tests), it looks like it's normal to have the driver file end with _test.dart. Am I missing something here?

e.g.

flutter drive \ --driver=test_driver/integration_test.dart \ --target=integration_test/app_test.dart \ -d chrome

I guess we could do introspection that this message shows up if the file is in test_driver, which is what we are trying to catch.

…r-driver-bad-target

…sed incorrectly. (flutter/flutter#162023)

Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rrectly. (flutter#162023) Closes flutter#62626.

…sed incorrectly. (flutter/flutter#162023)

) Manual roll requested by tarrinneal@google.com flutter/flutter@b2f515f...c1561a4 2025-01-23 matanlurey@users.noreply.github.com Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 matanlurey@users.noreply.github.com Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 jonahwilliams@google.com [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 robert.ancell@canonical.com Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 koji.wakamiya@gmail.com fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 robert.ancell@canonical.com Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 bruno.leroux@gmail.com Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 matanlurey@users.noreply.github.com Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 jason-simmons@users.noreply.github.com Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 jonahwilliams@google.com [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 34871572+gmackall@users.noreply.github.com Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Add a better error message when --target is used incorrectly.

2aabbdf

matanlurey requested review from andrewkolos and gaaclarke January 22, 2025 19:10

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 22, 2025

matanlurey requested a review from jonahwilliams January 22, 2025 22:41

jonahwilliams approved these changes Jan 22, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

andrewkolos reviewed Jan 22, 2025

View reviewed changes

matanlurey removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

Use test_driver/ instead of _test.dart.

3b6c1c1

matanlurey requested a review from andrewkolos January 23, 2025 00:30

matanlurey force-pushed the better-error-flutter-driver-bad-target branch from 5ea330e to 3b6c1c1 Compare January 23, 2025 00:32

matanlurey and others added 2 commits January 22, 2025 16:32

Merge remote-tracking branch 'upstream/main' into better-error-flutte…

d75a363

…r-driver-bad-target

Merge branch 'master' into better-error-flutter-driver-bad-target

87a5a01

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit bot added this pull request to the merge queue Jan 23, 2025

Merged via the queue into flutter:master with commit 9c960ff Jan 23, 2025
159 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 663d02078813 (8 revisions) flutter/packages#8484

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

acd701e

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 6e9b863e6d29 (9 revisions) flutter/packages#8486

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

0362528

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to d59995bac316 (12 revisions) flutter/packages#8488

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

7c4f737

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to b46479c6a00d (16 revisions) flutter/packages#8489

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

f8b1ad9

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 211b46fcb102 (17 revisions) flutter/packages#8490

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

7f8a152

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Manual roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8491

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

283c22a

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

9c960ff Add a better error message when flutter drive --target is u…

2cc02ab

…sed incorrectly. (flutter/flutter#162023)

Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025

Add a better error message when flutter drive --target is used inco…

239999b

…rrectly. (flutter#162023) Closes flutter#62626.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

9c960ff Add a better error message when flutter drive --target is u…

adc63d6

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

9c960ff Add a better error message when flutter drive --target is u…

5ae5d8c

…sed incorrectly. (flutter/flutter#162023)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

9c960ff Add a better error message when flutter drive --target is u…

47f477b

…sed incorrectly. (flutter/flutter#162023)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a better error message when `flutter drive --target` is used incorrectly. #162023

Add a better error message when `flutter drive --target` is used incorrectly. #162023

Uh oh!

matanlurey commented Jan 22, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

andrewkolos Jan 22, 2025

Uh oh!

andrewkolos Jan 22, 2025

Uh oh!

matanlurey Jan 22, 2025

Uh oh!

matanlurey Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		'The file path passed to --target should be an app entrypoint that '
		'contains a "main()". Did you mean "flutter drive --driver $targetFile"?',

Add a better error message when flutter drive --target is used incorrectly. #162023

Add a better error message when flutter drive --target is used incorrectly. #162023

Uh oh!

Conversation

matanlurey commented Jan 22, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

andrewkolos Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

andrewkolos Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add a better error message when `flutter drive --target` is used incorrectly. #162023

Add a better error message when `flutter drive --target` is used incorrectly. #162023