Skip to content

Move the analyzer_benchmark to Mac arm64 devicelab bots #161405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jan 14, 2025
Merged

Move the analyzer_benchmark to Mac arm64 devicelab bots #161405

auto-submit merged 2 commits into from
Jan 14, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jan 9, 2025

The arm64 Macs should have more memory than the Linux machines that are available in the devicelab. The analyzer benchmark spawns a Dart analysis server process that has a peak memory consumption of around 7GB, which may be activating the OOM killer on the Linux bots.

See #161306

zanderso
zanderso reviewed Jan 9, 2025
View reviewed changes
.ci.yaml Outdated
# are intentionally running it in the devicelab to ensure that it does not
# run on a VM in order to avoid noisy results from the benchmark.
- name: Linux analyzer_benchmark
- name: Mac analyzer_benchmark
Copy link
Member

@zanderso zanderso Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'm remembering correctly, but I think that the tags section doesn't actually affect which machine pool is selected. I think the way this is written the task will go on any available intel or arm64 mac. To always select an arm64 mac, this should be Mac_arm64 instead of Mac.

Copy link
Member Author

@jason-simmons jason-simmons Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jtmcdole
Copy link
Member

jtmcdole commented Jan 10, 2025 •
edited
Loading

Did this not require bring_up true? I'm surprised cocoon didn't complain about the new test name.

Nevermind; Matan marked it as bring up earlier

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 10, 2025
@jason-simmons
Move the analyzer_benchmark to Mac arm64 devicelab bots
5f7c80e 
The arm64 Macs should have more memory than the Linux machines that are available in the devicelab.  The analyzer benchmark spawns a Dart analysis server process that has a peak memory consumption of around 7GB, which may be activating the OOM killer on the Linux bots.

See flutter#161306
@jason-simmons
change name to Mac_arm64
c2e8696
@auto-submit auto-submit bot added this pull request to the merge queue Jan 13, 2025
Merged via the queue into flutter:master with commit fe598e7 Jan 14, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
55f1d7a 
…ter/flutter#161405)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
c537eaf 
…ter/flutter#161405)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
ae6852c 
…ter/flutter#161405)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
0b4e47e 
…ter/flutter#161405)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 14, 2025
@engine-flutter-autoroll
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (#8428)
f73cb00 
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions)

flutter/flutter@72db8f6...40c2b86

2025-01-14 christopherfujino@gmail.com update changelog for 3.27.2 release (flutter/flutter#161569)
2025-01-14 tessertaha@gmail.com Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599)
2025-01-14 30870216+gaaclarke@users.noreply.github.com Added special case for fat width arcs (flutter/flutter#161255)
2025-01-14 matanlurey@users.noreply.github.com Replace `fetch `with `gclient sync`. (flutter/flutter#161565)
2025-01-14 engine-flutter-autoroll@skia.org Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597)
2025-01-14 robert.ancell@canonical.com Remove unused method (flutter/flutter#161572)
2025-01-14 hbatagelo@gmail.com Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375)
2025-01-14 bruno.leroux@gmail.com Update InputDecoration.border documentation (flutter/flutter#161415)
2025-01-14 dkwingsmt@users.noreply.github.com [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917)
2025-01-14 a-siva@users.noreply.github.com Roll Dart to  Version 3.7.0-323.0.dev (flutter/flutter#161567)
2025-01-14 goderbauer@google.com Use wildcards (flutter/flutter#161548)
2025-01-14 jmccandless@google.com Autocomplete Options Width (flutter/flutter#143249)
2025-01-13 jason-simmons@users.noreply.github.com Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405)
2025-01-13 matanlurey@users.noreply.github.com Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529)
2025-01-13 flar@google.com Fix paths when running clang-tidy on git diffs (flutter/flutter#161496)
2025-01-13 yjbanov@google.com [web:a11y] treat empty tappables as buttons (flutter/flutter#161360)
2025-01-13 58190796+MitchellGoodwin@users.noreply.github.com Add route settings to CupertinoSheetRoute (flutter/flutter#161528)
2025-01-13 matanlurey@users.noreply.github.com Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532)
2025-01-13 matanlurey@users.noreply.github.com Remove last two references to Cirrus CI. (flutter/flutter#161530)
2025-01-13 codefu@google.com Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550)
2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555)
2025-01-13 bkonyi@google.com Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124)
2025-01-13 matanlurey@users.noreply.github.com Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450)
2025-01-13 dhankechakishan@gmail.com Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223)
2025-01-13 matanlurey@users.noreply.github.com Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527)
2025-01-13 chinmaygarde@google.com [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251)
2025-01-13 flar@google.com Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453)
2025-01-13 jmccandless@google.com Context menu button callback docs clarification (flutter/flutter#161451)
2025-01-13 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241)
2025-01-13 codefu@google.com Udpate documentation on the third_party directories (flutter/flutter#161407)
2025-01-13 matanlurey@users.noreply.github.com Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452)
2025-01-13 34871572+gmackall@users.noreply.github.com Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963)
2025-01-13 jonahwilliams@google.com [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
@matanlurey matanlurey mentioned this pull request Jan 14, 2025
Closed
maheshj01 pushed a commit to maheshj01/flutter that referenced this pull request Jan 15, 2025
@jason-simmons @maheshj01
Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter#161405)
c2f34f1 
The arm64 Macs should have more memory than the Linux machines that are
available in the devicelab. The analyzer benchmark spawns a Dart
analysis server process that has a peak memory consumption of around
7GB, which may be activating the OOM killer on the Linux bots.

See flutter#161306
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Jan 17, 2025
@jason-simmons
Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
b097c22 
…ter#161405)"

This reverts commit fe598e7.

This benchmark can be moved back to the Linux devicelab machines now that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes flutter#161620
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Jan 22, 2025
@jason-simmons
Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
6404c10 
…ter#161405)"

This reverts commit fe598e7.

This benchmark can be moved back to the Linux devicelab machines now that https://dart-review.googlesource.com/c/sdk/+/403924 has landed.

Fixes flutter#161620
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
68fc4ca 
…ter/flutter#161405)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
858ee28 
…ter/flutter#161405)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
0c84c15 
…ter/flutter#161405)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
7005e90 
…ter/flutter#161405)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
fe598e7 Move the analyzer_benchmark to Mac arm64 devicelab bots (flut…
8fd58d2 
…ter/flutter#161405)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (flutter#8428)
476c808 
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions)

flutter/flutter@72db8f6...40c2b86

2025-01-14 christopherfujino@gmail.com update changelog for 3.27.2 release (flutter/flutter#161569)
2025-01-14 tessertaha@gmail.com Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599)
2025-01-14 30870216+gaaclarke@users.noreply.github.com Added special case for fat width arcs (flutter/flutter#161255)
2025-01-14 matanlurey@users.noreply.github.com Replace `fetch `with `gclient sync`. (flutter/flutter#161565)
2025-01-14 engine-flutter-autoroll@skia.org Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597)
2025-01-14 robert.ancell@canonical.com Remove unused method (flutter/flutter#161572)
2025-01-14 hbatagelo@gmail.com Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375)
2025-01-14 bruno.leroux@gmail.com Update InputDecoration.border documentation (flutter/flutter#161415)
2025-01-14 dkwingsmt@users.noreply.github.com [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917)
2025-01-14 a-siva@users.noreply.github.com Roll Dart to  Version 3.7.0-323.0.dev (flutter/flutter#161567)
2025-01-14 goderbauer@google.com Use wildcards (flutter/flutter#161548)
2025-01-14 jmccandless@google.com Autocomplete Options Width (flutter/flutter#143249)
2025-01-13 jason-simmons@users.noreply.github.com Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405)
2025-01-13 matanlurey@users.noreply.github.com Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529)
2025-01-13 flar@google.com Fix paths when running clang-tidy on git diffs (flutter/flutter#161496)
2025-01-13 yjbanov@google.com [web:a11y] treat empty tappables as buttons (flutter/flutter#161360)
2025-01-13 58190796+MitchellGoodwin@users.noreply.github.com Add route settings to CupertinoSheetRoute (flutter/flutter#161528)
2025-01-13 matanlurey@users.noreply.github.com Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532)
2025-01-13 matanlurey@users.noreply.github.com Remove last two references to Cirrus CI. (flutter/flutter#161530)
2025-01-13 codefu@google.com Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550)
2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555)
2025-01-13 bkonyi@google.com Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124)
2025-01-13 matanlurey@users.noreply.github.com Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450)
2025-01-13 dhankechakishan@gmail.com Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223)
2025-01-13 matanlurey@users.noreply.github.com Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527)
2025-01-13 chinmaygarde@google.com [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251)
2025-01-13 flar@google.com Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453)
2025-01-13 jmccandless@google.com Context menu button callback docs clarification (flutter/flutter#161451)
2025-01-13 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241)
2025-01-13 codefu@google.com Udpate documentation on the third_party directories (flutter/flutter#161407)
2025-01-13 matanlurey@users.noreply.github.com Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452)
2025-01-13 34871572+gmackall@users.noreply.github.com Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963)
2025-01-13 jonahwilliams@google.com [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) (flutter#8428)
659171e 
Roll Flutter from 72db8f6 to 40c2b86 (33 revisions)

flutter/flutter@72db8f6...40c2b86

2025-01-14 christopherfujino@gmail.com update changelog for 3.27.2 release (flutter/flutter#161569)
2025-01-14 tessertaha@gmail.com Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599)
2025-01-14 30870216+gaaclarke@users.noreply.github.com Added special case for fat width arcs (flutter/flutter#161255)
2025-01-14 matanlurey@users.noreply.github.com Replace `fetch `with `gclient sync`. (flutter/flutter#161565)
2025-01-14 engine-flutter-autoroll@skia.org Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597)
2025-01-14 robert.ancell@canonical.com Remove unused method (flutter/flutter#161572)
2025-01-14 hbatagelo@gmail.com Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375)
2025-01-14 bruno.leroux@gmail.com Update InputDecoration.border documentation (flutter/flutter#161415)
2025-01-14 dkwingsmt@users.noreply.github.com [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917)
2025-01-14 a-siva@users.noreply.github.com Roll Dart to  Version 3.7.0-323.0.dev (flutter/flutter#161567)
2025-01-14 goderbauer@google.com Use wildcards (flutter/flutter#161548)
2025-01-14 jmccandless@google.com Autocomplete Options Width (flutter/flutter#143249)
2025-01-13 jason-simmons@users.noreply.github.com Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405)
2025-01-13 matanlurey@users.noreply.github.com Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529)
2025-01-13 flar@google.com Fix paths when running clang-tidy on git diffs (flutter/flutter#161496)
2025-01-13 yjbanov@google.com [web:a11y] treat empty tappables as buttons (flutter/flutter#161360)
2025-01-13 58190796+MitchellGoodwin@users.noreply.github.com Add route settings to CupertinoSheetRoute (flutter/flutter#161528)
2025-01-13 matanlurey@users.noreply.github.com Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532)
2025-01-13 matanlurey@users.noreply.github.com Remove last two references to Cirrus CI. (flutter/flutter#161530)
2025-01-13 codefu@google.com Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550)
2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555)
2025-01-13 bkonyi@google.com Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124)
2025-01-13 matanlurey@users.noreply.github.com Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450)
2025-01-13 dhankechakishan@gmail.com Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223)
2025-01-13 matanlurey@users.noreply.github.com Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527)
2025-01-13 chinmaygarde@google.com [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251)
2025-01-13 flar@google.com Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453)
2025-01-13 jmccandless@google.com Context menu button callback docs clarification (flutter/flutter#161451)
2025-01-13 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241)
2025-01-13 codefu@google.com Udpate documentation on the third_party directories (flutter/flutter#161407)
2025-01-13 matanlurey@users.noreply.github.com Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452)
2025-01-13 34871572+gmackall@users.noreply.github.com Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963)
2025-01-13 jonahwilliams@google.com [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole jtmcdole approved these changes

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason-simmons @jtmcdole @matanlurey @zanderso