Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. #161532

matanlurey · 2025-01-13T19:07:23Z

The goal is to, assuming this is WAI, move the bringup: true build (the newly created one) to presubmit, and then in a follow-up PR, remove the tests: [...] (and test dependencies) from linux_host_engine.json, meaning that it would be a build/archive only builder, and this new builder would be a build/test one.

We talked about it being hypothetically better to not build the engine multiple times, and decided for now to depend on RBE and not try to create stages or download artifacts created from another builder, but if @zanderso has another suggestion here is the place to chime in :)

(Btw if we like this approach, I'll create a task list of every builder that needs to be migrated)

zanderso

approach sgtm.

zanderso · 2025-01-13T19:18:38Z

engine/src/flutter/ci/builders/linux_host_engine_test.json

+            },
+            "gn": [
+                "--target-dir",
+                "ci/host_debug",


This has to match the ninja "config" field. That is, this should be ci/host_debug_unit_tests. Here and below as well.

Could you also please double check for me that run_tests.py doesn't have logic expecting debug, profile, release to be at the end of the config name?

Done!

re: run_tests.py, the only reference I could see that might be troublesome I changed from looking for a hardcoded not host_profile and not host_release to having the word debug in the build. It's not great, but it's similar tot other checks we already make in run_tests.py.

PTAL.

zanderso · 2025-01-13T19:36:59Z

engine/src/flutter/testing/run_tests.py

-    return len(matches) > 0
-
-  if ('engine' in types or 'font-subset' in types) and not should_skip(args.variant):
+  if ('engine' in types or 'font-subset' in types) and 'debug' in build_dir:


This looks like a half-finished migration from using engine to run these tests to using font-subset to run them. Instead of using the filters on the config name, we should just use the font-subset type. Doesn't have to be in this PR though.

Filed #161538 to complete this.

jtmcdole

christopherfujino

LGTM

christopherfujino · 2025-01-13T21:02:53Z

For posterity, the high level strategy is to:

add new release=false ci.yaml targets that both compile targets and run tests (but do NOT archive). these will be run in parallel with framework tests, AFTER we've compiled and uploaded engine targets. They will rely on RBE to speed up compilation of targets we've already compiled previously.
remove the tests from the original ci.yaml targets that are marked release=true.

…g `archives: [...]`. (flutter/flutter#161532)

Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) flutter/flutter@72db8f6...40c2b86 2025-01-14 christopherfujino@gmail.com update changelog for 3.27.2 release (flutter/flutter#161569) 2025-01-14 tessertaha@gmail.com Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599) 2025-01-14 30870216+gaaclarke@users.noreply.github.com Added special case for fat width arcs (flutter/flutter#161255) 2025-01-14 matanlurey@users.noreply.github.com Replace `fetch `with `gclient sync`. (flutter/flutter#161565) 2025-01-14 engine-flutter-autoroll@skia.org Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597) 2025-01-14 robert.ancell@canonical.com Remove unused method (flutter/flutter#161572) 2025-01-14 hbatagelo@gmail.com Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375) 2025-01-14 bruno.leroux@gmail.com Update InputDecoration.border documentation (flutter/flutter#161415) 2025-01-14 dkwingsmt@users.noreply.github.com [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917) 2025-01-14 a-siva@users.noreply.github.com Roll Dart to Version 3.7.0-323.0.dev (flutter/flutter#161567) 2025-01-14 goderbauer@google.com Use wildcards (flutter/flutter#161548) 2025-01-14 jmccandless@google.com Autocomplete Options Width (flutter/flutter#143249) 2025-01-13 jason-simmons@users.noreply.github.com Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405) 2025-01-13 matanlurey@users.noreply.github.com Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529) 2025-01-13 flar@google.com Fix paths when running clang-tidy on git diffs (flutter/flutter#161496) 2025-01-13 yjbanov@google.com [web:a11y] treat empty tappables as buttons (flutter/flutter#161360) 2025-01-13 58190796+MitchellGoodwin@users.noreply.github.com Add route settings to CupertinoSheetRoute (flutter/flutter#161528) 2025-01-13 matanlurey@users.noreply.github.com Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532) 2025-01-13 matanlurey@users.noreply.github.com Remove last two references to Cirrus CI. (flutter/flutter#161530) 2025-01-13 codefu@google.com Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550) 2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555) 2025-01-13 bkonyi@google.com Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124) 2025-01-13 matanlurey@users.noreply.github.com Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450) 2025-01-13 dhankechakishan@gmail.com Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223) 2025-01-13 matanlurey@users.noreply.github.com Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527) 2025-01-13 chinmaygarde@google.com [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251) 2025-01-13 flar@google.com Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453) 2025-01-13 jmccandless@google.com Context menu button callback docs clarification (flutter/flutter#161451) 2025-01-13 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241) 2025-01-13 codefu@google.com Udpate documentation on the third_party directories (flutter/flutter#161407) 2025-01-13 matanlurey@users.noreply.github.com Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452) 2025-01-13 34871572+gmackall@users.noreply.github.com Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963) 2025-01-13 jonahwilliams@google.com [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

@zanderso

…ves: [...]`. (flutter#161532) Towards flutter#161406. The goal is to, assuming this is WAI, move the `bringup: true` build (the newly created one) to presubmit, and then in a follow-up PR, remove the `tests: [...]` (and test dependencies) from `linux_host_engine.json`, meaning that it would be a build/archive only builder, and this _new_ builder would be a build/test one. We talked about it being hypothetically better to _not_ build the engine multiple times, and decided for now to depend on RBE and not try to create stages or download artifacts created from another builder, but if @zanderso has another suggestion here is the place to chime in :) (Btw if we like this approach, I'll create a task list of every builder that needs to be migrated)

…g `archives: [...]`. (flutter/flutter#161532)

Roll Flutter from 72db8f6 to 40c2b86 (33 revisions) flutter/flutter@72db8f6...40c2b86 2025-01-14 christopherfujino@gmail.com update changelog for 3.27.2 release (flutter/flutter#161569) 2025-01-14 tessertaha@gmail.com Fix `showLicensePage` does not inherit ambient `Theme` (flutter/flutter#161599) 2025-01-14 30870216+gaaclarke@users.noreply.github.com Added special case for fat width arcs (flutter/flutter#161255) 2025-01-14 matanlurey@users.noreply.github.com Replace `fetch `with `gclient sync`. (flutter/flutter#161565) 2025-01-14 engine-flutter-autoroll@skia.org Roll Packages from 3c3bc68 to d1fd623 (4 revisions) (flutter/flutter#161597) 2025-01-14 robert.ancell@canonical.com Remove unused method (flutter/flutter#161572) 2025-01-14 hbatagelo@gmail.com Fix crash when closing a window with `Alt+F4` in multi-win Flutter on Windows (flutter/flutter#161375) 2025-01-14 bruno.leroux@gmail.com Update InputDecoration.border documentation (flutter/flutter#161415) 2025-01-14 dkwingsmt@users.noreply.github.com [Web] Allow specifying the strategy on when to use <img> element to display images (flutter/flutter#159917) 2025-01-14 a-siva@users.noreply.github.com Roll Dart to Version 3.7.0-323.0.dev (flutter/flutter#161567) 2025-01-14 goderbauer@google.com Use wildcards (flutter/flutter#161548) 2025-01-14 jmccandless@google.com Autocomplete Options Width (flutter/flutter#143249) 2025-01-13 jason-simmons@users.noreply.github.com Move the analyzer_benchmark to Mac arm64 devicelab bots (flutter/flutter#161405) 2025-01-13 matanlurey@users.noreply.github.com Remove references to `cirrus`, mostly in doc comments. (flutter/flutter#161529) 2025-01-13 flar@google.com Fix paths when running clang-tidy on git diffs (flutter/flutter#161496) 2025-01-13 yjbanov@google.com [web:a11y] treat empty tappables as buttons (flutter/flutter#161360) 2025-01-13 58190796+MitchellGoodwin@users.noreply.github.com Add route settings to CupertinoSheetRoute (flutter/flutter#161528) 2025-01-13 matanlurey@users.noreply.github.com Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. (flutter/flutter#161532) 2025-01-13 matanlurey@users.noreply.github.com Remove last two references to Cirrus CI. (flutter/flutter#161530) 2025-01-13 codefu@google.com Mark `Mac_mokey microbenchmarks` as flakey (flutter/flutter#161550) 2025-01-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (#160241)" (flutter/flutter#161555) 2025-01-13 bkonyi@google.com Add validator execution times to `flutter doctor --verbose` (flutter/flutter#158124) 2025-01-13 matanlurey@users.noreply.github.com Explain more specifically how to use `flutter drive`/what it does (flutter/flutter#161450) 2025-01-13 dhankechakishan@gmail.com Fixed repeated strings for incompatible Gradle or AGP version in `create` command (flutter/flutter#161223) 2025-01-13 matanlurey@users.noreply.github.com Remove `WEB_SHARD_COUNT`, which no longer exists post-Cirrus. (flutter/flutter#161527) 2025-01-13 chinmaygarde@google.com [Impeller] Update guidance on prebuilt artifacts. (flutter/flutter#161251) 2025-01-13 flar@google.com Migrate DisplayList unit tests to DL/Impeller geometry classes (flutter/flutter#161453) 2025-01-13 jmccandless@google.com Context menu button callback docs clarification (flutter/flutter#161451) 2025-01-13 43089218+chika3742@users.noreply.github.com Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (flutter/flutter#160241) 2025-01-13 codefu@google.com Udpate documentation on the third_party directories (flutter/flutter#161407) 2025-01-13 matanlurey@users.noreply.github.com Propagate environment variables when `flutter drive` is invoked. (flutter/flutter#161452) 2025-01-13 34871572+gmackall@users.noreply.github.com Convert base application name handling to kotlin source (start of FGP kt conversion) (flutter/flutter#155963) 2025-01-13 jonahwilliams@google.com [Impeller] remove API 30 restriction for SurfaceControl testing. (flutter/flutter#161438) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: ...

Try forking linux_host_engine into linux_host_engine_test.

ce47a64

matanlurey requested review from jtmcdole and zanderso January 13, 2025 19:07

github-actions bot added the engine flutter/engine related. See also e: labels. label Jan 13, 2025

zanderso reviewed Jan 13, 2025

View reviewed changes

Tweak run_tests.py, update JSON.

39c05b6

matanlurey requested a review from zanderso January 13, 2025 19:26

zanderso reviewed Jan 13, 2025

View reviewed changes

matanlurey mentioned this pull request Jan 13, 2025

Finish migrating run_tests.py font-subset #161538

Closed

zanderso approved these changes Jan 13, 2025

View reviewed changes

Revert.

12b96e3

jtmcdole approved these changes Jan 13, 2025

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2025

christopherfujino approved these changes Jan 13, 2025

View reviewed changes

auto-submit bot added this pull request to the merge queue Jan 13, 2025

Merged via the queue into flutter:master with commit 1d38029 Jan 14, 2025
183 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2025

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to f2c15f9debb2 (27 revisions) flutter/packages#8424

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

958b1dc

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to c9923ca609cc (28 revisions) flutter/packages#8425

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

e3093bf

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to ed9f9206629b (29 revisions) flutter/packages#8426

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

1ce3de1

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll mentioned this pull request Jan 14, 2025

Roll Flutter from 72db8f69e339 to 40c2b86fdf65 (33 revisions) flutter/packages#8428

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 14, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

0674d4c

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

d1d8e7d

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

52cd0d2

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

d306f77

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

e1551f0

…g `archives: [...]`. (flutter/flutter#161532)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

1d38029 Copy linux_host_engine as linux_host_engine_test, removin…

ca2aa04

…g `archives: [...]`. (flutter/flutter#161532)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. #161532

Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. #161532

Uh oh!

matanlurey commented Jan 13, 2025

Uh oh!

zanderso left a comment

Uh oh!

zanderso Jan 13, 2025

Uh oh!

matanlurey Jan 13, 2025

Uh oh!

zanderso Jan 13, 2025

Uh oh!

matanlurey Jan 13, 2025

Uh oh!

jtmcdole left a comment

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino commented Jan 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copy linux_host_engine as linux_host_engine_test, removing archives: [...]. #161532

Copy linux_host_engine as linux_host_engine_test, removing archives: [...]. #161532

Uh oh!

Conversation

matanlurey commented Jan 13, 2025

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

zanderso Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

matanlurey Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

jtmcdole left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Jan 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. #161532

Copy `linux_host_engine` as `linux_host_engine_test`, removing `archives: [...]`. #161532