fix: lint by gusfcarvalho · Pull Request #5536 · external-secrets/external-secrets

gusfcarvalho · 2025-11-03T13:50:24Z

After the split in go modules, linting action is running only on the root module (thus leaving children modules unchecked).

This PR attempts to fix it in a way it won't explode our CI time for every contribution.

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>

sonarqubecloud · 2025-11-03T15:35:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `0.20.4` -> `1.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v1.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.0.0) [Compare Source](external-secrets/external-secrets@v0.20.4...v1.0.0) Image: `ghcr.io/external-secrets/external-secrets:v1.0.0` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: release helm chart for v0.20.4 by [@Skarlso](https://github.com/Skarlso) in [#5502](external-secrets/external-secrets#5502) - chore(actions): fix security alerts for github actions by [@Skarlso](https://github.com/Skarlso) in [#5504](external-secrets/external-secrets#5504) - chore(release): fix incorrect shas from security alert pinning by [@jakobmoellerdev](https://github.com/jakobmoellerdev) in [#5512](external-secrets/external-secrets#5512) - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#5519](external-secrets/external-secrets#5519) - fix: upgrade go version by [@Skarlso](https://github.com/Skarlso) in [#5529](external-secrets/external-secrets#5529) - fix(charts): normalize certificate duration default value by [@aslafy-z](https://github.com/aslafy-z) in [#5497](external-secrets/external-secrets#5497) - chore(revive-linter): add revive linter configuration by [@Lumexralph](https://github.com/Lumexralph) in [#5515](external-secrets/external-secrets#5515) - feat: go module separation by [@moolen](https://github.com/moolen) in [#5498](external-secrets/external-secrets#5498) - fix: update deps script to reflect new go mod structure by [@moolen](https://github.com/moolen) in [#5532](external-secrets/external-secrets#5532) - fix: lint by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5536](external-secrets/external-secrets#5536) - feat: dynamic target implementation for external secrets sources by [@Skarlso](https://github.com/Skarlso) in [#5470](external-secrets/external-secrets#5470) - fix: codeql should not rebuild the world on every run by [@Skarlso](https://github.com/Skarlso) in [#5540](external-secrets/external-secrets#5540) - fix(onepassword): Reduce API usage by [@sondrelg](https://github.com/sondrelg) in [#5410](external-secrets/external-secrets#5410) - feat(esoctl): adds bootstrap generator commands by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5539](external-secrets/external-secrets#5539) - fix: adds missing externalsecret\_type validation on generatorRef by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5547](external-secrets/external-secrets#5547) - chore(docs): fix the generic resource doc using the incorrect switch by [@Skarlso](https://github.com/Skarlso) in [#5548](external-secrets/external-secrets#5548) - docs(adopters): add Topicus.Education to adopters list by [@sboschman](https://github.com/sboschman) in [#5551](external-secrets/external-secrets#5551) - fix(build): use more portable bash by [@tiagolobocastro](https://github.com/tiagolobocastro) in [#5537](external-secrets/external-secrets#5537) ##### Dependencies - chore(deps): bump alpine from `4bcff63` to `4b7ce07` in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5507](external-secrets/external-secrets#5507) - chore(deps): bump golang from 1.25.2 to 1.25.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#5506](external-secrets/external-secrets#5506) - chore(deps): bump golang from `aee43c3` to `aee43c3` by [@dependabot](https://github.com/dependabot)\[bot] in [#5516](external-secrets/external-secrets#5516) - chore(deps): bump golang from 1.25.2-bookworm to 1.25.3-bookworm in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in [#5505](external-secrets/external-secrets#5505) - chore(deps): bump anchore/sbom-action from 0.20.8 to 0.20.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#5508](external-secrets/external-secrets#5508) - chore(deps): bump hashicorp/setup-terraform from [`c529327`](external-secrets/external-secrets@c529327) to [`982f6f0`](external-secrets/external-secrets@982f6f0) by [@dependabot](https://github.com/dependabot)\[bot] in [#5510](external-secrets/external-secrets#5510) - chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5513](external-secrets/external-secrets#5513) - chore(deps): bump github/codeql-action from 4.30.9 to 4.31.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5514](external-secrets/external-secrets#5514) - chore(deps): bump actions/cache from 4.2.4 to 4.3.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5511](external-secrets/external-secrets#5511) - chore(deps): bump regex from 2025.9.18 to 2025.10.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5509](external-secrets/external-secrets#5509) - chore(deps): bump mkdocs-macros-plugin from 1.4.0 to 1.4.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5518](external-secrets/external-secrets#5518) - chore(deps): bump termcolor from 3.1.0 to 3.2.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5517](external-secrets/external-secrets#5517) - chore(deps): bump github/codeql-action from 4.31.0 to 4.31.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5531](external-secrets/external-secrets#5531) - chore(deps): bump mkdocs-material from 9.6.22 to 9.6.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5533](external-secrets/external-secrets#5533) #### New Contributors - [@sondrelg](https://github.com/sondrelg) made their first contribution in [#5410](external-secrets/external-secrets#5410) - [@tiagolobocastro](https://github.com/tiagolobocastro) made their first contribution in [#5537](external-secrets/external-secrets#5537) **Full Changelog**: <external-secrets/external-secrets@v0.20.4...v1.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1985 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `0.20.4` -> `1.1.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v1.1.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.1.0) [Compare Source](external-secrets/external-secrets@v1.0.0...v1.1.0) Image: `ghcr.io/external-secrets/external-secrets:v1.1.0` Image: `ghcr.io/external-secrets/external-secrets:v1.1.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v1.1.0-ubi-boringssl`  #### What's Changed !*NOTE*!: During last community meeting we discussed that we are retiring our scarf account. With that, we will be changing back to [ghcr.io/external-secrets/external-secrets](http://ghcr.io/external-secrets/external-secrets) instead of [oci.external-secrets.io/external-secrets/external-secrets](http://oci.external-secrets.io/external-secrets/external-secrets). For now, the old domain will live for a couple months to give people to change back. With this release , the values in the helm chart that define where the image is switched back to ghcr. The helm-chart itself is served from under github-pages so that does not move. ##### General - chore(chart): release helm chart 1.0.0 by [@Skarlso](https://github.com/Skarlso) in [#5552](external-secrets/external-secrets#5552) - feat(security): add support for ECDSA ssh keys by [@bigjazzsound](https://github.com/bigjazzsound) in [#5559](external-secrets/external-secrets#5559) - fix: minor typo in comment of KeeperSecurity example by [@mdjong1](https://github.com/mdjong1) in [#5573](external-secrets/external-secrets#5573) - docs(gcp): update documentation for using WorkloadIdentityFederation in non-GKE cluster by [@jennweir](https://github.com/jennweir) in [#5556](external-secrets/external-secrets#5556) - chore(release): add darwin\_arm64 releases by [@lbordowitz](https://github.com/lbordowitz) in [#5583](external-secrets/external-secrets#5583) - feat: support override IAM endpoint in IBM provider for APIkey auth by [@fidel-ruiz](https://github.com/fidel-ruiz) in [#5550](external-secrets/external-secrets#5550) - feat(security): build tags for all the providers to disable them on d… by [@ShimonDarshan](https://github.com/ShimonDarshan) in [#5578](external-secrets/external-secrets#5578) - fix: do not include the last element of the path in the iteration by [@Skarlso](https://github.com/Skarlso) in [#5588](external-secrets/external-secrets#5588) - fix(k8s): support deleting whole secret by [@tiagolobocastro](https://github.com/tiagolobocastro) in [#5538](external-secrets/external-secrets#5538) - fix(provider): configure TLS for secret server provider by [@Lumexralph](https://github.com/Lumexralph) in [#5558](external-secrets/external-secrets#5558) - chore(aws): remove any usage of aws-sdk-v1 by [@Skarlso](https://github.com/Skarlso) in [#5590](external-secrets/external-secrets#5590) - fix(gcp): check for secret version exists in PushSecret by [@bpalko](https://github.com/bpalko) in [#5593](external-secrets/external-secrets#5593) - feat(vault): add GCP Workload Identity authentication support by [@SamuelMolling](https://github.com/SamuelMolling) in [#5356](external-secrets/external-secrets#5356) - chore: fix sonar cloud issues by [@Skarlso](https://github.com/Skarlso) in [#5405](external-secrets/external-secrets#5405) - chore(aws-sdk-v2): update dependencies to accept new aws regions by [@damienpuig](https://github.com/damienpuig) in [#5577](external-secrets/external-secrets#5577) - feat(chart): use ghcr.io instead of our own domain by [@evrardjp](https://github.com/evrardjp) in [#5617](external-secrets/external-secrets#5617) ##### Dependencies - chore(deps): bump golang from 1.25.3 to 1.25.4 by [@dependabot](https://github.com/dependabot)\[bot] in [#5560](external-secrets/external-secrets#5560) - chore(deps): bump golang from 1.25.3-bookworm to 1.25.4-bookworm in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in [#5568](external-secrets/external-secrets#5568) - chore(deps): bump step-security/harden-runner from 2.13.1 to 2.13.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5561](external-secrets/external-secrets#5561) - chore(deps): bump softprops/action-gh-release from 2.4.1 to 2.4.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5564](external-secrets/external-secrets#5564) - chore(deps): bump helm/chart-testing-action from 2.7.0 to 2.8.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5565](external-secrets/external-secrets#5565) - chore(deps): bump aws-actions/configure-aws-credentials from [`0d00a56`](external-secrets/external-secrets@0d00a56) to [`2475ef7`](external-secrets/external-secrets@2475ef7) by [@dependabot](https://github.com/dependabot)\[bot] in [#5562](external-secrets/external-secrets#5562) - chore(deps): bump helm/kind-action from 1.12.0 to 1.13.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5563](external-secrets/external-secrets#5563) - chore(deps): bump docker/setup-qemu-action from 3.6.0 to 3.7.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5567](external-secrets/external-secrets#5567) - chore(deps): bump regex from 2025.10.23 to 2025.11.3 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5570](external-secrets/external-secrets#5570) - chore(deps): bump markdown from 3.9 to 3.10 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5569](external-secrets/external-secrets#5569) - chore(deps): bump hashicorp/setup-terraform from [`982f6f0`](external-secrets/external-secrets@982f6f0) to [`4c5fdab`](external-secrets/external-secrets@4c5fdab) by [@dependabot](https://github.com/dependabot)\[bot] in [#5566](external-secrets/external-secrets#5566) - chore(deps): bump golang from `d3f0cf7` to `d3f0cf7` by [@dependabot](https://github.com/dependabot)\[bot] in [#5595](external-secrets/external-secrets#5595) - chore(deps): bump github/codeql-action from 4.31.2 to 4.31.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#5596](external-secrets/external-secrets#5596) - chore(deps): bump click from 8.3.0 to 8.3.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5602](external-secrets/external-secrets#5602) - chore(deps): bump ubi9/ubi from `dec374e` to `dcd8128` by [@dependabot](https://github.com/dependabot)\[bot] in [#5594](external-secrets/external-secrets#5594) - chore(deps): bump aws-actions/configure-aws-credentials from [`2475ef7`](external-secrets/external-secrets@2475ef7) to [`f2964c7`](external-secrets/external-secrets@f2964c7) by [@dependabot](https://github.com/dependabot)\[bot] in [#5597](external-secrets/external-secrets#5597) - chore(deps): bump actions/dependency-review-action from 4.8.1 to 4.8.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5598](external-secrets/external-secrets#5598) - chore(deps): bump pymdown-extensions from 10.16.1 to 10.17.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5599](external-secrets/external-secrets#5599) - chore(deps): bump certifi from 2025.10.5 to 2025.11.12 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5600](external-secrets/external-secrets#5600) - chore(deps): bump mkdocs-material from 9.6.23 to 9.7.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5601](external-secrets/external-secrets#5601) - chore(deps): bump mkdocs-macros-plugin from 1.4.1 to 1.5.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5603](external-secrets/external-secrets#5603) #### New Contributors - [@bigjazzsound](https://github.com/bigjazzsound) made their first contribution in [#5559](external-secrets/external-secrets#5559) - [@mdjong1](https://github.com/mdjong1) made their first contribution in [#5573](external-secrets/external-secrets#5573) - [@jennweir](https://github.com/jennweir) made their first contribution in [#5556](external-secrets/external-secrets#5556) - [@lbordowitz](https://github.com/lbordowitz) made their first contribution in [#5583](external-secrets/external-secrets#5583) - [@fidel-ruiz](https://github.com/fidel-ruiz) made their first contribution in [#5550](external-secrets/external-secrets#5550) - [@ShimonDarshan](https://github.com/ShimonDarshan) made their first contribution in [#5578](external-secrets/external-secrets#5578) - [@bpalko](https://github.com/bpalko) made their first contribution in [#5593](external-secrets/external-secrets#5593) - [@SamuelMolling](https://github.com/SamuelMolling) made their first contribution in [#5356](external-secrets/external-secrets#5356) - [@damienpuig](https://github.com/damienpuig) made their first contribution in [#5577](external-secrets/external-secrets#5577) **Full Changelog**: <external-secrets/external-secrets@v1.0.0...v1.1.0> ### [`v1.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.0.0) [Compare Source](external-secrets/external-secrets@v0.20.4...v1.0.0) Image: `ghcr.io/external-secrets/external-secrets:v1.0.0` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: release helm chart for v0.20.4 by [@Skarlso](https://github.com/Skarlso) in [#5502](external-secrets/external-secrets#5502) - chore(actions): fix security alerts for github actions by [@Skarlso](https://github.com/Skarlso) in [#5504](external-secrets/external-secrets#5504) - chore(release): fix incorrect shas from security alert pinning by [@jakobmoellerdev](https://github.com/jakobmoellerdev) in [#5512](external-secrets/external-secrets#5512) - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#5519](external-secrets/external-secrets#5519) - fix: upgrade go version by [@Skarlso](https://github.com/Skarlso) in [#5529](external-secrets/external-secrets#5529) - fix(charts): normalize certificate duration default value by [@aslafy-z](https://github.com/aslafy-z) in [#5497](external-secrets/external-secrets#5497) - chore(revive-linter): add revive linter configuration by [@Lumexralph](https://github.com/Lumexralph) in [#5515](external-secrets/external-secrets#5515) - feat: go module separation by [@moolen](https://github.com/moolen) in [#5498](external-secrets/external-secrets#5498) - fix: update deps script to reflect new go mod structure by [@moolen](https://github.com/moolen) in [#5532](external-secrets/external-secrets#5532) - fix: lint by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5536](external-secrets/external-secrets#5536) - feat: dynamic target implementation for external secrets sources by [@Skarlso](https://github.com/Skarlso) in [#5470](external-secrets/external-secrets#5470) - fix: codeql should not rebuild the world on every run by [@Skarlso](https://github.com/Skarlso) in [#5540](external-secrets/external-secrets#5540) - fix(onepassword): Reduce API usage by [@sondrelg](https://github.com/sondrelg) in [#5410](external-secrets/external-secrets#5410) - feat(esoctl): adds bootstrap generator commands by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5539](external-secrets/external-secrets#5539) - fix: adds missing externalsecret\_type validation on generatorRef by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5547](external-secrets/external-secrets#5547) - chore(docs): fix the generic resource doc using the incorrect switch by [@Skarlso](https://github.com/Skarlso) in [#5548](external-secrets/external-secrets#5548) - docs(adopters): add Topicus.Education to adopters list by [@sboschman](https://github.com/sboschman) in [#5551](external-secrets/external-secrets#5551) - fix(build): use more portable bash by [@tiagolobocastro](https://github.com/tiagolobocastro) in [#5537](external-secrets/external-secrets#5537) ##### Dependencies - chore(deps): bump alpine from `4bcff63` to `4b7ce07` in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5507](external-secrets/external-secrets#5507) - chore(deps): bump golang from 1.25.2 to 1.25.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#5506](external-secrets/external-secrets#5506) - chore(deps): bump golang from `aee43c3` to `aee43c3` by [@dependabot](https://github.com/dependabot)\[bot] in [#5516](external-secrets/external-secrets#5516) - chore(deps): bump golang from 1.25.2-bookworm to 1.25.3-bookworm in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in [#5505](external-secrets/external-secrets#5505) - chore(deps): bump anchore/sbom-action from 0.20.8 to 0.20.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#5508](external-secrets/external-secrets#5508) - chore(deps): bump hashicorp/setup-terraform from [`c529327`](external-secrets/external-secrets@c529327) to [`982f6f0`](external-secrets/external-secrets@982f6f0) by [@dependabot](https://github.com/dependabot)\[bot] in [#5510](external-secrets/external-secrets#5510) - chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5513](external-secrets/external-secrets#5513) - chore(deps): bump github/codeql-action from 4.30.9 to 4.31.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5514](external-secrets/external-secrets#5514) - chore(deps): bump actions/cache from 4.2.4 to 4.3.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5511](external-secrets/external-secrets#5511) - chore(deps): bump regex from 2025.9.18 to 2025.10.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5509](external-secrets/external-secrets#5509) - chore(deps): bump mkdocs-macros-plugin from 1.4.0 to 1.4.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5518](external-secrets/external-secrets#5518) - chore(deps): bump termcolor from 3.1.0 to 3.2.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5517](external-secrets/external-secrets#5517) - chore(deps): bump github/codeql-action from 4.31.0 to 4.31.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5531](external-secrets/external-secrets#5531) - chore(deps): bump mkdocs-material from 9.6.22 to 9.6.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5533](external-secrets/external-secrets#5533) #### New Contributors - [@sondrelg](https://github.com/sondrelg) made their first contribution in [#5410](external-secrets/external-secrets#5410) - [@tiagolobocastro](https://github.com/tiagolobocastro) made their first contribution in [#5537](external-secrets/external-secrets#5537) **Full Changelog**: <external-secrets/external-secrets@v0.20.4...v1.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/161

gusfcarvalho added 2 commits November 3, 2025 10:39

fix: make lint/fmt now runs on every module

213e552

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>

fix: add ci fixes for lint action

ad00728

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>

github-project-automation Bot added this to External Secrets Nov 3, 2025

github-actions Bot added kind/bug Categorizes issue or PR as related to a bug. component/github-actions size/m labels Nov 3, 2025