fix(build): use more portable bash by tiagolobocastro · Pull Request #5537 · external-secrets/external-secrets

tiagolobocastro · 2025-11-03T15:47:56Z

Problem Statement

Currently scritps assume bash to be present at /bin/bash, but this is not always the case.

Related Issue

Nothing directly related, found this whilst trying to build for a separate issue..

Proposed Changes

Switch a more portable alternative (/usr/bin/env bash), which finds whatever version is available for the user.

Format

Please ensure that your PR follows the following format for the title:

feat(scope): add new feature
fix(scope): fix bug
docs(scope): update documentation
chore(scope): update build tool or dependencies
ref(scope): refactor code
clean(scope): provider cleanup
test(scope): add tests
perf(scope): improve performance
desig(scope): improve design

Where scope is optionally one of:

charts
release
testing
security
templating

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Currently scritps assume bash to be present at /bin/bash, but this is not always the case. Switch a more portable alternative (/usr/bin/env bash), which finds whatever version is available for the user. Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

Skarlso · 2025-11-04T06:10:48Z

hack/api-docs/Makefile

 		--user $(UID):$(GID) \
 		$(MKDOCS_IMAGE) \
-		/bin/bash -c "cd /repo && $(MIKE) deploy --update-aliases -p -F hack/api-docs/mkdocs.yml $(DOCS_VERSION) $(DOCS_ALIAS);"
+		bash -c "cd /repo && $(MIKE) deploy --update-aliases -p -F hack/api-docs/mkdocs.yml $(DOCS_VERSION) $(DOCS_ALIAS);"


Looks okay, however, would you please introduce

SHELL := /usr/bin/env bash

here as well instead of just bash? :) 🙇

ah yes, good catch

I've pushed a separate commit, let me know if you want me to squash

Use correct $SHELL on the hack/api-docs Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

sonarqubecloud · 2025-11-07T10:54:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `0.20.4` -> `1.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v1.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.0.0) [Compare Source](external-secrets/external-secrets@v0.20.4...v1.0.0) Image: `ghcr.io/external-secrets/external-secrets:v1.0.0` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi-boringssl`  #### What's Changed ##### General - chore: release helm chart for v0.20.4 by [@Skarlso](https://github.com/Skarlso) in [#5502](external-secrets/external-secrets#5502) - chore(actions): fix security alerts for github actions by [@Skarlso](https://github.com/Skarlso) in [#5504](external-secrets/external-secrets#5504) - chore(release): fix incorrect shas from security alert pinning by [@jakobmoellerdev](https://github.com/jakobmoellerdev) in [#5512](external-secrets/external-secrets#5512) - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#5519](external-secrets/external-secrets#5519) - fix: upgrade go version by [@Skarlso](https://github.com/Skarlso) in [#5529](external-secrets/external-secrets#5529) - fix(charts): normalize certificate duration default value by [@aslafy-z](https://github.com/aslafy-z) in [#5497](external-secrets/external-secrets#5497) - chore(revive-linter): add revive linter configuration by [@Lumexralph](https://github.com/Lumexralph) in [#5515](external-secrets/external-secrets#5515) - feat: go module separation by [@moolen](https://github.com/moolen) in [#5498](external-secrets/external-secrets#5498) - fix: update deps script to reflect new go mod structure by [@moolen](https://github.com/moolen) in [#5532](external-secrets/external-secrets#5532) - fix: lint by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5536](external-secrets/external-secrets#5536) - feat: dynamic target implementation for external secrets sources by [@Skarlso](https://github.com/Skarlso) in [#5470](external-secrets/external-secrets#5470) - fix: codeql should not rebuild the world on every run by [@Skarlso](https://github.com/Skarlso) in [#5540](external-secrets/external-secrets#5540) - fix(onepassword): Reduce API usage by [@sondrelg](https://github.com/sondrelg) in [#5410](external-secrets/external-secrets#5410) - feat(esoctl): adds bootstrap generator commands by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5539](external-secrets/external-secrets#5539) - fix: adds missing externalsecret\_type validation on generatorRef by [@gusfcarvalho](https://github.com/gusfcarvalho) in [#5547](external-secrets/external-secrets#5547) - chore(docs): fix the generic resource doc using the incorrect switch by [@Skarlso](https://github.com/Skarlso) in [#5548](external-secrets/external-secrets#5548) - docs(adopters): add Topicus.Education to adopters list by [@sboschman](https://github.com/sboschman) in [#5551](external-secrets/external-secrets#5551) - fix(build): use more portable bash by [@tiagolobocastro](https://github.com/tiagolobocastro) in [#5537](external-secrets/external-secrets#5537) ##### Dependencies - chore(deps): bump alpine from `4bcff63` to `4b7ce07` in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5507](external-secrets/external-secrets#5507) - chore(deps): bump golang from 1.25.2 to 1.25.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#5506](external-secrets/external-secrets#5506) - chore(deps): bump golang from `aee43c3` to `aee43c3` by [@dependabot](https://github.com/dependabot)\[bot] in [#5516](external-secrets/external-secrets#5516) - chore(deps): bump golang from 1.25.2-bookworm to 1.25.3-bookworm in /e2e by [@dependabot](https://github.com/dependabot)\[bot] in [#5505](external-secrets/external-secrets#5505) - chore(deps): bump anchore/sbom-action from 0.20.8 to 0.20.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#5508](external-secrets/external-secrets#5508) - chore(deps): bump hashicorp/setup-terraform from [`c529327`](external-secrets/external-secrets@c529327) to [`982f6f0`](external-secrets/external-secrets@982f6f0) by [@dependabot](https://github.com/dependabot)\[bot] in [#5510](external-secrets/external-secrets#5510) - chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5513](external-secrets/external-secrets#5513) - chore(deps): bump github/codeql-action from 4.30.9 to 4.31.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5514](external-secrets/external-secrets#5514) - chore(deps): bump actions/cache from 4.2.4 to 4.3.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#5511](external-secrets/external-secrets#5511) - chore(deps): bump regex from 2025.9.18 to 2025.10.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5509](external-secrets/external-secrets#5509) - chore(deps): bump mkdocs-macros-plugin from 1.4.0 to 1.4.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5518](external-secrets/external-secrets#5518) - chore(deps): bump termcolor from 3.1.0 to 3.2.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5517](external-secrets/external-secrets#5517) - chore(deps): bump github/codeql-action from 4.31.0 to 4.31.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#5531](external-secrets/external-secrets#5531) - chore(deps): bump mkdocs-material from 9.6.22 to 9.6.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot)\[bot] in [#5533](external-secrets/external-secrets#5533) #### New Contributors - [@sondrelg](https://github.com/sondrelg) made their first contribution in [#5410](external-secrets/external-secrets#5410) - [@tiagolobocastro](https://github.com/tiagolobocastro) made their first contribution in [#5537](external-secrets/external-secrets#5537) **Full Changelog**: <external-secrets/external-secrets@v0.20.4...v1.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1985 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

github-project-automation bot added this to External Secrets Nov 3, 2025

github-actions bot added kind/documentation Categorizes issue or PR as related to documentation. size/s labels Nov 3, 2025

gusfcarvalho changed the title ~~build: use more portable bash~~ fix(build): use more portable bash Nov 3, 2025

github-actions bot added area/build kind/bug Categorizes issue or PR as related to a bug. labels Nov 3, 2025

Skarlso reviewed Nov 4, 2025

View reviewed changes

build: use bash shell correctly

d32770e

Use correct $SHELL on the hack/api-docs Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

Skarlso approved these changes Nov 7, 2025

View reviewed changes

Merge branch 'main' into build-bash

f933325

Skarlso merged commit 8dc6e63 into external-secrets:main Nov 7, 2025
29 checks passed

github-project-automation bot moved this to Done in External Secrets Nov 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(build): use more portable bash#5537

fix(build): use more portable bash#5537
Skarlso merged 3 commits intoexternal-secrets:mainfrom
tiagolobocastro:build-bash

tiagolobocastro commented Nov 3, 2025 •

edited

Loading

Uh oh!

Skarlso Nov 4, 2025

Uh oh!

tiagolobocastro Nov 4, 2025

Uh oh!

tiagolobocastro Nov 4, 2025 •

edited

Loading

Uh oh!

Skarlso Nov 5, 2025

Uh oh!

sonarqubecloud bot commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tiagolobocastro commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Related Issue

Proposed Changes

Format

Checklist

Uh oh!

Skarlso Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tiagolobocastro Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

tiagolobocastro Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skarlso Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 7, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tiagolobocastro commented Nov 3, 2025 •

edited

Loading

tiagolobocastro Nov 4, 2025 •

edited

Loading