chore(revive-linter): add revive linter configuration#5515
Merged
Skarlso merged 3 commits intoexternal-secrets:mainfrom Nov 1, 2025
Merged
chore(revive-linter): add revive linter configuration#5515Skarlso merged 3 commits intoexternal-secrets:mainfrom
Skarlso merged 3 commits intoexternal-secrets:mainfrom
Conversation
Signed-off-by: Olumide Ogundele <olumideralph@gmail.com>
Lumexralph
commented
Oct 27, 2025
|
Skarlso
approved these changes
Nov 1, 2025
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Nov 10, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | major | `0.20.4` -> `1.0.0` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v1.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.0.0) [Compare Source](external-secrets/external-secrets@v0.20.4...v1.0.0) Image: `ghcr.io/external-secrets/external-secrets:v1.0.0` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi-boringssl` <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### General - chore: release helm chart for v0.20.4 by [@​Skarlso](https://github.com/Skarlso) in [#​5502](external-secrets/external-secrets#5502) - chore(actions): fix security alerts for github actions by [@​Skarlso](https://github.com/Skarlso) in [#​5504](external-secrets/external-secrets#5504) - chore(release): fix incorrect shas from security alert pinning by [@​jakobmoellerdev](https://github.com/jakobmoellerdev) in [#​5512](external-secrets/external-secrets#5512) - chore: update dependencies by [@​eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#​5519](external-secrets/external-secrets#5519) - fix: upgrade go version by [@​Skarlso](https://github.com/Skarlso) in [#​5529](external-secrets/external-secrets#5529) - fix(charts): normalize certificate duration default value by [@​aslafy-z](https://github.com/aslafy-z) in [#​5497](external-secrets/external-secrets#5497) - chore(revive-linter): add revive linter configuration by [@​Lumexralph](https://github.com/Lumexralph) in [#​5515](external-secrets/external-secrets#5515) - feat: go module separation by [@​moolen](https://github.com/moolen) in [#​5498](external-secrets/external-secrets#5498) - fix: update deps script to reflect new go mod structure by [@​moolen](https://github.com/moolen) in [#​5532](external-secrets/external-secrets#5532) - fix: lint by [@​gusfcarvalho](https://github.com/gusfcarvalho) in [#​5536](external-secrets/external-secrets#5536) - feat: dynamic target implementation for external secrets sources by [@​Skarlso](https://github.com/Skarlso) in [#​5470](external-secrets/external-secrets#5470) - fix: codeql should not rebuild the world on every run by [@​Skarlso](https://github.com/Skarlso) in [#​5540](external-secrets/external-secrets#5540) - fix(onepassword): Reduce API usage by [@​sondrelg](https://github.com/sondrelg) in [#​5410](external-secrets/external-secrets#5410) - feat(esoctl): adds bootstrap generator commands by [@​gusfcarvalho](https://github.com/gusfcarvalho) in [#​5539](external-secrets/external-secrets#5539) - fix: adds missing externalsecret\_type validation on generatorRef by [@​gusfcarvalho](https://github.com/gusfcarvalho) in [#​5547](external-secrets/external-secrets#5547) - chore(docs): fix the generic resource doc using the incorrect switch by [@​Skarlso](https://github.com/Skarlso) in [#​5548](external-secrets/external-secrets#5548) - docs(adopters): add Topicus.Education to adopters list by [@​sboschman](https://github.com/sboschman) in [#​5551](external-secrets/external-secrets#5551) - fix(build): use more portable bash by [@​tiagolobocastro](https://github.com/tiagolobocastro) in [#​5537](external-secrets/external-secrets#5537) ##### Dependencies - chore(deps): bump alpine from `4bcff63` to `4b7ce07` in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5507](external-secrets/external-secrets#5507) - chore(deps): bump golang from 1.25.2 to 1.25.3 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5506](external-secrets/external-secrets#5506) - chore(deps): bump golang from `aee43c3` to `aee43c3` by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5516](external-secrets/external-secrets#5516) - chore(deps): bump golang from 1.25.2-bookworm to 1.25.3-bookworm in /e2e by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5505](external-secrets/external-secrets#5505) - chore(deps): bump anchore/sbom-action from 0.20.8 to 0.20.9 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5508](external-secrets/external-secrets#5508) - chore(deps): bump hashicorp/setup-terraform from [`c529327`](external-secrets/external-secrets@c529327) to [`982f6f0`](external-secrets/external-secrets@982f6f0) by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5510](external-secrets/external-secrets#5510) - chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5513](external-secrets/external-secrets#5513) - chore(deps): bump github/codeql-action from 4.30.9 to 4.31.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5514](external-secrets/external-secrets#5514) - chore(deps): bump actions/cache from 4.2.4 to 4.3.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5511](external-secrets/external-secrets#5511) - chore(deps): bump regex from 2025.9.18 to 2025.10.23 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5509](external-secrets/external-secrets#5509) - chore(deps): bump mkdocs-macros-plugin from 1.4.0 to 1.4.1 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5518](external-secrets/external-secrets#5518) - chore(deps): bump termcolor from 3.1.0 to 3.2.0 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5517](external-secrets/external-secrets#5517) - chore(deps): bump github/codeql-action from 4.31.0 to 4.31.2 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5531](external-secrets/external-secrets#5531) - chore(deps): bump mkdocs-material from 9.6.22 to 9.6.23 in /hack/api-docs by [@​dependabot](https://github.com/dependabot)\[bot] in [#​5533](external-secrets/external-secrets#5533) #### New Contributors - [@​sondrelg](https://github.com/sondrelg) made their first contribution in [#​5410](external-secrets/external-secrets#5410) - [@​tiagolobocastro](https://github.com/tiagolobocastro) made their first contribution in [#​5537](external-secrets/external-secrets#5537) **Full Changelog**: <external-secrets/external-secrets@v0.20.4...v1.0.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4wLjEiLCJ1cGRhdGVkSW5WZXIiOiI0Mi4wLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImNoYXJ0Il19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1985 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
According to this PR #3396 that was implemented, the revive linter wasn't configured because it had loads of issues to be fixed. This PR configures the revive linter and adds the last piece needed to complete the fix and configuration of the revive linter.
Related Issue
Fixes #3397
Proposed Changes
Creates revive linter configuration and fixes additional issues introduced by merged code after the previous fix.
Format
Please ensure that your PR follows the following format for the title:
Where
scopeis optionally one of:Checklist
git commit --signoffmake testmake reviewable