Skip to content

fix: lint#5536

Merged
gusfcarvalho merged 6 commits intomainfrom
gc-fix-lint
Nov 3, 2025
Merged

fix: lint#5536
gusfcarvalho merged 6 commits intomainfrom
gc-fix-lint

Conversation

@gusfcarvalho
Copy link
Copy Markdown
Member

After the split in go modules, linting action is running only on the root module (thus leaving children modules unchecked).

This PR attempts to fix it in a way it won't explode our CI time for every contribution.

Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
@github-actions github-actions bot added kind/bug Categorizes issue or PR as related to a bug. component/github-actions size/m labels Nov 3, 2025
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
Skarlso
Skarlso previously approved these changes Nov 3, 2025
Signed-off-by: Gustavo Carvalho <gustavo@externalsecrets.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 3, 2025

@gusfcarvalho gusfcarvalho merged commit 194955a into main Nov 3, 2025
32 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-lint branch November 3, 2025 17:11
alexlebens pushed a commit to alexlebens/infrastructure that referenced this pull request Nov 10, 2025
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [external-secrets](https://github.com/external-secrets/external-secrets) | major | `0.20.4` -> `1.0.0` |

---

### Release Notes

<details>
<summary>external-secrets/external-secrets (external-secrets)</summary>

### [`v1.0.0`](https://github.com/external-secrets/external-secrets/releases/tag/v1.0.0)

[Compare Source](external-secrets/external-secrets@v0.20.4...v1.0.0)

Image: `ghcr.io/external-secrets/external-secrets:v1.0.0`
Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi`
Image: `ghcr.io/external-secrets/external-secrets:v1.0.0-ubi-boringssl`

<!-- Release notes generated using configuration in .github/release.yml at main -->

#### What's Changed

##### General

- chore: release helm chart for v0.20.4 by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5502](external-secrets/external-secrets#5502)
- chore(actions): fix security alerts for github actions by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5504](external-secrets/external-secrets#5504)
- chore(release): fix incorrect shas from security alert pinning by [@&#8203;jakobmoellerdev](https://github.com/jakobmoellerdev) in [#&#8203;5512](external-secrets/external-secrets#5512)
- chore: update dependencies by [@&#8203;eso-service-account-app](https://github.com/eso-service-account-app)\[bot] in [#&#8203;5519](external-secrets/external-secrets#5519)
- fix: upgrade go version by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5529](external-secrets/external-secrets#5529)
- fix(charts): normalize certificate duration default value by [@&#8203;aslafy-z](https://github.com/aslafy-z) in [#&#8203;5497](external-secrets/external-secrets#5497)
- chore(revive-linter): add revive linter configuration by [@&#8203;Lumexralph](https://github.com/Lumexralph) in [#&#8203;5515](external-secrets/external-secrets#5515)
- feat: go module separation by [@&#8203;moolen](https://github.com/moolen) in [#&#8203;5498](external-secrets/external-secrets#5498)
- fix: update deps script to reflect new go mod structure by [@&#8203;moolen](https://github.com/moolen) in [#&#8203;5532](external-secrets/external-secrets#5532)
- fix: lint by [@&#8203;gusfcarvalho](https://github.com/gusfcarvalho) in [#&#8203;5536](external-secrets/external-secrets#5536)
- feat: dynamic target implementation for external secrets sources  by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5470](external-secrets/external-secrets#5470)
- fix: codeql should not rebuild the world on every run by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5540](external-secrets/external-secrets#5540)
- fix(onepassword): Reduce API usage by [@&#8203;sondrelg](https://github.com/sondrelg) in [#&#8203;5410](external-secrets/external-secrets#5410)
- feat(esoctl): adds bootstrap generator commands by [@&#8203;gusfcarvalho](https://github.com/gusfcarvalho) in [#&#8203;5539](external-secrets/external-secrets#5539)
- fix: adds missing externalsecret\_type validation on generatorRef by [@&#8203;gusfcarvalho](https://github.com/gusfcarvalho) in [#&#8203;5547](external-secrets/external-secrets#5547)
- chore(docs): fix the generic resource doc using the incorrect switch by [@&#8203;Skarlso](https://github.com/Skarlso) in [#&#8203;5548](external-secrets/external-secrets#5548)
- docs(adopters): add Topicus.Education to adopters list by [@&#8203;sboschman](https://github.com/sboschman) in [#&#8203;5551](external-secrets/external-secrets#5551)
- fix(build): use more portable bash by [@&#8203;tiagolobocastro](https://github.com/tiagolobocastro) in [#&#8203;5537](external-secrets/external-secrets#5537)

##### Dependencies

- chore(deps): bump alpine from `4bcff63` to `4b7ce07` in /hack/api-docs by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5507](external-secrets/external-secrets#5507)
- chore(deps): bump golang from 1.25.2 to 1.25.3 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5506](external-secrets/external-secrets#5506)
- chore(deps): bump golang from `aee43c3` to `aee43c3` by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5516](external-secrets/external-secrets#5516)
- chore(deps): bump golang from 1.25.2-bookworm to 1.25.3-bookworm in /e2e by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5505](external-secrets/external-secrets#5505)
- chore(deps): bump anchore/sbom-action from 0.20.8 to 0.20.9 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5508](external-secrets/external-secrets#5508)
- chore(deps): bump hashicorp/setup-terraform from [`c529327`](external-secrets/external-secrets@c529327) to [`982f6f0`](external-secrets/external-secrets@982f6f0) by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5510](external-secrets/external-secrets#5510)
- chore(deps): bump actions/github-script from 7.0.1 to 8.0.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5513](external-secrets/external-secrets#5513)
- chore(deps): bump github/codeql-action from 4.30.9 to 4.31.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5514](external-secrets/external-secrets#5514)
- chore(deps): bump actions/cache from 4.2.4 to 4.3.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5511](external-secrets/external-secrets#5511)
- chore(deps): bump regex from 2025.9.18 to 2025.10.23 in /hack/api-docs by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5509](external-secrets/external-secrets#5509)
- chore(deps): bump mkdocs-macros-plugin from 1.4.0 to 1.4.1 in /hack/api-docs by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5518](external-secrets/external-secrets#5518)
- chore(deps): bump termcolor from 3.1.0 to 3.2.0 in /hack/api-docs by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5517](external-secrets/external-secrets#5517)
- chore(deps): bump github/codeql-action from 4.31.0 to 4.31.2 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5531](external-secrets/external-secrets#5531)
- chore(deps): bump mkdocs-material from 9.6.22 to 9.6.23 in /hack/api-docs by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;5533](external-secrets/external-secrets#5533)

#### New Contributors

- [@&#8203;sondrelg](https://github.com/sondrelg) made their first contribution in [#&#8203;5410](external-secrets/external-secrets#5410)
- [@&#8203;tiagolobocastro](https://github.com/tiagolobocastro) made their first contribution in [#&#8203;5537](external-secrets/external-secrets#5537)

**Full Changelog**: <external-secrets/external-secrets@v0.20.4...v1.0.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4wLjEiLCJ1cGRhdGVkSW5WZXIiOiI0Mi4wLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImNoYXJ0Il19-->

Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1985
Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net>
Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/github-actions kind/bug Categorizes issue or PR as related to a bug. size/m

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants