Skip to content

Add new Documentation#3

Merged
ben-chain merged 1 commit intomasterfrom
feat/new-documentation
Feb 12, 2020
Merged

Add new Documentation#3
ben-chain merged 1 commit intomasterfrom
feat/new-documentation

Conversation

@ben-chain
Copy link
Copy Markdown
Collaborator

Self explanatory :)

@ben-chain ben-chain merged commit 71271d4 into master Feb 12, 2020
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
AbdulmalikGiwa referenced this pull request in SYS-Labs/rollux Jun 13, 2023
giacomolicari pushed a commit to gnosispay/optimism that referenced this pull request Jun 20, 2023
refcell pushed a commit that referenced this pull request Aug 14, 2023
refcell pushed a commit that referenced this pull request Sep 6, 2023
Add extra multiRequest.data.length == 0 validation
max-sanchez referenced this pull request in hemilabs/optimism Apr 16, 2024
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92 referenced this pull request in hemilabs/optimism Apr 17, 2024
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50)
1146a08b5 localnet reorg fix (ethereum-optimism#76)
87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64)
9073baeaf localnet (#37)
1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51)
210aabe7a Update popm.go, fix typo (#40)
a5e689493 make: automate copyright headers (#31)
1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33)
1be4df2a3 Use 'errors.Is' to compare errors (#32)
3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36)
c5b0fea01 electrumx: add connection reuse and pooling (#26)
cfc1293e9 Update README.md (#29)
8896259f0 retry mine keystone on failure (#18)
a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27)
6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28)
ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16)
ac3b7eacb docker: update golang image to v1.22.1 (#25)
d6b0ac8af returning response errors if they exist from bfg -> popm (#24)
d450b787a Network test start height + no panic (#22)
b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19)
bfd3b1dc0 make: add -local flag to goimports (#9)
e0e8964fc Move internal error into protocol package (#10)
7875a897c l2 keystone mining fixes (#3)

git-subtree-dir: heminetwork
git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
mbaxter added a commit to mbaxter/optimism that referenced this pull request Nov 12, 2024
umbertov pushed a commit to umbertov/optimism that referenced this pull request Oct 1, 2025
smartcontracts added a commit that referenced this pull request Feb 22, 2026
Address informational audit findings with improved inline documentation:
- Document that guardian pause blocks interop upgrades (acceptable for dev feature)
- Document migrate() is exclusively for N pre-interop chains merging into one set
- Document that re-migration and partial migration are not supported
- Document intentional use of chainSystemConfigs[0] for shared contracts
- Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts added a commit that referenced this pull request Feb 22, 2026
Address informational audit findings with improved inline documentation:
- Document that guardian pause blocks interop upgrades (acceptable for dev feature)
- Document migrate() is exclusively for N pre-interop chains merging into one set
- Document that re-migration and partial migration are not supported
- Document intentional use of chainSystemConfigs[0] for shared contracts
- Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts added a commit that referenced this pull request Feb 22, 2026
…16

Add missing @param blueprint NatSpec to OpcmContractRef struct (#2).
Add comments about pause blocking interop upgrades (#3). Document
migrate() scope limitations and re-migration risks (#7, #15). Update
PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional
use of chainSystemConfigs[0] for shared contracts (#16).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2026
…16 (#19271)

Add missing @param blueprint NatSpec to OpcmContractRef struct (#2).
Add comments about pause blocking interop upgrades (#3). Document
migrate() scope limitations and re-migration risks (#7, #15). Update
PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional
use of chainSystemConfigs[0] for shared contracts (#16).

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts added a commit that referenced this pull request Mar 6, 2026
The 5s timeout is too tight under CI load. When 12 parallel test nodes
compete for CPU/IO on a 2xlarge box, Anvil sometimes takes >5s to print
its "Listening on" line, triggering "anvil did not start in time" in
TestImplementations and TestSuperchain. This is the #2 and #3 most
frequent flake in the repo over the last 7 days (67 and 46 incidences).

30s gives Anvil enough headroom on a loaded machine while still failing
fast on a genuine startup failure.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2026
The 5s timeout is too tight under CI load. When 12 parallel test nodes
compete for CPU/IO on a 2xlarge box, Anvil sometimes takes >5s to print
its "Listening on" line, triggering "anvil did not start in time" in
TestImplementations and TestSuperchain. This is the #2 and #3 most
frequent flake in the repo over the last 7 days (67 and 46 incidences).

30s gives Anvil enough headroom on a loaded machine while still failing
fast on a genuine startup failure.

Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
wwared pushed a commit that referenced this pull request Mar 9, 2026
The 5s timeout is too tight under CI load. When 12 parallel test nodes
compete for CPU/IO on a 2xlarge box, Anvil sometimes takes >5s to print
its "Listening on" line, triggering "anvil did not start in time" in
TestImplementations and TestSuperchain. This is the #2 and #3 most
frequent flake in the repo over the last 7 days (67 and 46 incidences).

30s gives Anvil enough headroom on a loaded machine while still failing
fast on a genuine startup failure.

Co-authored-by: smartcontracts <smartcontracts@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant