Merged
Conversation
* Changing examples package to be more generic * Updating default exec manager address
* Add executable fullnode * Add better logging with debug mode * Fix linting bug
We've forked Geth to intercept calls to the ExecutionManger contract in ethereum-optimism/go-ethereum#1. Add a a test that tests these changes. The test is a copy of the existing simple storage spec with some minor changes. Namely, we don't test that storage events were emitted when ExecutionManager#ovmSSTORE is called because our forked version of Geth doesn't emit events. This also makes a couple changes to test helper file: We pass in the address of the ExecutionManager to manuallyDeployOvmContract instead of the ExecutionManager itself. This allows us to pass in an address of an ExecutionManager that's already been deployed which we need to do in our new test. Replace getTransactionReceipt with waitForTransaction. When we were using the Javascript provider transactions would be mined more-or-less immediately. This means that getTransactionReceipt could be called immediately after sendTransaction and the transaction would be ready. When we're talking to a Geth node this may not be the case. Switching to waitForTransaction allows time for the transaction to be mined.
Working Truffle Example! Note: A small hack is required to get this to work -- documented in `packages/examples/truffle-config.js` Also adds: * Fix for nonces in ExecutionManager.sol * Gas limit fix setting it to the required 9_000_000 vs 5_000_000 in the fullnode * Util for adding padding to strings to make them of a certain length * Optional `add0x` param on `bufToHexStr(...)` * Lock around separate txs that are assumed to be run sequentially in DefaultWeb3Handler Co-authored-by: Mason Fischer <mason@kissr.co>
Before we were only incrementing nonces on CREATE. Wallets expect nonces to be incremented on CALLs aswell. This test tests that we are in fact inrementing nonces on CALLs aswell. Other changes: * Update the name of the executeCall test
…-by-side standard testing & ovm testing (#72)
karlfloersch
approved these changes
Mar 2, 2020
| 'BBBbeedfeedBBBBBBbeedfeedBBBBBBbeedfeedBBBBBBbeedfeedBBBBBBbeedfeedBBBBBBbeedfeedBBBBBBbeedfeedBBB' | ||
| ) | ||
| it('should work for the first bytes memory constant', async () => { | ||
| it('should work for the second bytes memory constant', async () => { |
Contributor
There was a problem hiding this comment.
Asked Ben about this, he said that it was just a type-o where he copied a test but forgot to update the name
| @@ -0,0 +1,7 @@ | |||
| pragma solidity ^0.5.0; | |||
|
|
|||
| contract SelfAware { | |||
| const timeGetter = await deployContract(wallet, TimeGetter, [], []) | ||
| const time = await timeGetter.getTimestamp() | ||
| time._hex.should.equal('???') | ||
| }) |
Contributor
There was a problem hiding this comment.
We've technically added timestamp in 4bf0c7e so this test could be enabled.
karlfloersch
reviewed
Mar 2, 2020
| import * as CallerGetter from '../contracts/build/transpiled/CallerGetter.json' | ||
| import * as OriginGetter from '../contracts/build/transpiled/OriginGetter.json' | ||
| import * as CallerReturner from '../contracts/build/transpiled/CallerReturner.json' | ||
| import * as TimeGetter from '../contracts/build/transpiled/TimeGetter.json' |
Contributor
There was a problem hiding this comment.
Btw one thing I forgot to mention is that technically if we were keeping to convention there'd be a comment for Contract Imports which has all of these as opposed to internal imports, even though of course contract imports are internal. But just a note that's the convention that has organically emerged (I think from Kelvin)
masonforest
added a commit
that referenced
this pull request
Mar 4, 2020
This reverts commit 00581e3.
willmeister
pushed a commit
that referenced
this pull request
Mar 5, 2020
This reverts commit 00581e3.
gakonst
added a commit
that referenced
this pull request
Apr 12, 2021
* chore: cleanup gitignore * fix: adjust package.json and tsconfigs * feat: expose base-service in core-utils * chore(l1-ingestion): use base-service from core-utils * chore(l2-ingestion): use base-service from core-utils * chore: use base-service from core-utils in remaining services
InoMurko
referenced
this pull request
in omgnetwork/optimism
May 25, 2021
* chore: cleanup gitignore * fix: adjust package.json and tsconfigs * feat: expose base-service in core-utils * chore(l1-ingestion): use base-service from core-utils * chore(l2-ingestion): use base-service from core-utils * chore: use base-service from core-utils in remaining services
max-sanchez
referenced
this pull request
in hemilabs/optimism
Apr 16, 2024
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92
referenced
this pull request
in hemilabs/optimism
Apr 17, 2024
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
therealbytes
added a commit
to therealbytes/optimism
that referenced
this pull request
May 17, 2024
* refactor: var rename * refactor: use uint64 for timestamp and gas limit * refactor: alias api to cc_api for consistency * refactor: var renames * refactor: var and alias name changes * build: wasm test binaries
bap2pecs
referenced
this pull request
in babylonlabs-io/optimism
Jul 31, 2024
SozinM
pushed a commit
to NethermindEth/optimism
that referenced
this pull request
Feb 10, 2025
…fork check current fork to set ExcessBlobGas and BlobGasUsed
ClaytonNorthey92
referenced
this pull request
in hemilabs/optimism
Apr 4, 2025
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
ClaytonNorthey92
referenced
this pull request
in hemilabs/optimism
Apr 7, 2025
88047e707 Add tbcd, a small bitcoin daemon that participates on bitcoin p2p (ethereum-optimism#50) 1146a08b5 localnet reorg fix (ethereum-optimism#76) 87f18a191 build(deps): bump github.com/docker/docker (ethereum-optimism#64) 9073baeaf localnet (#37) 1588cbf04 Add common user-specific files to gitignore (ethereum-optimism#51) 210aabe7a Update popm.go, fix typo (#40) a5e689493 make: automate copyright headers (#31) 1c3bfc9bc Use `maps.Clone(m)` to copy returned map in `APICommands()` (#33) 1be4df2a3 Use 'errors.Is' to compare errors (#32) 3f6bc5f8e e2e: sync ElectrumX environment variables with infra (#36) c5b0fea01 electrumx: add connection reuse and pooling (#26) cfc1293e9 Update README.md (#29) 8896259f0 retry mine keystone on failure (#18) a10e3bb29 Use '%w' verb in fmt.Errorf to wrap errors (fixes #13) (#27) 6cd677611 deps: update google.golang.org/protobuf to v1.33.0 (#28) ed7eb8e97 ci: fix concurrency cancel-in-progress for pull requests (#16) ac3b7eacb docker: update golang image to v1.22.1 (#25) d6b0ac8af returning response errors if they exist from bfg -> popm (#24) d450b787a Network test start height + no panic (#22) b390805c5 allowing BTC Block and L2 Keystone generation rates to be configurable in local network (#19) bfd3b1dc0 make: add -local flag to goimports (#9) e0e8964fc Move internal error into protocol package (#10) 7875a897c l2 keystone mining fixes (#3) git-subtree-dir: heminetwork git-subtree-split: 88047e707e2db8522e2ad77c5f849e55bc94cd10
blockchaindevsh
added a commit
to blockchaindevsh/optimism
that referenced
this pull request
Jun 30, 2025
cuiweixie
added a commit
to cuiweixie/optimism
that referenced
this pull request
Oct 22, 2025
Co-authored-by: weixie.cui <weixie.cui@okg.com>
smartcontracts
added a commit
that referenced
this pull request
Feb 22, 2026
Address informational audit findings with improved inline documentation: - Document that guardian pause blocks interop upgrades (acceptable for dev feature) - Document migrate() is exclusively for N pre-interop chains merging into one set - Document that re-migration and partial migration are not supported - Document intentional use of chainSystemConfigs[0] for shared contracts - Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts
added a commit
that referenced
this pull request
Feb 22, 2026
Address informational audit findings with improved inline documentation: - Document that guardian pause blocks interop upgrades (acceptable for dev feature) - Document migrate() is exclusively for N pre-interop chains merging into one set - Document that re-migration and partial migration are not supported - Document intentional use of chainSystemConfigs[0] for shared contracts - Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts
added a commit
that referenced
this pull request
Feb 22, 2026
…16 Add missing @param blueprint NatSpec to OpcmContractRef struct (#2). Add comments about pause blocking interop upgrades (#3). Document migrate() scope limitations and re-migration risks (#7, #15). Update PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional use of chainSystemConfigs[0] for shared contracts (#16). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
…16 (#19271) Add missing @param blueprint NatSpec to OpcmContractRef struct (#2). Add comments about pause blocking interop upgrades (#3). Document migrate() scope limitations and re-migration risks (#7, #15). Update PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional use of chainSystemConfigs[0] for shared contracts (#16). Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes YAS-65 usage of transpiled Simple* contracts.
Talked with @karlfloersch and decided to put them in
rollup-full-node--we could also put in the integrations repo, but our conclusion was if these ever break, we need that to surface as soon as possible.Metadata
Fixes
Contributing Agreement