contracts: add documentation for audit findings #3, #7, #12, #15, #16#19271
Merged
smartcontracts merged 1 commit intodevelopfrom Mar 3, 2026
Merged
contracts: add documentation for audit findings #3, #7, #12, #15, #16#19271smartcontracts merged 1 commit intodevelopfrom
smartcontracts merged 1 commit intodevelopfrom
Conversation
…16 Add missing @param blueprint NatSpec to OpcmContractRef struct (#2). Add comments about pause blocking interop upgrades (#3). Document migrate() scope limitations and re-migration risks (#7, #15). Update PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional use of chainSystemConfigs[0] for shared contracts (#16). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6b4f557 to
8d80aac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19271 +/- ##
===========================================
+ Coverage 76.3% 80.2% +3.8%
===========================================
Files 725 135 -590
Lines 79472 6936 -72536
===========================================
- Hits 60658 5564 -55094
+ Misses 18668 1372 -17296
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mds1
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address informational audit findings with improved inline documentation: