Skip to content

Updating docs formatting#7

Merged
willmeister merged 1 commit intomasterfrom
doc_fixes_and_updates
Feb 17, 2020
Merged

Updating docs formatting#7
willmeister merged 1 commit intomasterfrom
doc_fixes_and_updates

Conversation

@willmeister
Copy link
Copy Markdown

Description

Updating docs content where applicable and format from md to rst.

Contributing Agreement

@willmeister willmeister merged commit d843874 into master Feb 17, 2020
@willmeister willmeister deleted the doc_fixes_and_updates branch February 17, 2020 15:21
snario pushed a commit that referenced this pull request Apr 14, 2021
* Made StateManager usage authenticated

* add safety checker contract

* update safety checker: blacklist revert, KALL + KOPY checks

* lint

* update testrunner: smock safety check, add EM params

* add safety checker constants python script

* set mock targetMessenger to internal

Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
refcell pushed a commit that referenced this pull request Sep 6, 2023
Gas Optimization: optimize _resolveAttestation() and _resolveAttestations()
bap2pecs referenced this pull request in babylonlabs-io/optimism Jul 31, 2024
cuiweixie pushed a commit to cuiweixie/optimism that referenced this pull request Oct 22, 2025
update .gitignore to ignore additional test files and directories
theochap pushed a commit that referenced this pull request Dec 10, 2025
feat(book): FPP Introduction
theochap pushed a commit that referenced this pull request Jan 14, 2026
feat(book): FPP Introduction
theochap pushed a commit that referenced this pull request Jan 15, 2026
theochap pushed a commit that referenced this pull request Jan 21, 2026
smartcontracts added a commit that referenced this pull request Feb 22, 2026
Address informational audit findings with improved inline documentation:
- Document that guardian pause blocks interop upgrades (acceptable for dev feature)
- Document migrate() is exclusively for N pre-interop chains merging into one set
- Document that re-migration and partial migration are not supported
- Document intentional use of chainSystemConfigs[0] for shared contracts
- Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts added a commit that referenced this pull request Feb 22, 2026
Address informational audit findings with improved inline documentation:
- Document that guardian pause blocks interop upgrades (acceptable for dev feature)
- Document migrate() is exclusively for N pre-interop chains merging into one set
- Document that re-migration and partial migration are not supported
- Document intentional use of chainSystemConfigs[0] for shared contracts
- Fix inaccurate PERMIT_ALL_CONTRACTS_INSTRUCTION comment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
smartcontracts added a commit that referenced this pull request Feb 22, 2026
…16

Add missing @param blueprint NatSpec to OpcmContractRef struct (#2).
Add comments about pause blocking interop upgrades (#3). Document
migrate() scope limitations and re-migration risks (#7, #15). Update
PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional
use of chainSystemConfigs[0] for shared contracts (#16).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2026
…16 (#19271)

Add missing @param blueprint NatSpec to OpcmContractRef struct (#2).
Add comments about pause blocking interop upgrades (#3). Document
migrate() scope limitations and re-migration risks (#7, #15). Update
PERMIT_ALL_CONTRACTS_INSTRUCTION comment (#12). Document intentional
use of chainSystemConfigs[0] for shared contracts (#16).

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@0xChin 0xChin mentioned this pull request Mar 9, 2026
OptimismBot pushed a commit that referenced this pull request Mar 10, 2026
Cantina audit finding #7: _decreasePeData unconditionally reset
lastUpdate on every decrease, penalizing partial unstakers by
resetting their staking weight. Now lastUpdate is only reset when
effectiveStake reaches zero.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 16, 2026
* docs(staking): document pause bypass behavior in setAllowedStaker

* fix(staking): only reset lastUpdate on full unstake in _decreasePeData

Cantina audit finding #7: _decreasePeData unconditionally reset
lastUpdate on every decrease, penalizing partial unstakers by
resetting their staking weight. Now lastUpdate is only reset when
effectiveStake reaches zero.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat(staking): implement two-step ownership transfer

Cantina audit finding #8: transferOwnership now nominates a pending
owner who must call acceptOwnership() to finalize the transfer,
preventing irrevocable ownership loss from incorrect addresses.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs(staking): document lastUpdate reset trust assumption in setAllowedStaker

Cantina audit finding #10: when a beneficiary removes a staker from
their allowlist, the staker's lastUpdate is reset via _increasePeData,
losing accumulated staking weight. Document this as an inherent trust
assumption of the delegation model.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: undo version change

* chore: upgrade natspec

* chore: update event emission order

* fix: wrong event args

* chore: add interface comments

* fix: pre-pr

* refactor: make ownable private functions public

* fix: pre-pr

* feat(ownable): reset pending owner on zeroaddress ownership transfer

* refactor: inherit OZ's ownable and use helper contract for mapping storage slot

* fix: ci

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants