host: plumb envoy::api::v2::Locality to HostDescription.#1753
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Sep 27, 2017
Merged
host: plumb envoy::api::v2::Locality to HostDescription.#1753htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Generalizes existing zone support. Fixes envoyproxy#1750. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
mattklein123
left a comment
There was a problem hiding this comment.
Looks good. Small comments.
|
|
||
| /** | ||
| * @return the "zone" of the host (deployment specific). Empty is unknown. | ||
| * @return the locality of the host (deployment specific). This will be empty if unknown. |
Member
There was a problem hiding this comment.
nit: not really empty? Default object? (Not sure what default empty locality really means in object form)
| host.reset(new HostImpl(info_, info_->name() + dst_addr.asString(), std::move(host_ip_port), | ||
| envoy::api::v2::Metadata::default_instance(), 1, "")); | ||
| envoy::api::v2::Metadata::default_instance(), 1, | ||
| envoy::api::v2::Locality())); |
Member
There was a problem hiding this comment.
default_instance() ? (Same in other places)
Member
Author
There was a problem hiding this comment.
Not technically needed, since HostDescriptionImpl makes a copy, but I guess there is some minor performance gain.
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Sep 27, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
…1753) Generalizes existing zone support. Fixes envoyproxy#1750. Signed-off-by: Harvey Tuch htuch@google.com
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Update api sha (envoyproxy#1753) * Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759) * Update envoy sha to bb6762a * update envoy sha to 12c470e * fix authn/integration tasn issue * Update_Dependencies (envoyproxy#1766) * Build addition artifacts with debug symbols (envoyproxy#1767) * Update_Dependencies (envoyproxy#1768)
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Update api sha (envoyproxy#1753) * Add service config forwarded attributes Signed-off-by: Kuat Yessenov <kuat@google.com> * clang-format Signed-off-by: Kuat Yessenov <kuat@google.com> * clang-format google style Signed-off-by: Kuat Yessenov <kuat@google.com> * get rid of boolean Signed-off-by: Kuat Yessenov <kuat@google.com> * add a test Signed-off-by: Kuat Yessenov <kuat@google.com> * update api Signed-off-by: Kuat Yessenov <kuat@google.com> * fix repo commit Signed-off-by: Kuat Yessenov <kuat@google.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…roxy#1780) * Update api sha (envoyproxy#1753) * Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759) * Update envoy sha to bb6762a * update envoy sha to 12c470e * fix authn/integration tasn issue * Update_Dependencies (envoyproxy#1766) * Build addition artifacts with debug symbols (envoyproxy#1767) * Update_Dependencies (envoyproxy#1768) * Update api version to b549a3f770c833bad8f4f3871768c43960ab7309 (envoyproxy#1769) * Update istio.deps * Update repositories.bzl * Update istio.deps * Update istio.deps * Update Envoy to c2baf34. (envoyproxy#1773) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update api sha to 8d67e57e3612dae1a3423795bce93a372cfe4fa4 (envoyproxy#1775) * revert api sha change
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Move python_tests workflow to Engflow's remote execution and make build times >10x better We also need to update the Docker image to one of the latest in envoy-build-ubuntu so that it includes envoyproxy/envoy-build-tools#144. The image can be found at: https://hub.docker.com/layers/envoyproxy/envoy-build-ubuntu/b51ac7a0f2cb5dd729984a379a301ce029ac765d/images/sha256-239015d203837f2bdcd4cfdd710d7db60acc3fb1f002f1c926b92b42c59afdd6?context=explore Risk Level: Low Testing: See python_tests workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Move python_tests workflow to Engflow's remote execution and make build times >10x better We also need to update the Docker image to one of the latest in envoy-build-ubuntu so that it includes envoyproxy/envoy-build-tools#144. The image can be found at: https://hub.docker.com/layers/envoyproxy/envoy-build-ubuntu/b51ac7a0f2cb5dd729984a379a301ce029ac765d/images/sha256-239015d203837f2bdcd4cfdd710d7db60acc3fb1f002f1c926b92b42c59afdd6?context=explore Risk Level: Low Testing: See python_tests workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This upgrades tool versions in tools/go.mod. Most notable change is that due to the golangci-lint upgrade, this renames the internal/tracing/api package to internal/tracing/tracingapi. --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes existing zone support.
Fixes #1750.
Signed-off-by: Harvey Tuch htuch@google.com