Add python3.8-dev to the Ubuntu image#144
Merged
phlax merged 4 commits intoenvoyproxy:mainfrom Sep 8, 2021
Merged
Conversation
Member
|
hi @lfpino i dont use this image myself, but in my local dev image i have python3.8-dev enabled to allow installing deps that require compilation, so seems a good change to me would you mind fixing dco - i think the other ci fail was a flake so i have rerun the job |
Member
|
ci breakage is unrelated, i opened a pr here #145 to address |
The python headers are necessary to build envoy-mobile with remote build execution Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Contributor
Author
|
@phlax thanks for taking a look! I fixed the DCO now |
phlax
approved these changes
Sep 8, 2021
htuch
pushed a commit
that referenced
this pull request
Sep 8, 2021
[skip ci] Add python3.8-dev to the Ubuntu image (#144) * Add python3.8-dev to the Ubuntu image The python headers are necessary to build envoy-mobile with remote build execution Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
goaway
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Sep 13, 2021
Description: Move python_tests workflow to Engflow's remote execution and make build times >10x better We also need to update the Docker image to one of the latest in envoy-build-ubuntu so that it includes envoyproxy/envoy-build-tools#144. The image can be found at: https://hub.docker.com/layers/envoyproxy/envoy-build-ubuntu/b51ac7a0f2cb5dd729984a379a301ce029ac765d/images/sha256-239015d203837f2bdcd4cfdd710d7db60acc3fb1f002f1c926b92b42c59afdd6?context=explore Risk Level: Low Testing: See python_tests workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 28, 2022
Description: Move python_tests workflow to Engflow's remote execution and make build times >10x better We also need to update the Docker image to one of the latest in envoy-build-ubuntu so that it includes envoyproxy/envoy-build-tools#144. The image can be found at: https://hub.docker.com/layers/envoyproxy/envoy-build-ubuntu/b51ac7a0f2cb5dd729984a379a301ce029ac765d/images/sha256-239015d203837f2bdcd4cfdd710d7db60acc3fb1f002f1c926b92b42c59afdd6?context=explore Risk Level: Low Testing: See python_tests workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Nov 29, 2022
Description: Move python_tests workflow to Engflow's remote execution and make build times >10x better We also need to update the Docker image to one of the latest in envoy-build-ubuntu so that it includes envoyproxy/envoy-build-tools#144. The image can be found at: https://hub.docker.com/layers/envoyproxy/envoy-build-ubuntu/b51ac7a0f2cb5dd729984a379a301ce029ac765d/images/sha256-239015d203837f2bdcd4cfdd710d7db60acc3fb1f002f1c926b92b42c59afdd6?context=explore Risk Level: Low Testing: See python_tests workflow Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python headers are necessary to build envoy-mobile with remote build execution