ubuntu/arm: Fix cmake-data dependency#145
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Sep 8, 2021
Merged
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Sep 7, 2021
|
|
||
| # todo: remove this once kitware repo is fixed | ||
| if [[ "$ARCH" == "aarch64" ]]; then | ||
| PACKAGES+=("cmake-data=3.10.2-1ubuntu2.18.04.1") |
Member
Author
There was a problem hiding this comment.
@lizan there has been a new release of the kitware packages and it has broken ci
this fixes ci, but not sure its the correct fix - i checked through the kitware changelogs, but its not clear what was broken, so i had no way of telling why this was added
checking the last successful build, i see that on arm64 it was using the ubuntu-updates versions of cmake and cmake-data
...so i guess the alternative would be to pin both if that is still required on arm64
Member
Author
There was a problem hiding this comment.
seems like i added the not so helpful comment about kitware, so apologies ill try and rem to add more helpful info in future
either way, im thinking that this means that this fix should be good
mattklein123
approved these changes
Sep 8, 2021
htuch
pushed a commit
that referenced
this pull request
Sep 8, 2021
[skip ci] ubuntu/arm: Fix cmake-data dependency (#145) Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.