CI: Publish tags to Dockerhub#1768
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 28, 2017
Merged
Conversation
Contributor
Author
|
We're blocked by the DCO check, which I've opened an issue for investigation over at dcoapp/app#39 |
Signed-off-by: bndw <benjamindwoodward@gmail.com> Author: bndw <benjamindwoodward@gmail.com>
Contributor
Author
|
@mattklein123 DCO check is resolved and all checks have passed (except the mac build which timed out?) Lmk if there's anything else on this one. |
.circleci/config.yml
Outdated
| - run: ci/do_circle_ci.sh bazel.release | ||
| - setup_remote_docker | ||
| - run: ci/docker_push.sh | ||
| - deploy: |
Member
There was a problem hiding this comment.
any reason to use deploy here vs. run?
Contributor
Author
There was a problem hiding this comment.
deploy was what the examples used, but run will work and read better.
Signed-off-by: bndw <benjamindwoodward@gmail.com>
Contributor
Author
|
Fixes #1742 |
mattklein123
approved these changes
Sep 28, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
Once this merges we can do a test tag to try it out.
Contributor
Author
|
Sounds good, just need to make sure the tag follows the existing convention (prefixed with |
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
Signed-off-by: bndw <benjamindwoodward@gmail.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Update api sha (envoyproxy#1753) * Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759) * Update envoy sha to bb6762a * update envoy sha to 12c470e * fix authn/integration tasn issue * Update_Dependencies (envoyproxy#1766) * Build addition artifacts with debug symbols (envoyproxy#1767) * Update_Dependencies (envoyproxy#1768)
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…roxy#1780) * Update api sha (envoyproxy#1753) * Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759) * Update envoy sha to bb6762a * update envoy sha to 12c470e * fix authn/integration tasn issue * Update_Dependencies (envoyproxy#1766) * Build addition artifacts with debug symbols (envoyproxy#1767) * Update_Dependencies (envoyproxy#1768) * Update api version to b549a3f770c833bad8f4f3871768c43960ab7309 (envoyproxy#1769) * Update istio.deps * Update repositories.bzl * Update istio.deps * Update istio.deps * Update Envoy to c2baf34. (envoyproxy#1773) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update api sha to 8d67e57e3612dae1a3423795bce93a372cfe4fa4 (envoyproxy#1775) * revert api sha change
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This ensures that logs and log events emitted early on in engine startup makes it through the attached logger. Risk Level: Medium Testing: Existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This ensures that logs and log events emitted early on in engine startup makes it through the attached logger. Risk Level: Medium Testing: Existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old PR: #1743
Signed-off-by: bndw benjamindwoodward@gmail.com