redis: fix pipeline timeout logic#1773
Merged
danielhochman merged 1 commit intomasterfrom Sep 28, 2017
Merged
Conversation
Signed-off-by: Daniel Hochman <dhochman@lyft.com>
45a25fd to
c41e8de
Compare
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
Signed-off-by: Daniel Hochman <dhochman@lyft.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…roxy#1780) * Update api sha (envoyproxy#1753) * Release-0.8: Update envoy sha to bb6762a (envoyproxy#1759) * Update envoy sha to bb6762a * update envoy sha to 12c470e * fix authn/integration tasn issue * Update_Dependencies (envoyproxy#1766) * Build addition artifacts with debug symbols (envoyproxy#1767) * Update_Dependencies (envoyproxy#1768) * Update api version to b549a3f770c833bad8f4f3871768c43960ab7309 (envoyproxy#1769) * Update istio.deps * Update repositories.bzl * Update istio.deps * Update istio.deps * Update Envoy to c2baf34. (envoyproxy#1773) Signed-off-by: Piotr Sikora <piotrsikora@google.com> * Update api sha to 8d67e57e3612dae1a3423795bce93a372cfe4fa4 (envoyproxy#1775) * revert api sha change
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Turning up propercasing for HTTP/1.1, now avoiding the SAN issues. Description: Risk Level: Testing: Docs Changes: Release Notes: Fixes #1558 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Turning up propercasing for HTTP/1.1, now avoiding the SAN issues. Description: Risk Level: Testing: Docs Changes: Release Notes: Fixes #1558 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** Fixes the KubernetesContainerSpec link in the generated API docs by mapping it to the Envoy Gateway extension-types reference and updating the current API doc link. **Related Issues/PRs (if applicable)** Fixes #1718 --------- Signed-off-by: jonasHanhan <zqhmusic121@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Redis pipelines, this ensures that we only boost the timeout when first command is written to the connection (
makeRequest).We also reset the timeout whenever we receive a response (
onRespValue) to give Redis time to respond to each operation with the full op timeout.Before we would boost the timeout on each incoming command even if the connection was going to timeout with no response on the first command. This resulted in long-tail timeouts well beyond the configured op timeout.