Fix race condition in TEST(FileSystemImpl, flushToLogFileOnDemand)#1776
Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom Sep 30, 2017
Merged
Fix race condition in TEST(FileSystemImpl, flushToLogFileOnDemand)#1776mattklein123 merged 2 commits intoenvoyproxy:masterfrom
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
htuch
previously approved these changes
Sep 29, 2017
| .WillOnce(Invoke([](int, const void*, size_t num_bytes) -> ssize_t { return num_bytes; })); | ||
| file.write("prime-it"); | ||
| file.flush(); | ||
| unsigned expected_writes = 1; |
Member
There was a problem hiding this comment.
Nit: uint32_t (or some other fixed size type).
Member
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for fixing. Looks good. Small nit.
| .WillOnce(Invoke([](int, const void*, size_t num_bytes) -> ssize_t { return num_bytes; })); | ||
| file.write("prime-it"); | ||
| file.flush(); | ||
| unsigned expected_writes = 1; |
Member
There was a problem hiding this comment.
nit: prefer explicitly sized variable types such as uint64_t.
Signed-off-by: Greg Greenway <ggreenway@apple.com>
mattklein123
approved these changes
Sep 30, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
…nvoyproxy#1776) Signed-off-by: Greg Greenway <ggreenway@apple.com>
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Update api sha (envoyproxy#1753) * Add service config forwarded attributes Signed-off-by: Kuat Yessenov <kuat@google.com> * clang-format Signed-off-by: Kuat Yessenov <kuat@google.com> * clang-format google style Signed-off-by: Kuat Yessenov <kuat@google.com> * get rid of boolean Signed-off-by: Kuat Yessenov <kuat@google.com> * add a test Signed-off-by: Kuat Yessenov <kuat@google.com> * update api Signed-off-by: Kuat Yessenov <kuat@google.com> * fix repo commit Signed-off-by: Kuat Yessenov <kuat@google.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Greenway ggreenway@apple.com