Skip to content

[Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch#99023

Merged
alexwizp merged 5 commits intoelastic:masterfrom
alexwizp:vega_93770
Aug 30, 2021
Merged

[Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch#99023
alexwizp merged 5 commits intoelastic:masterfrom
alexwizp:vega_93770

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented May 3, 2021

Part of: #93770

This PR is a part of #93770 for src/plugins/vis_type_vega/server/usage_collector/get_usage_collector.ts
What was done:

  • Size parameter was changed from 10000 to 1000
  • Code was refactored to use soClient instead of esClient
  • The paging is used through the soClient.createPointInTimeFinder method
  • Code was optimized, extra cycles were removed

@alexwizp alexwizp changed the title [Vega] Expensive queries are causing unnecessary load and delays on E… [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch May 3, 2021
@alexwizp alexwizp requested a review from afharo May 3, 2021 09:40
@alexwizp alexwizp self-assigned this May 3, 2021
@alexwizp alexwizp added v7.14.0 Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes v8.0.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels May 3, 2021
@alexwizp alexwizp marked this pull request as ready for review May 3, 2021 09:41
@alexwizp alexwizp requested a review from a team May 3, 2021 09:41
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Copy Markdown
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@alexwizp
Copy link
Copy Markdown
Contributor Author

@afharo @stratoula, blocker issue was fixed - PR was rebased to latest master, tested locally and ready to your final review

@alexwizp
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 9f5a936 into elastic:master Aug 30, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 30, 2021
…lasticsearch (elastic#99023)

* [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch

Part of: elastic#93770

* Update get_usage_collector.test.ts

* add namespaces: ['*']

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this pull request Aug 30, 2021
…lasticsearch (#99023) (#110448)

* [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch

Part of: #93770

* Update get_usage_collector.test.ts

* add namespaces: ['*']

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants