[Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch#98903
Merged
alexwizp merged 13 commits intoelastic:masterfrom Aug 30, 2021
Merged
[Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch#98903alexwizp merged 13 commits intoelastic:masterfrom
alexwizp merged 13 commits intoelastic:masterfrom
Conversation
…s on Elasticsearch Part of elastic#93770
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
Adding @lukeelmers as a reviewer since he created the PIT API and will have better insights in whether a |
Contributor
Author
|
@afharo thanks, if @lukeelmers agrees with these changes, I'll update the other telemetries (related to |
lukeelmers
reviewed
Apr 30, 2021
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
whether a perPage: 1000 is low enough :)
I think a size of 1000 is probably fine here. It's a tradeoff between network communication overhead and payload size. AFAIK the visualization SOs are typically not huge in their size, so I'm sure you can get away with retrieving 1000 at a time. FWIW the default size for point in time finder is 1000, and this is what we use in our code for handling SO exports.
alexwizp
commented
Apr 30, 2021
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
This was referenced May 3, 2021
Merged
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@afharo @stratoula, blocker issue was fixed - PR was rebased to latest master, tested locally and ready to your final review |
Contributor
|
@elasticmachine merge upstream |
stratoula
approved these changes
Aug 30, 2021
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Code LGTM, tested it locally and works fine. Please merge in case of green CI
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @alexwizp |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 30, 2021
…s on Elasticsearch (elastic#98903) * [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch Part of elastic#93770 * remove extra cycles * fix PR comments * fix finder.close * code cleanup * add namespaces: ['*'], * fix jest Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 30, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (120 commits) [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218) skip flaky suite (elastic#98463) skip flaky suite (elastic#108633) [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903) fixes failing tests (elastic#110436) [TSVB] Remove deprecated `IFieldType` (elastic#110404) [Lens] Remove deprecated `IFieldType` (elastic#109825) [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023) [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031) [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914) Don't add split part of UI if we have one series (elastic#109483) [Discover] Migrate angular routing to react router (elastic#107042) [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282) [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053) [canvas] Fix image argument form issues (elastic#109767) Fix asset in Pitch template (elastic#109742) chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265) chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269) [Fleet] Fix upgrade link in Fleet policy table (elastic#110228) [ML] APM Latency Correlations: Fix empty state (elastic#109813) ... # Conflicts: # src/plugins/data/common/query/timefilter/types.ts
alexwizp
added a commit
that referenced
this pull request
Aug 30, 2021
…s on Elasticsearch (#98903) (#110457) * [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch Part of #93770 * remove extra cycles * fix PR comments * fix finder.close * code cleanup * add namespaces: ['*'], * fix jest Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #93770
Summary
This PR is a part of #93770 for
src/plugins/vis_type_table/server/usage_collector/get_stats.tsWhat was done:
Sizeparameter was changed from10000to1000soClient.createPointInTimeFindermethod