[Discover] Migrate angular routing to react router#107042
Merged
kertal merged 60 commits intoelastic:masterfrom Aug 30, 2021
Merged
[Discover] Migrate angular routing to react router#107042kertal merged 60 commits intoelastic:masterfrom
kertal merged 60 commits intoelastic:masterfrom
Conversation
78001c9 to
2ad5f68
Compare
kertal
reviewed
Aug 4, 2021
kertal
reviewed
Aug 19, 2021
src/plugins/discover/public/application/apps/context/context_app_route.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
Aug 19, 2021
dimaanj
reviewed
Aug 19, 2021
src/plugins/discover/public/application/apps/context/context_app_route.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/apps/context/context_app_route.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/apps/not_found/not_found_route.tsx
Show resolved
Hide resolved
src/plugins/discover/public/application/apps/main/discover_main_route.tsx
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Aug 26, 2021
Member
kertal
left a comment
There was a problem hiding this comment.
Last issue fixed, congrats! Huge step before removing last Angular stuff 🥳 ! Tested over the weeks with Chrome, Firefox, Safari. Works as expected
Member
|
@elasticmachine merge upstream |
dimaanj
approved these changes
Aug 30, 2021
Contributor
dimaanj
left a comment
There was a problem hiding this comment.
LGTM!, tested in Chrome.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 30, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsasync chunk count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
that referenced
this pull request
Aug 30, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 30, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (120 commits) [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218) skip flaky suite (elastic#98463) skip flaky suite (elastic#108633) [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903) fixes failing tests (elastic#110436) [TSVB] Remove deprecated `IFieldType` (elastic#110404) [Lens] Remove deprecated `IFieldType` (elastic#109825) [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023) [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031) [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914) Don't add split part of UI if we have one series (elastic#109483) [Discover] Migrate angular routing to react router (elastic#107042) [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282) [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053) [canvas] Fix image argument form issues (elastic#109767) Fix asset in Pitch template (elastic#109742) chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265) chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269) [Fleet] Fix upgrade link in Fleet policy table (elastic#110228) [ML] APM Latency Correlations: Fix empty state (elastic#109813) ... # Conflicts: # src/plugins/data/common/query/timefilter/types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #104942.
This change replaces legacy Angular routing with the React router. Functionality-wise, there should be no new changes.
Testing
When testing this, some things to look out for:
Basically anything that deals with navigation or a state update is a good candidate to test.
Checklist
Delete any items that are not applicable to this PR.