TSVB metrics that have legend (percentiles and percentile ranks) don't resize the text size properly#109483
Merged
VladLasitsa merged 2 commits intoelastic:masterfrom Aug 30, 2021
Merged
Conversation
alexwizp
approved these changes
Aug 23, 2021
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
LGTM! Thank you, tested locally
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
Aug 30, 2021
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Code LGTM, I tested it locally and it works fine
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Aug 30, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
VladLasitsa
added a commit
that referenced
this pull request
Aug 30, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 30, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (120 commits) [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218) skip flaky suite (elastic#98463) skip flaky suite (elastic#108633) [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903) fixes failing tests (elastic#110436) [TSVB] Remove deprecated `IFieldType` (elastic#110404) [Lens] Remove deprecated `IFieldType` (elastic#109825) [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023) [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031) [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914) Don't add split part of UI if we have one series (elastic#109483) [Discover] Migrate angular routing to react router (elastic#107042) [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282) [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053) [canvas] Fix image argument form issues (elastic#109767) Fix asset in Pitch template (elastic#109742) chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265) chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269) [Fleet] Fix upgrade link in Fleet policy table (elastic#110228) [ML] APM Latency Correlations: Fix empty state (elastic#109813) ... # Conflicts: # src/plugins/data/common/query/timefilter/types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #102328
Summary
Metric should have 3 row only if we split it. In this case we have several metrics and we add min-height and min-width properties which don't allow shrink less then defined value. It was did as part of this #33245. For Percentiles and Percentile ranks in code we always split chart even if we have only one series. Because of this you can see 3 row. I fixed it and now we split chart if we have more that one series. Because of this now you can see 2 row for percentiles if don't split it by procent.
New.Dashboard.-.Elastic1.mp4