Skip to content

[Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards#110282

Merged
parkiino merged 2 commits intoelastic:masterfrom
parkiino:bug/event-filters-missing-divider
Aug 30, 2021
Merged

[Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards#110282
parkiino merged 2 commits intoelastic:masterfrom
parkiino:bug/event-filters-missing-divider

Conversation

@parkiino
Copy link
Copy Markdown
Contributor

@parkiino parkiino commented Aug 26, 2021 •
edited
Loading

Summary

  • Fixes a bug where the styles were not being applied to the event filters page, causing the cards to be right next to each other without horizontal spacers

Screenshots

BEFORE
image

AFTER
image

@parkiino parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 26, 2021
@parkiino parkiino requested a review from a team as a code owner August 26, 2021 16:14
@parkiino parkiino requested review from joeypoon and pzl August 26, 2021 16:14
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 26, 2021

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 26, 2021

Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint)

@parkiino parkiino mentioned this pull request Aug 26, 2021
Closed
pzl
pzl approved these changes Aug 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applying the "...rest" to the wrapping element fixes the styles, then, I suppose?

h'okay 👍

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 29, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / "before all" hook for "should not allow user with read only privileges to attach alerts to cases".Alerts timeline Privileges: read only "before all" hook for "should not allow user with read only privileges to attach alerts to cases"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Alerts timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:6161/__cypress/tests?p=cypress/support/index.js:380:13)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +37.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit 079fc9a into elastic:master Aug 30, 2021
@parkiino parkiino deleted the bug/event-filters-missing-divider branch August 30, 2021 02:17
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2021
@parkiino @kibanamachine
[Security Solution][Endpoint][Event Filters] Fixes missing spacers be…
018d718 
…tween event filters cards (elastic#110282)
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2021
@parkiino @kibanamachine
[Security Solution][Endpoint][Event Filters] Fixes missing spacers be…
4280b09 
…tween event filters cards (elastic#110282)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 30, 2021

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 30, 2021
@kibanamachine @parkiino
[Security Solution][Endpoint][Event Filters] Fixes missing spacers be…
709bc13 
…tween event filters cards (#110282) (#110427)

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 30, 2021
@kibanamachine @parkiino
[Security Solution][Endpoint][Event Filters] Fixes missing spacers be…
7366172 
…tween event filters cards (#110282) (#110426)

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
fcc34f0 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pzl pzl pzl approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon

+1 more reviewer

@kevinlog kevinlog kevinlog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@parkiino @elasticmachine @kibanamachine @pzl @kevinlog