[Telemetry] Add method to enable endpoint security data usage example#80940
Merged
Bamieh merged 9 commits intoelastic:masterfrom Oct 20, 2020
Merged
Conversation
pjhampton
reviewed
Oct 19, 2020
| initTelemetry( | ||
| { | ||
| usageCollection: plugins.usageCollection, | ||
| telemetryManagementSection: plugins.telemetryManagementSection, |
Contributor
There was a problem hiding this comment.
This seems much more simple than what we initially discussed. Great approach!
Contributor
|
Can this not go out in |
Contributor
Author
|
@pjhampton whoops. fixed |
TinaHeiligers
approved these changes
Oct 19, 2020
Contributor
TinaHeiligers
left a comment
There was a problem hiding this comment.
code review only,
LGTM
|
|
||
| it('renders as expected', () => { | ||
| const onQueryMatchChange = jest.fn(); | ||
| const isSecurityExampleEnabled = jest.fn().mockReturnValue(true); |
Contributor
There was a problem hiding this comment.
Just a nit, but might be more DRY to just set these (isSecurityExampleEnabled && onQueryMatchChange) in a beforeEach at the top of the relevant describe blocks since they don't seem to change for any of the tests
Contributor
Author
There was a problem hiding this comment.
I usually prefer to keep them like that in the tests to make it easier to read what is happening. each it has almost all it needs encapsulated inside it, so you can update/refactor the tests more easily if needed in the future.
| ) : ( | ||
| <FormattedMessage | ||
| id="telemetry.seeExampleOfClusterData" | ||
| defaultMessage="See example of the {clusterData} that we collect." |
Contributor
There was a problem hiding this comment.
Missed pluralization of 'example', I think? "See an example of...." or "See examples of...." ?
Contributor
Author
There was a problem hiding this comment.
Its just 1 example of the clusterData. examples in the case we have 2 examples 1 for clusterData and the other for security solutions. I might be wrong but that was my reasning behind it
michaelolo24
approved these changes
Oct 19, 2020
Contributor
michaelolo24
left a comment
There was a problem hiding this comment.
Looks good, really just the minor pluralization thing in telemetry_management_section.tsx
rylnd
approved these changes
Oct 19, 2020
Contributor
rylnd
left a comment
There was a problem hiding this comment.
Desk tested this with securitySolution both enabled and disabled. LGTM 👍
…point_security_example_setup_method
XavierM
approved these changes
Oct 19, 2020
XavierM
reviewed
Oct 19, 2020
| advancedSettings.component.register( | ||
| advancedSettings.component.componentType.PAGE_FOOTER_COMPONENT, | ||
| telemetryManagementSectionWrapper(telemetryService), | ||
| telemetryManagementSectionWrapper(telemetryService, this.shouldShowSecuritySolutionExample), |
Contributor
There was a problem hiding this comment.
I am wondering if you really need to pass a function here, I feel like you can just pass this.showSecuritySolutionExample
Contributor
Author
There was a problem hiding this comment.
Since booleans are copied and not passed by reference; we need a function to get the latest value of the variable. Passing it as a value directly might cause unexpected bugs especially since most kibana does not referesh between pages now.
…point_security_example_setup_method
…point_security_example_setup_method
Contributor
💛 Build succeeded, but was flaky
Test FailuresX-Pack APM API integration tests (basic).x-pack/test/apm_api_integration/basic/tests/correlations/slow_durations·ts.APM specs (basic) Correlations Slow durations with different scoring returns buckets for each scoreStandard OutStack TraceMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
This was referenced Oct 20, 2020
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Oct 20, 2020
…elastic#80940) # Conflicts: # x-pack/plugins/security_solution/public/plugin.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 20, 2020
* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...
Bamieh
added a commit
that referenced
this pull request
Oct 20, 2020
Bamieh
added a commit
that referenced
this pull request
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79859