Skip to content

[Alerting] Improve toast when alert is created#80327

Merged
sorenlouv merged 4 commits intoelastic:masterfrom
sorenlouv:improve-alert-toast
Oct 20, 2020
Merged

[Alerting] Improve toast when alert is created#80327
sorenlouv merged 4 commits intoelastic:masterfrom
sorenlouv:improve-alert-toast

Conversation

@sorenlouv
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv commented Oct 13, 2020 •
edited
Loading

Closes #80142

The current toast is not very informative. It doesn't mention that an alert was created and I was genuinely confused whether I had created an alert, or something else (I was testing permissions and was seeing some odd behaviour with actions and having a better toast message would have helped me understand what was going on).

Before

@sorenlouv sorenlouv requested a review from a team as a code owner October 13, 2020 12:27
pmuellr
pmuellr reviewed Oct 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree the toast should indicate an alert is being created. Looks like there is also a button with a "Save" label on that form - should we change that to "Create"? The error message on creation in that form is "Cannot create alert", which seems like it's already create-centered ...

Also wondering if we should add the name back to the message - at some point someone thought there was value in doing that.

Generally, defer to @gchaps for things like this tho ...

@sorenlouv
Copy link
Copy Markdown
Contributor Author

sorenlouv commented Oct 13, 2020

The error message on creation in that form is "Cannot create alert", which seems like it's already create-centered ...

Yeah, that's what I noticed too. This seems to indicate that it's always about creating (a new) alert:

      const newAlert = await createAlert({ http, alert });

@pmuellr
Copy link
Copy Markdown
Contributor

pmuellr commented Oct 13, 2020

Ya, there's a separate path for "update", which uses "Save" in it's messaging, which seems fine ... perhaps there was some copy-pasta between these, or something

@sorenlouv sorenlouv force-pushed the improve-alert-toast branch from 5f5eb3a to 0d391c5 Compare October 19, 2020 19:07
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 19, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
triggersActionsUi 1.5MB 1.5MB +8.0B

History

  • 💔 Build #81567 failed 5f5eb3a7ba1a6f9d2ac1356dd4597c93d2c337a8
  • 💔 Build #81296 failed 0230769f01122cd4d38f37c26da0e143e2381ce4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Copy Markdown
Contributor Author

sorenlouv commented Oct 19, 2020

@pmuellr Okay to merge?

@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Oct 20, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2020

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr pmuellr added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 20, 2020
pmuellr
pmuellr approved these changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sqren!

@pmuellr
Copy link
Copy Markdown
Contributor

pmuellr commented Oct 20, 2020

@sqren ya, go ahead and merge. For alerting PRs, we usually require two reviews, except for super simple PRs - and I think this is one :-)

@sorenlouv sorenlouv merged commit 35e21db into elastic:master Oct 20, 2020
@sorenlouv sorenlouv deleted the improve-alert-toast branch October 20, 2020 14:20
@sorenlouv sorenlouv mentioned this pull request Oct 20, 2020
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Oct 20, 2020
@sorenlouv
[Alerting] Improve toast when alert is created (elastic#80327)
9e017ad
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
@gmmorris
Merge branch 'master' into task-manager/health-refactored
600863f 
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
sorenlouv added a commit that referenced this pull request Oct 20, 2020
@sorenlouv
[Alerting] Improve toast when alert is created (#80327) (#81175)
a5e7753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmuellr pmuellr pmuellr approved these changes

+1 more reviewer

@gchaps gchaps gchaps left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Alerting release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Improve "Alert created" toast

5 participants

@sorenlouv @pmuellr @kibanamachine @elasticmachine @gchaps