Skip to content

[UX] Add empty states#80904

Merged
justinkambic merged 5 commits intoelastic:masterfrom
justinkambic:ux_empty-states
Oct 20, 2020
Merged

[UX] Add empty states#80904
justinkambic merged 5 commits intoelastic:masterfrom
justinkambic:ux_empty-states

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

Summary

Resolves #79419.

Adds initial empty states for when data is not present in the UX dashboard metrics and vitals fields.

Before

image

After

image

Testing this PR

  • Load up an empty Kibana/ES stack and ensure that the fields display N/A and greyed-out states in place of stacked core vitals fields, as seen in the "After" image above.

  • Compare against OBLT and make sure that the metrics and vitals continue to display as designed:
    image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11.0 labels Oct 16, 2020
@justinkambic justinkambic requested a review from a team as a code owner October 16, 2020 19:15
@justinkambic justinkambic self-assigned this Oct 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Oct 16, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Oct 16, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 3.3MB 3.3MB +535.0B

page load bundle size

id before after diff
observability 72.9KB 73.3KB +420.0B

History

  • 💔 Build #82535 failed 3d1508acc7a68be4b7da5d3ed4c63925622c7fc2
  • 💔 Build #82278 failed d6515bae773e23fd6235ebb039de0caae45a6033

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit d2c776d into elastic:master Oct 20, 2020
justinkambic added a commit to justinkambic/kibana that referenced this pull request Oct 20, 2020
* Add empty state for user experience metrics.

* Add empty state for page load duration metrics.

* Add empty state for core web vitals.

* Fix bug injected by these changes.

* Add a test.
justinkambic added a commit to justinkambic/kibana that referenced this pull request Oct 20, 2020
* Add empty state for user experience metrics.

* Add empty state for page load duration metrics.

* Add empty state for core web vitals.

* Fix bug injected by these changes.

* Add a test.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
justinkambic added a commit that referenced this pull request Oct 20, 2020
* Add empty state for user experience metrics.

* Add empty state for page load duration metrics.

* Add empty state for core web vitals.

* Fix bug injected by these changes.

* Add a test.
justinkambic added a commit that referenced this pull request Oct 20, 2020
* Add empty state for user experience metrics.

* Add empty state for page load duration metrics.

* Add empty state for core web vitals.

* Fix bug injected by these changes.

* Add a test.
@justinkambic
Copy link
Copy Markdown
Contributor Author

@justinkambic justinkambic deleted the ux_empty-states branch October 20, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] Core web vitals should have empty state

4 participants