[Alerting] Add scoped cluster client to alerts and actions services by justinkambic · Pull Request #80794 · elastic/kibana

justinkambic · 2020-10-16T03:10:31Z

Summary

As part of #80116 we discovered that one of the alerts required usage of IndexPatternsFetcher. Presently, the alert/action services do not provide a scoped client for this purpose. This is already on the alerting team's roadmap, so it will unblock the aforementioned patch and resolve the roadmap issue.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-10-16T03:10:34Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

justinkambic · 2020-10-16T12:32:41Z

@elasticmachine merge upstream

mattkime · 2020-10-19T17:51:08Z

@elasticmachine merge upstream

pmuellr

LGTM, simple enough :-)

It would be good to have some tests though - I think maybe we can just change one of our existing functional tests to use the new client - would be good enough for me. Eg, one like this:

kibana/x-pack/test/alerting_api_integration/common/fixtures/plugins/alerts/server/alert_types.ts

Lines 79 to 89 in 8b6b1aa

    
           await services.callCluster('index', { 
        
             index: params.index, 
        
             refresh: 'wait_for', 
        
             body: { 
        
               state, 
        
               params, 
        
               reference: params.reference, 
        
               source: 'alert:test.always-firing', 
        
               alertInfo, 
        
             }, 
        
           });

mikecote

Changes LGTM. Agreed, it could use a test, happy to help

kibanamachine · 2020-10-20T01:03:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9e284d0

Metrics [docs]

✅ unchanged

History

💚 Build #82538 succeeded 51ffcf4289a962dd2bc3f79ea98b26d2fa35948b
💚 Build #82138 succeeded 5df3184adc3ab141ed15e4625cdeceeb5f1a5a4d
💔 Build #82083 failed ce643a6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris · 2020-10-20T10:53:48Z

LGTM once a test is added, thanks for doing this!

That said, please remove the resolves above as this doesn't actually resolve the issue- once the legacy client is removed, then we can consider #50247 resolved. :)
It is still worth keeping a reference to #50247 in the desc to explain the context.

Thanks ❤️

pmuellr

LGTM, thanks for updating that function test to use the new client!

…lastic#80794) * Add scoped cluster client to alerts and actions services. * Modify functional test to use new ES client.

* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...

…80794) (#81167) * Add scoped cluster client to alerts and actions services. * Modify functional test to use new ES client.

justinkambic · 2020-10-20T15:56:23Z

Backported to:
7.x/7.11.0 742ba6e
#81167

Add scoped cluster client to alerts and actions services.

ce643a6

justinkambic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 labels Oct 16, 2020

justinkambic requested a review from a team as a code owner October 16, 2020 03:10

pmuellr requested changes Oct 19, 2020

View reviewed changes

mikecote self-requested a review October 19, 2020 18:54

mikecote approved these changes Oct 19, 2020

View reviewed changes

justinkambic added 2 commits October 19, 2020 19:18

Merge branch 'master' into alerting_scoped-cluster-client

87d72f7

Modify functional test to use new ES client.

9e284d0

justinkambic force-pushed the alerting_scoped-cluster-client branch from 51ffcf4 to 9e284d0 Compare October 19, 2020 23:24

pmuellr approved these changes Oct 20, 2020

View reviewed changes

justinkambic merged commit cc43b14 into elastic:master Oct 20, 2020

justinkambic mentioned this pull request Oct 20, 2020

[7.x] [Alerting] Add scoped cluster client to alerts and actions services (#80794) #81167

Merged

mikecote mentioned this pull request Oct 20, 2020

[SIEM][Detection Engine] Meta issue for alerting needs #50222

Closed

justinkambic added a commit that referenced this pull request Oct 20, 2020

[Alerting] Add scoped cluster client to alerts and actions services (#…

742ba6e

…80794) (#81167) * Add scoped cluster client to alerts and actions services. * Modify functional test to use new ES client.

justinkambic deleted the alerting_scoped-cluster-client branch October 20, 2020 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] Add scoped cluster client to alerts and actions services#80794

[Alerting] Add scoped cluster client to alerts and actions services#80794
justinkambic merged 3 commits intoelastic:masterfrom
justinkambic:alerting_scoped-cluster-client

justinkambic commented Oct 16, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Oct 16, 2020

Uh oh!

justinkambic commented Oct 16, 2020

Uh oh!

mattkime commented Oct 19, 2020

Uh oh!

pmuellr left a comment

Uh oh!

mikecote left a comment

Uh oh!

kibanamachine commented Oct 20, 2020

Uh oh!

gmmorris commented Oct 20, 2020

Uh oh!

pmuellr left a comment

Uh oh!

justinkambic commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	await services.callCluster('index', {
	index: params.index,
	refresh: 'wait_for',
	body: {
	state,
	params,
	reference: params.reference,
	source: 'alert:test.always-firing',
	alertInfo,
	},
	});

Conversation

justinkambic commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 16, 2020

Uh oh!

justinkambic commented Oct 16, 2020

Uh oh!

mattkime commented Oct 19, 2020

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 20, 2020

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

gmmorris commented Oct 20, 2020

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Oct 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

justinkambic commented Oct 16, 2020 •

edited

Loading