[APM] Error rate on service list page is not in sync with the value at the transaction page#80814
Merged
cauemarcondes merged 6 commits intoelastic:masterfrom Oct 20, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
reviewed
Oct 16, 2020
x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts
Outdated
Show resolved
Hide resolved
dgieselaar
approved these changes
Oct 16, 2020
Contributor
dgieselaar
left a comment
There was a problem hiding this comment.
LGTM, one small nit 👍
dgieselaar
reviewed
Oct 16, 2020
x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Oct 16, 2020
x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Oct 16, 2020
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
Agree with @dgieselaar's comments. Apart from that 👍
Contributor
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Oct 20, 2020
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Oct 20, 2020
…t the transaction page (elastic#80814) * fixing error rate * addressing pr comments * addressing pr comments * fixing TS issue * fixing api test
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Oct 20, 2020
…t the transaction page (elastic#80814) * fixing error rate * addressing pr comments * addressing pr comments * fixing TS issue * fixing api test
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 20, 2020
* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #80475