80697: ignore 404, check if there are transforms in results.#80721
Merged
nnamdifrankie merged 5 commits intoelastic:masterfrom Oct 16, 2020
Merged
Conversation
Contributor
Author
|
@elastic/endpoint-management |
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
approved these changes
Oct 16, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
Code LGTM. Left a notes with suggested fixes re: logger/mocking. Please apply before merging.
| return Registry.getAsset(path); | ||
| }; | ||
|
|
||
| export const getLogger = (): Logger => { |
Contributor
There was a problem hiding this comment.
Please remove this and instead import appContextService where it's needed to remain consistent with the rest of the plugin.
| jest.mock('./common', () => { | ||
| return { | ||
| getAsset: jest.fn(), | ||
| getLogger: jest.fn(), |
Contributor
There was a problem hiding this comment.
Please drop this and add something like
in a before/beforeEach
neptunian
approved these changes
Oct 16, 2020
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
nnamdifrankie
added a commit
to nnamdifrankie/kibana
that referenced
this pull request
Oct 16, 2020
…tic#80721) [Ingest]: ignore 404, check if there are transforms in results
nnamdifrankie
added a commit
that referenced
this pull request
Oct 16, 2020
…) (#80853) [Ingest]: ignore 404, check if there are transforms in results
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (51 commits) [Discover] Unskip flaky test (elastic#80670) Fix security solution template label (elastic#80754) [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721) Moving loader to logo in header, add a slight 250ms pause (elastic#78879) [Security Solution][Cases] Fix bug with case connectors (elastic#80642) Update known-plugins.asciidoc (elastic#75388) [Lens] Add median operation (elastic#79453) Fix navigateToApp logic when navigating to the current app. (elastic#80809) [Visualizations] Fix bad color mapping with multiple split series (elastic#80801) [ILM] Add esErrorHandler for the new es js client (elastic#80302) Fix codeowners (elastic#80826) skip flaky suite (elastic#79463) [Timelion] Remove kui usage (elastic#80287) [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779) [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579) Allow the default space to be accessed via `/s/default` (elastic#77109) Add script to identify plugin dependencies for TS project references migration (elastic#80463) [Search] Client side session service (elastic#76889) feat: 🎸 add separator for different context menu groups (elastic#80498) Lazy load reporting (elastic#80492) ...
pzl
pushed a commit
to pzl/kibana
that referenced
this pull request
Jan 21, 2021
pzl
pushed a commit
to pzl/kibana
that referenced
this pull request
Jan 21, 2021
pzl
added a commit
that referenced
this pull request
Jan 21, 2021
pzl
added a commit
that referenced
this pull request
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#80697
Summary
Checklist
Delete any items that are not applicable to this PR.