Skip to content

[7.11] [Fleet]: ignore 404, check if there are transforms in results. (#80721)#88967

Merged
pzl merged 1 commit intoelastic:7.11from
pzl:backport/7.11/pr-80721
Jan 21, 2021
Merged

[7.11] [Fleet]: ignore 404, check if there are transforms in results. (#80721)#88967
pzl merged 1 commit intoelastic:7.11from
pzl:backport/7.11/pr-80721

Conversation

@pzl
Copy link
Copy Markdown
Member

@pzl pzl commented Jan 21, 2021

Backport of #80721 into 7.11

This is a moderately old PR, that was backported to 7.10 in the day, but was not backported to 7.x, so when 7.11 was created, it also lacked this.

This is an important fix for two reported 7.11 bugs: #88630 and #88249

@pzl pzl added the backport This PR is a backport of another PR label Jan 21, 2021
@pzl pzl requested review from a team and kevinlog January 21, 2021 13:41
@skh
Copy link
Copy Markdown
Contributor

skh commented Jan 21, 2021

What about those lines from the original PR, did they make it into 7.x some other way?

https://github.com/elastic/kibana/pull/80721/files#diff-b40ad176fe9b892e2f866f7b83ce8630fd96a9fc55f75e3f6e701d01098e1726R51-R61

@pzl
Copy link
Copy Markdown
Member Author

pzl commented Jan 21, 2021

What about those lines from the original PR, did they make it into 7.x some other way?

Yes, it looks like the if + for there seemed to make it into 7.11 some other way

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need codeowners' approval on backports, but here's one anyway.

@pzl pzl merged commit e6d73e7 into elastic:7.11 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants