[Search] Client side session service by lizozom · Pull Request #76889 · elastic/kibana

lizozom · 2020-09-07T15:51:12Z

Summary

This PR introduces the frontend session management service as part of #61738, and integrates it into the discover, by initializing a session before fetching fresh data from the server.

This PR also uses the session service, to show the timeout error once per session, instead of using a debounce.

Dev Docs

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…-session-service

lukasolson

I think we need to have a discussion about whether or not we decide to make the sessionService stateful, or to expect to pass the sessionId everywhere. Right now we're doing a mix of both (e.g. in searchSource) and I think we should make a choice to do one or the other.

Also, I'm not totally sure I understand all of the changes to dashboard app controller. Maybe we can chat about those.

src/plugins/data/public/search/search_interceptor.ts

…-session-service

Add original error to expression exception

…alignment

lizozom · 2020-10-13T15:39:39Z

@Dosant I agree about the impact of removing the debounce. It is one of the reasons for not trying to merge this into 7.10. I want to have a separate PR for the visualize and dashboard integrations, as they are not as simple as this one and require a significant amount of functional tests.

majagrubic

I made a quick pass through this, works well, but I haven't tested it in depth. Overall, the changes make sense, no major comments there.

Some minor questions below.

src/plugins/data/common/utils/tap_once.ts

test/plugin_functional/test_suites/data_plugin/index_patterns.ts

test/plugin_functional/plugins/session_notifications/public/plugin.tsx

…-session-service

majagrubic · 2020-10-14T13:45:58Z

src/plugins/data/common/utils/tap_once.test.ts

    });
  });
+
+  test('fires once even when there is an error', async (done) => {


Great for adding a test case!

Dosant

Recent code change LGTM, didn't retest
Thanks for looking into clear() thing

…-session-service

src/plugins/data/public/search/expressions/esaggs.ts

src/plugins/data/common/utils/tap_once.ts

…-session-service

kibanamachine · 2020-10-15T11:26:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4d11ab6

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`data`	568	576	+8

async chunks size

id	before	after	diff
`dashboard`	221.4KB	221.3KB	-122.0B
`discover`	439.4KB	439.5KB	+90.0B
total			-32.0B

distributable file count

id	before	after	diff
`default`	48495	48497	+2
`oss`	29211	29213	+2

page load bundle size

id	before	after	diff
`data`	1.1MB	1.1MB	+10.5KB
`dataEnhanced`	34.6KB	34.6KB	-24.0B
total			+10.5KB

History

💔 Build #81805 failed a2f9b65
💚 Build #81791 succeeded 0cca933
💔 Build #81674 failed 798dc5e
💔 Build #81661 failed 52aa231
💚 Build #81599 succeeded c8294b6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant

* Add a session service and use it in discover and dashboard * check unefined * Start session in visualize * Fix tests * docs * OSS error alignemnt * Adjust error messages in xpack * Add getErrorMessage * Use showError in vizualize Add original error to expression exception * Cleanup * ts, doc and i18n fixes * Fix jest tests * Fix functional test * functional test * ts * Update functional tests * Add unit tests to interceptor and timeout error * expose toasts test function * doc * typos * lint * Cleanup * review 1 * Code review * doc * doc fix * visualization type fix * fix jest * Fix xpack functional test * fix xpack test * code review * Add tracking methods to session service * remove chromium * Fix ts and jest tests * jest + docs * ts fix * siem test * Use session service to show a timeout notification per session + more unit tests * ts and docs * Remove session service from search source (not needed) * Code review * ts * Single active session in FE session service * Cleanup * Don't integrate with dashboard \ visualize Add functional tests for session toast plugin * Typescript * ts * Improve functional tests * es * simplify filter test * wait until loadedw * filter test * delete crypto for now * Select the correct index 🤦 * timerange * Adjust functional test logic * improved test format @Dosant * Handle exceptions * Don't close sessions automatically, warn instead * jest * Adjust functional test * Remove unused code * delete export Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

@Dosant

* Add a session service and use it in discover and dashboard * check unefined * Start session in visualize * Fix tests * docs * OSS error alignemnt * Adjust error messages in xpack * Add getErrorMessage * Use showError in vizualize Add original error to expression exception * Cleanup * ts, doc and i18n fixes * Fix jest tests * Fix functional test * functional test * ts * Update functional tests * Add unit tests to interceptor and timeout error * expose toasts test function * doc * typos * lint * Cleanup * review 1 * Code review * doc * doc fix * visualization type fix * fix jest * Fix xpack functional test * fix xpack test * code review * Add tracking methods to session service * remove chromium * Fix ts and jest tests * jest + docs * ts fix * siem test * Use session service to show a timeout notification per session + more unit tests * ts and docs * Remove session service from search source (not needed) * Code review * ts * Single active session in FE session service * Cleanup * Don't integrate with dashboard \ visualize Add functional tests for session toast plugin * Typescript * ts * Improve functional tests * es * simplify filter test * wait until loadedw * filter test * delete crypto for now * Select the correct index 🤦 * timerange * Adjust functional test logic * improved test format @Dosant * Handle exceptions * Don't close sessions automatically, warn instead * jest * Adjust functional test * Remove unused code * delete export Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (51 commits) [Discover] Unskip flaky test (elastic#80670) Fix security solution template label (elastic#80754) [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721) Moving loader to logo in header, add a slight 250ms pause (elastic#78879) [Security Solution][Cases] Fix bug with case connectors (elastic#80642) Update known-plugins.asciidoc (elastic#75388) [Lens] Add median operation (elastic#79453) Fix navigateToApp logic when navigating to the current app. (elastic#80809) [Visualizations] Fix bad color mapping with multiple split series (elastic#80801) [ILM] Add esErrorHandler for the new es js client (elastic#80302) Fix codeowners (elastic#80826) skip flaky suite (elastic#79463) [Timelion] Remove kui usage (elastic#80287) [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779) [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579) Allow the default space to be accessed via `/s/default` (elastic#77109) Add script to identify plugin dependencies for TS project references migration (elastic#80463) [Search] Client side session service (elastic#76889) feat: 🎸 add separator for different context menu groups (elastic#80498) Lazy load reporting (elastic#80492) ...

gchaps · 2020-12-03T17:22:38Z

@lizozom Please update the "Dev Docs" section in the summary to include content that we can pull for the API plugin changes doc.

bhavyarm · 2021-01-25T22:04:02Z

@lizozom how do I test this PR please? Thanks!

Liza K added 4 commits September 7, 2020 12:32

Add a session service and use it in discover and dashboard

1396af4

check unefined

7bc93c3

Merge branch 'master' of github.com:elastic/kibana into search/client…

e6f31d8

…-session-service

Start session in visualize

7de920f

lizozom added Feature:Search Querying infrastructure in Kibana Team:AppArch v7.10.0 v8.0.0 labels Sep 7, 2020

Liza K added 4 commits September 8, 2020 14:01

Merge branch 'master' of github.com:elastic/kibana into search/client…

b6eac29

…-session-service

Fix tests

9615706

Merge branch 'master' of github.com:elastic/kibana into search/client…

812015d

…-session-service

docs

739dde9

lukasolson reviewed Sep 13, 2020

View reviewed changes

src/plugins/data/public/search/search_interceptor.ts Outdated Show resolved Hide resolved

Liza K added 17 commits September 14, 2020 16:05

Merge branch 'master' of github.com:elastic/kibana into search/client…

a9dec42

…-session-service

OSS error alignemnt

63c04d3

Adjust error messages in xpack

fc6d3c2

Add getErrorMessage

154a146

Use showError in vizualize

12e7898

Add original error to expression exception

Cleanup

f1390e2

ts, doc and i18n fixes

1f9c340

Fix jest tests

e6a794d

Fix functional test

13be80c

functional test

3e9dc9b

ts

6f0b080

Merge branch 'master' of github.com:elastic/kibana into search/error-…

4f73686

…alignment

Update functional tests

021d12f

Add unit tests to interceptor and timeout error

3035450

expose toasts test function

dd48dd2

doc

21b44b7

typos

aaa08cc

lizozom requested a review from lukasolson October 13, 2020 15:39

majagrubic reviewed Oct 13, 2020

View reviewed changes

src/plugins/data/common/utils/tap_once.ts Outdated Show resolved Hide resolved

test/plugin_functional/test_suites/data_plugin/index_patterns.ts Show resolved Hide resolved

test/plugin_functional/plugins/session_notifications/public/plugin.tsx Show resolved Hide resolved

majagrubic approved these changes Oct 14, 2020

View reviewed changes

Liza K added 2 commits October 14, 2020 16:17

Merge branch 'master' of github.com:elastic/kibana into search/client…

1483a41

…-session-service

Handle exceptions

c8294b6

majagrubic reviewed Oct 14, 2020

View reviewed changes

majagrubic approved these changes Oct 14, 2020

View reviewed changes

Liza K added 2 commits October 14, 2020 18:19

Don't close sessions automatically, warn instead

52aa231

jest

798dc5e

Dosant approved these changes Oct 14, 2020

View reviewed changes

Liza K added 2 commits October 15, 2020 08:04

Adjust functional test

e181864

Merge branch 'master' of github.com:elastic/kibana into search/client…

0cca933

…-session-service

ppisljar reviewed Oct 15, 2020

View reviewed changes

src/plugins/data/public/search/expressions/esaggs.ts Show resolved Hide resolved

ppisljar reviewed Oct 15, 2020

View reviewed changes

src/plugins/data/common/utils/tap_once.ts Outdated Show resolved Hide resolved

Liza K added 3 commits October 15, 2020 11:29

Merge branch 'master' of github.com:elastic/kibana into search/client…

69179e6

…-session-service

Remove unused code

a2f9b65

delete export

4d11ab6

lizozom merged commit a1831a6 into elastic:master Oct 16, 2020

lizozom mentioned this pull request Oct 16, 2020

[7.x] [Search] Client side session service (#76889) #80808

Merged

This was referenced Oct 20, 2020

[Feedback Needed][Search] Use session service on a dashboard #81192

Closed

[Search] Use session service on a dashboard #81297

Merged

Dosant mentioned this pull request Oct 28, 2020

[Search] add "restore" to session service #81924

Merged

2 tasks

Dosant mentioned this pull request Nov 18, 2020

[Search] Send to background #83640

Closed

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search] Client side session service#76889

[Search] Client side session service#76889
lizozom merged 98 commits intoelastic:masterfrom
lizozom:search/client-session-service

lizozom commented Sep 7, 2020 •

edited

Loading

Uh oh!

lukasolson left a comment

Uh oh!

Uh oh!

lizozom commented Oct 13, 2020

Uh oh!

majagrubic left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

majagrubic Oct 14, 2020 •

edited

Loading

Uh oh!

Dosant left a comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 15, 2020

Uh oh!

gchaps commented Dec 3, 2020

Uh oh!

bhavyarm commented Jan 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

lizozom commented Sep 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dev Docs

Checklist

For maintainers

Uh oh!

lukasolson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizozom commented Oct 13, 2020

Uh oh!

majagrubic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

majagrubic Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 15, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

page load bundle size

History

Uh oh!

gchaps commented Dec 3, 2020

Uh oh!

bhavyarm commented Jan 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

lizozom commented Sep 7, 2020 •

edited

Loading

majagrubic Oct 14, 2020 •

edited

Loading