[Visualizations] Fix bad color mapping with multiple split series#80801
Merged
stratoula merged 2 commits intoelastic:masterfrom Oct 16, 2020
Merged
[Visualizations] Fix bad color mapping with multiple split series#80801stratoula merged 2 commits intoelastic:masterfrom
stratoula merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Could you make sure this PR also fixes the behavior in TSVB that was described in the issue (I assume it should given the fix). And if so, we should remove the |
Contributor
Author
|
Yes I can't replicate it on TSVB After: |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
approved these changes
Oct 16, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Tested this on a xyaxis chart, seems to fix the issue. Makes also sense, that the color package accepts now 50 for 50% instead of 0.5 which d3.hsl did. Code LGTM
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 16, 2020
…astic#80801) * [Vislib] Fix bad color mapping with multiple split series * Add unit test to cover the new colors generation
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 16, 2020
…astic#80801) * [Vislib] Fix bad color mapping with multiple split series * Add unit test to cover the new colors generation
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (51 commits) [Discover] Unskip flaky test (elastic#80670) Fix security solution template label (elastic#80754) [Ingest]: ignore 404, check if there are transforms in results. (elastic#80721) Moving loader to logo in header, add a slight 250ms pause (elastic#78879) [Security Solution][Cases] Fix bug with case connectors (elastic#80642) Update known-plugins.asciidoc (elastic#75388) [Lens] Add median operation (elastic#79453) Fix navigateToApp logic when navigating to the current app. (elastic#80809) [Visualizations] Fix bad color mapping with multiple split series (elastic#80801) [ILM] Add esErrorHandler for the new es js client (elastic#80302) Fix codeowners (elastic#80826) skip flaky suite (elastic#79463) [Timelion] Remove kui usage (elastic#80287) [Ingest Manager] add skipIfNoDockerRegistry to package_install_complete test (elastic#80779) [Alerting UI] Disable "Save" button for Alerts with broken Connectors (elastic#80579) Allow the default space to be accessed via `/s/default` (elastic#77109) Add script to identify plugin dependencies for TS project references migration (elastic#80463) [Search] Client side session service (elastic#76889) feat: 🎸 add separator for different context menu groups (elastic#80498) Lazy load reporting (elastic#80492) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #80760. It fixes the wrong color mapping when multiple split series were applied on the visualizations.
Before:
After the fix:
The problem was that the hsl function with 0.5 round it to 0 which results to black