Remove unused elasticsearch.preserverHost setting#78608
Merged
rudolf merged 2 commits intoelastic:masterfrom Sep 30, 2020
Merged
Remove unused elasticsearch.preserverHost setting#78608rudolf merged 2 commits intoelastic:masterfrom
rudolf merged 2 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
spalger
approved these changes
Sep 29, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
LGTM, those are some truly ancient settings.
pgayvallet
approved these changes
Sep 29, 2020
Comment on lines
+139
to
+140
| unusedFromRoot('elasticsearch.preserveHost'), | ||
| unusedFromRoot('elasticsearch.startupTimeout'), |
Contributor
There was a problem hiding this comment.
Probably better to have it in the ES config deprecations instead:
Contributor
Author
There was a problem hiding this comment.
I was wondering about that, but my thinking was that deprecations are essential legacy or technical debt. They once belonged to a specific domain, but now they're just there to tell users they're doing something wrong until we make these config values invalid in 8.x. Instead of these distracting from the other domain code, having them isolated to one place is similar to how we isolated the legacy folder.
These other ES config deprecations require access to the ES config so they can't be centralised this way.
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
rudolf
added a commit
that referenced
this pull request
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17242
I've also removed
elasticsearch.startupTimeoutwhich was unused. Since Kibana will keep on trying to connect to Elasticsearch until it manages to connect, I don't think there's any value in having such a setting.Checklist
Delete any items that are not applicable to this PR.
For maintainers