Move indexPattern.popularizeField into discover#77668
Merged
mattkime merged 16 commits intoelastic:masterfrom Sep 30, 2020
Merged
Move indexPattern.popularizeField into discover#77668mattkime merged 16 commits intoelastic:masterfrom
mattkime merged 16 commits intoelastic:masterfrom
Conversation
kertal
reviewed
Sep 21, 2020
| return; | ||
| } | ||
| throw new Error('test error - searchscope'); | ||
| indexPattern.popularizeField(columnName, 1); |
Member
There was a problem hiding this comment.
I'm not aware of a way to add columns in the embeddable? while we may keep this code unless we're 100% sure, I don't think we should keep popularize
63 tasks
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
kertal
approved these changes
Sep 28, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, nice cleanup 👍. Added some minor remarks. Tested locally in Safari, Firefox, Chrome, works , values are increased, and no errors is displayed when this is done too fast. One last think that would make it perfect: Could you add a unit test for the popularize function? many thx!
Comment on lines
+59
to
+63
| try { | ||
| const indexPattern = await indexPatterns.get(indexPatternId); | ||
| await popularizeField(indexPattern, field.name, indexPatterns); | ||
| // eslint-disable-next-line no-empty | ||
| } catch {} |
Member
There was a problem hiding this comment.
Since the popularizeField function doesn't throw an Exception, I think you don't need to try{}catch{} here
| } | ||
|
|
||
| field.count++; | ||
| await indexPatternsService.updateSavedObject(indexPattern, 0, true).catch(); |
Member
There was a problem hiding this comment.
I'd suggest adding some context why exceptions are automatically caught like
Suggested change
| await indexPatternsService.updateSavedObject(indexPattern, 0, true).catch(); | |
| // Catch 409 errors caused by user adding columns in a higher frequency that the changes can be persisted to Elasticsearch | |
| await indexPatternsService.updateSavedObject(indexPattern, 0, true).catch(); |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Sep 30, 2020
Move indexPattern.popularizeField into discover # Conflicts: # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpattern.md # docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpatternsservice.md # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.indexpattern.md
mattkime
added a commit
that referenced
this pull request
Sep 30, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
indexPattern.popularizeFieldinto discover which is the only app where its used. Part of IndexPattern api simplification - #69379
Checklist