[UX] Add percentile selector#78562
Conversation
| const options = [ | ||
| { | ||
| value: '50', | ||
| inputDisplay: 'P50 (Median)', | ||
| 'data-test-subj': 'p50Percentile', | ||
| }, | ||
| { | ||
| value: '75', | ||
| inputDisplay: 'P75', | ||
| 'data-test-subj': 'p75Percentile', | ||
| }, | ||
| { | ||
| value: '90', | ||
| inputDisplay: 'P90', | ||
| 'data-test-subj': 'p90Percentile', | ||
| }, | ||
| { | ||
| value: '95', | ||
| inputDisplay: 'P95', | ||
| 'data-test-subj': 'p95Percentile', | ||
| }, | ||
| { | ||
| value: '99', | ||
| inputDisplay: 'P99', | ||
| 'data-test-subj': 'p99Percentile', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Can I make a suggestion to rename the percentiles to "50th (median), 75th, 90th" etc. possibly with the added title before the options labelled "Percentiles"? The reason being I don't think the average user will know that P50 etc. refers to. cc @drewpost cc @katrin-freihofner
There was a problem hiding this comment.
I like this usability suggestion. Thanks @formgeist I agree - anything we can do to help people understand this better, we should do.
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/apm-ui (Team:apm) |
| <EuiFlexItem grow={false}> | ||
| <UserPercentile /> | ||
| </EuiFlexItem> |
There was a problem hiding this comment.
I would suggest aligning the percentile selector by the date picker. This is a global selector like the time range, so it feels more natural to place adjacent to that option.
There was a problem hiding this comment.
We could choose to add a prepended label in front of the selector which displays "Aggregation" or "Agg." shortened.
There was a problem hiding this comment.
It might be nice to indicate that this is "active" when it isn't set to the default value of P50. This value gets persisted in the URL so someone could get linked to this state and be unaware.
justinkambic
left a comment
There was a problem hiding this comment.
This is looking good to me, seems to work as expected. Had a comment agreeing with what @formgeist said about the positioning of the percentile selector.
| <EuiFlexItem grow={false}> | ||
| <UserPercentile /> | ||
| </EuiFlexItem> |
There was a problem hiding this comment.
It might be nice to indicate that this is "active" when it isn't set to the default value of P50. This value gets persisted in the URL so someone could get linked to this state and be unaware.
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
formgeist
left a comment
There was a problem hiding this comment.
Design/UX looks good. The only nit is the selected percentile state when it's different than the default. I don't have a better suggestion at this time.
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
Summary
Fixes: #78657
Added a percentile selector for UX app.
User can choose what threshold percentile they want to view all the metrics at.
User can choose between 50,75,90,95,99
This percentile selector doesn't affect page load, page view and visitor breakdowns charts.