[Observability] Kibana nav when docked overlaps the content of the pages.#78593
Merged
cauemarcondes merged 3 commits intoelastic:masterfrom Sep 30, 2020
Merged
[Observability] Kibana nav when docked overlaps the content of the pages.#78593cauemarcondes merged 3 commits intoelastic:masterfrom
cauemarcondes merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
retest |
Contributor
|
@cauemarcondes Works, but I wonder if it's possible to set a breaking point where those columns goes into a single column? That improve the readability of the content on smaller viewports as well as when the nav is docked. Something like this?
There's obviously more we can do, but that will fix most of the responsive issues with the page, I think. |
Contributor
Author
|
@formgeist I updated the description adding some images of the breakpoints. |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Sep 30, 2020
formgeist
approved these changes
Sep 30, 2020
Contributor
formgeist
left a comment
There was a problem hiding this comment.
LGTM! Thanks for resolving this
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Sep 30, 2020
…ges. (elastic#78593) * adding padding left * adding space left to appSection
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #78386