Merged
Conversation
alexwizp
commented
Sep 24, 2020
Contributor
Author
There was a problem hiding this comment.
Differences are marked in bold green:
Valid for all updated snapshots!
sulemanof
approved these changes
Sep 24, 2020
Contributor
sulemanof
left a comment
There was a problem hiding this comment.
LGTM, didn't test locally.
Any idea why visTypeVega chunk size increased significantly? (+977.1KB)
Did updated vega significantly increase its size or the diff calculation is wrong?
alexwizp
commented
Sep 24, 2020
Contributor
Author
There was a problem hiding this comment.
It was a hack for IE cause this browser doesn't support es6. Now we don't support IE and this ugly part can be removed
alexwizp
commented
Sep 24, 2020
Contributor
Author
There was a problem hiding this comment.
#71713 issue was closed. The comment is not relevant
Contributor
Author
|
This PR blocked by vega/vega-lite#6900 |
Contributor
Author
|
@elasticmachine merge upstream |
1 task
Contributor
Author
|
We decided to temporarily continue using the es5 version of vega libs until the following issue will be resolved: vega/vega-lite#6912 |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Sep 30, 2020
# Conflicts: # yarn.lock
alexwizp
added a commit
that referenced
this pull request
Sep 30, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) [UiActions] Don't throw an error if there are no compatible actions to execute (elastic#78917) [Observability] Kibana nav when docked overlaps the content of the pages. (elastic#78593) Invalid `searchSourceJSON` causes saved object migration to fail (elastic#78535) update vega version (elastic#78390) Fix warning text doesn't get displayed on filters with custom filter name (elastic#78617) [ILM] Data tier notices should reflect tier preferences (elastic#78398) [APM] Service Map: `Not Defined` option doesn't work properly (elastic#77757) Improve invalid field error message at search.aggs.param_types.field (elastic#78587) Remove isDeprecated flag on visType (elastic#78820) Remove unused elasticsearch.preserverHost setting (elastic#78608) Fix condition and adjust tests (elastic#78898) [UX] Add percentile selector (elastic#78562) [ML] Replace use of rest_total_hits_as_int with track_total_hits (elastic#78423) expression service docs (elastic#78774) [Functional] Wait for the page to load and then click the new vis button (elastic#78725) [TSVB] No data in visualizations with annotations (elastic#78794) [kbn/ui-shared-deps] track asset sizes (elastic#78718) delete target before building (elastic#78665) Move indexPattern.popularizeField into discover (elastic#77668) [Security Solution][Resolver]Add backdrop to pills (elastic#78625) ...
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #78387
Summary
Update
vegaversion:vega: 5.13.0 ➡️ 5.16.1 Changelog: https://github.com/vega/vega/releasesvega-lite: 4.13.1 ➡️ 4.16.8 Changelog: https://github.com/vega/vega-lite/releasesvega-schema-url-parser: ^1.1.0 ➡️ ^2.1.0vega-tooltip: ^0.12.0 ➡️ ^0.24.2All sample visualizations have been tested. No regression found 🥳
Checklist
Delete any items that are not applicable to this PR.
For maintainers