Upgrade EUI to v28.2.0 by thompsongl · Pull Request #75700 · elastic/kibana

thompsongl · 2020-08-21T20:21:50Z

Summary

v27.4.1 ⏩ v28.2.0

Support for @elastic/charts@20.x
New pluggable EuiMarkdownEditor and EuiMarkdownFormat components
New EuiSelectableTemplateSitewide component for global search

`28.2.0`

Added EuiSelectableTemplateSitewide as wrapper of EuiSelectable for Elastic's global search component (#3800)
Updated styles of EuiMark to override browser default (#3800)
Updated EuiHighlight to use EuiMark as matching element wrapper (#3800)
Enhanced EuiSelectable's option type to allow for a separate searchableLabel and any generic keys (#3800)
Added listProps.onFocusBadge, loadingMessage, noMatchesMessage, and emptyMessage props to EuiSelectable (#3800)
Added bordered prop to EuiSelectableMessage (#3800)

Bug fixes

Fixed display of EuiBadge if only the iconType is passed (#3800)
Fixed accessibility error in EuiSelectable when the list isn't on the page (#3800)
Fixed accessibility error in EuiPopover when ownFocus = false (#3800)

`28.1.0`

Added isLoading and isLoadingMessage props to EuiAccordion (#3879)
Added testenv mock for EuiFocusTrap (#3930)

Bug fixes

Fixed bug in EuiCodeBlock content overlapping with control buttons when whiteSpace was set to "pre" (#3853)
Fixed EuiFocusTrap not applying provided style prop (#3916)
Fixed bug in EuiDataGrid when a new pagination object would cause every cell to render (#3919)

`28.0.0`

Update createTheme to apply latest changes to elastic charts Theme. (#3792)
Added icons for appSearchApp and workplaceSearchApp to EuiIcon (#3859)
Added unlink glyph to EuiIcon (#3869)
Added EuiMarkdownEditor and EuiMarkdownFormat components (#3522)

Bug fixes

Fixed EuiFacetGroup container expansion due to negative margin value (#3871)
Fixed EuiComboBox delimeter-separated option creation and empty state prompt text (#3841)
Fixed EuiDataGrid not properly resizing within a fixed height container (#3894)
Fixed bug in EuiFieldPassword where an edge case mutated its append prop (#3884)

Breaking changes

Requires @elastic/charts version 20.0.0 and above for chart theming utils.

package.json

nickofthyme · 2020-08-25T02:48:45Z

Charts updates include

fix #73167
close #75031

nickofthyme · 2020-08-25T14:16:13Z

@thompsongl it looks like the failing test (Security solution Cypress Tests) is from the search_bar.spec.ts. Let me know if this is due to my changes and I can look into it.

thompsongl · 2020-08-25T14:29:17Z

Let me know if this is due to my changes and I can look into it.

Unrelated. I'll take on fixing it.

x-pack/plugins/security_solution/public/common/components/charts/barchart.tsx

thompsongl · 2020-08-25T17:01:41Z

@elasticmachine merge upstream

smith

APM changes look good!

nreese

maps changes LGTM

pgayvallet

LGTM for platform changes

thompsongl · 2020-08-26T14:29:53Z

@elasticmachine merge upstream

wylieconlon

Tested and reviewed the changes to Lens, LGTM.

thompsongl · 2020-08-26T17:23:40Z

@elasticmachine merge upstream

…i/28

crob611

Canvas just has a snapshot update and it looks good to me. 👍

igoristic

Stack Monitoring looks good 👍

justinkambic

I think we have a boolean flipped to false instead of true.

x-pack/plugins/observability/public/components/app/section/uptime/index.tsx

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

justinkambic

Uptime changes LGTM!

stratoula

Kibana App team Code review LGTM, I also checked the bug on TSVB and it is fixed 🎉 Lens settings panel works as expected and is much better now 👏

thompsongl · 2020-08-31T15:10:02Z

@elasticmachine merge upstream

kibanamachine · 2020-08-31T16:58:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b09968c

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
canvas	1200	-3	1203

async chunks size

id	value	diff	baseline
apm	4.7MB	+552.0B	4.7MB
canvas	1.4MB	-1.3KB	1.4MB
enterpriseSearch	358.5KB	+89.0B	358.4KB
maps	3.3MB	+40.0B	3.3MB
observability	296.9KB	+15.0B	296.9KB
securitySolution	9.5MB	+736.0B	9.5MB
visTypeTimeseries	1.8MB	+1.2KB	1.8MB
total		+1.3KB

page load bundle size

id	value	diff	baseline
lens	867.3KB	+93.0B	867.2KB
upgradeAssistant	64.8KB	+89.0B	64.7KB
total		+182.0B

oss distributable file count

id	value	diff	baseline
total	27303	+1057	26246

distributable file count

id	value	diff	baseline
total	45423	+1055	44368

History

💚 Build #71078 succeeded 697e22e
💚 Build #71018 succeeded bba12aa
💚 Build #70915 succeeded a0e15c4
💚 Build #70590 succeeded 5502061
💔 Build #70514 failed be22a9b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* eui to v28.0.0 * eui to 28.2.0 * euiselectableoptions type update * targeted nohoist * src snapshot updates * x-pack snapshot updates * strong -> mark * upgrade @elastic/charts to v21.0.1 * strong -> mark * fix charts version merge * maps -> add_field_tooltip_popover type update * snapshot update * Fix gridline visibility Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

* eui to v28.0.0 * eui to 28.2.0 * euiselectableoptions type update * targeted nohoist * src snapshot updates * x-pack snapshot updates * strong -> mark * upgrade @elastic/charts to v21.0.1 * strong -> mark * fix charts version merge * maps -> add_field_tooltip_popover type update * snapshot update * Fix gridline visibility Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

thompsongl added 9 commits August 14, 2020 11:28

eui to v28.0.0

95603c8

eui to 28.2.0

7300fb1

euiselectableoptions type update

0b61abc

targeted nohoist

1503a32

Merge branch 'master' into eui/28

5246fc3

Merge branch 'master' into eui/28

acc3341

src snapshot updates

a2b362d

x-pack snapshot updates

fada153

strong -> mark

ef0f143

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 21, 2020

Merge branch 'master' into eui/28

cd2c288

thompsongl commented Aug 21, 2020

View reviewed changes

package.json Show resolved Hide resolved

upgrade @elastic/charts to v21.0.1

9590474

thompsongl added 2 commits August 25, 2020 08:30

Merge branch 'master' into eui/28

2992615

strong -> mark

3ed7fd1

This was linked to issues Aug 25, 2020

TSVB chart doesn't render when axis min is outside data range #73167

Closed

[Lens] Enable fitting functions for stacked area charts #75031

Closed

markov00 reviewed Aug 25, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/charts/barchart.tsx Show resolved Hide resolved

Merge branch 'master' into eui/28

08f7a68

elasticmachine and others added 3 commits August 25, 2020 11:01

Merge branch 'master' into eui/28

8b0f8c7

Merge branch 'master' into eui/28

d736e06

fix charts version merge

0f79738

thompsongl marked this pull request as ready for review August 25, 2020 21:13

thompsongl requested a review from a team August 25, 2020 21:13

smith approved these changes Aug 25, 2020

View reviewed changes

maps -> add_field_tooltip_popover type update

a2b6673

nreese approved these changes Aug 26, 2020

View reviewed changes

pgayvallet approved these changes Aug 26, 2020

View reviewed changes

elasticmachine and others added 2 commits August 26, 2020 08:30

Merge branch 'master' into eui/28

be22a9b

Merge branch 'master' into eui/28

36e4e8a

wylieconlon approved these changes Aug 26, 2020

View reviewed changes

elasticmachine and others added 4 commits August 26, 2020 11:23

Merge branch 'master' into eui/28

5502061

Merge branch 'master' into eui/28

4ee5ed3

Merge branch 'eui/28' of https://github.com/thompsongl/kibana into eu…

0ef0186

…i/28

snapshot update

a0e15c4

crob611 approved these changes Aug 27, 2020

View reviewed changes

igoristic approved these changes Aug 27, 2020

View reviewed changes

justinkambic requested changes Aug 27, 2020

View reviewed changes

x-pack/plugins/observability/public/components/app/section/uptime/index.tsx Outdated Show resolved Hide resolved

Fix gridline visibility

bba12aa

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>

thompsongl requested a review from justinkambic August 27, 2020 19:52

justinkambic approved these changes Aug 27, 2020

View reviewed changes

Merge branch 'master' into eui/28

697e22e

stratoula approved these changes Aug 31, 2020

View reviewed changes

Merge branch 'master' into eui/28

b09968c

patrykkopycinski approved these changes Aug 31, 2020

View reviewed changes

thompsongl merged commit ee73c59 into elastic:master Aug 31, 2020

thompsongl mentioned this pull request Aug 31, 2020

[7.x] Upgrade EUI to v28.2.0 (#75700) #76313

Merged

nickofthyme mentioned this pull request Aug 31, 2020

[Lens] Enable fitting functions for stacked area charts #75031

Closed

Conversation

thompsongl commented Aug 21, 2020

Summary

28.2.0

28.1.0

28.0.0

Uh oh!

Uh oh!

nickofthyme commented Aug 25, 2020

Uh oh!

nickofthyme commented Aug 25, 2020

Uh oh!

thompsongl commented Aug 25, 2020

Uh oh!

Uh oh!

thompsongl commented Aug 25, 2020

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Aug 26, 2020

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Aug 26, 2020

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Aug 31, 2020

Uh oh!

kibanamachine commented Aug 31, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

oss distributable file count

distributable file count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

`28.2.0`

`28.1.0`

`28.0.0`