Don't re-generate DataGridContext from pagination#3919
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Aug 17, 2020
Merged
Don't re-generate DataGridContext from pagination#3919chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall merged 3 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3919/ |
Contributor
Author
|
jenkins test this
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3919/ |
thompsongl
approved these changes
Aug 14, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Tested with the profiler 🦑
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3919/ |
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
* Don't re-generate DataGridContext from pagination * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3880
DataGridContexthas been dependent on thepaginationprop, so any re-renders of an EuiDataGrid+pagination (or its parent) has been triggering all cells to re-render. There's no need for that context to be pagination-dependent, so that has been removed.I also verified a datagrid with no pagination continues to work as expected
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes