Fix datagrid not fitting into containers#3894
Merged
snide merged 2 commits intoelastic:masterfrom Aug 12, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3894/ |
thompsongl
approved these changes
Aug 11, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM; confirmed with the docs deployment that the "Data grid adapts to its container" example is as it should be.
Contributor
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3894/ |
Contributor
|
:grumble: jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3894/ |
Contributor
|
@snide @thompsongl curious, how would implementing Emotion affect this? Can we ask it to generate classnames? |
Contributor
Author
|
Yes, it forces it through the css prop, which generates the selector without using className directly. |
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
* Fix datagrid not fitting into containers * cl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3878
Related to theKashey/react-focus-on#47 , our focus trap solution didn't accept
styleprops. Regardless, it acceptsclassNameand we should use that instead.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Props have proper autodocs[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes