Add test-env mock for EuiFocusTrap#3930
Merged
thompsongl merged 2 commits intoelastic:masterfrom Aug 17, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3930/ |
chandlerprall
approved these changes
Aug 17, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
🦑 thanks for putting this together & testing in Kibana!
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
* add testenv mock for euifocustrap * CL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The most recent EUI upgrade in Kibana increased Jest test flakiness and ultimately exposed recently changed EuiFocusTrap dependencies to significantly lengthen unit test run times (leading to timeout-based failures).
This PR introduces a testenv mock for EuiFocusTrap which will prevent library internals from unnecessarily interfering with downstream unit tests.
The effective result in Kibana is up to 85% faster runs in affected unit tests, 0 behavioral changes, and surprisingly few snapshot updates.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes