Changed margin-right to margin-left to fix container expansion issue#3871
Merged
elizabetdev merged 3 commits intoelastic:masterfrom Aug 6, 2020
Merged
Changed margin-right to margin-left to fix container expansion issue#3871elizabetdev merged 3 commits intoelastic:masterfrom
elizabetdev merged 3 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3871/ |
elizabetdev
approved these changes
Aug 6, 2020
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks @TAYTS,
I tested the changes locally in Firefox, Safari and IE11 and it looks good! 🎉
nyurik
pushed a commit
that referenced
this pull request
Aug 18, 2020
…3871) * Changed margin-right to margin-left to fix container expansion issue * Updated CHANGELOG.md Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed #3737 : Changed margin-right to margin-left in EuiFacetGroup to fix container expansion due to negative margin value.
Checklist
- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes